Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbXLCPJW (ORCPT ); Mon, 3 Dec 2007 10:09:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750706AbXLCPJN (ORCPT ); Mon, 3 Dec 2007 10:09:13 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:34763 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbXLCPJM (ORCPT ); Mon, 3 Dec 2007 10:09:12 -0500 Date: Mon, 3 Dec 2007 15:09:05 +0000 From: Christoph Hellwig To: Timothy Shimmin Cc: Christoph Hellwig , Chris Wedgwood , linux-xfs@oss.sgi.com, LKML Subject: Re: [PATCH] xfs: revert to double-buffering readdir Message-ID: <20071203150905.GA18082@infradead.org> References: <20071114070400.GA25708@puku.stupidest.org> <20071125163014.GA17922@infradead.org> <474FBA21.4070201@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <474FBA21.4070201@sgi.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 14 On Fri, Nov 30, 2007 at 06:22:09PM +1100, Timothy Shimmin wrote: > Hmmm, don't see the point of "eof" local var now. > Previously bhv_vop_readdir() returned eof. > I presume if we don't move the offset (offset == startoffset) then > we're done and break out? > So we lost eof when going to the filldir in the getdents code etc... Yes, it's just copy & paste. We can trivially kill the variable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/