Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <d185a516-8d27-4e16-8c26-d9cd3f3de2a0@nvidia.com>
Date:   Tue, 5 Dec 2023 10:58:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 00/10] Multi-size THP for anonymous memory
To:     Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Yin Fengwei <fengwei.yin@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Yu Zhao <yuzhao@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Itaru Kitayama <itaru.kitayama@gmail.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Hugh Dickins <hughd@google.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Barry Song <21cnbao@gmail.com>,
        Alistair Popple <apopple@nvidia.com>
Cc:     linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20231204102027.57185-1-ryan.roberts@arm.com>
 <2be046e1-ef95-4244-ae23-e56071ae1218@nvidia.com>
 <888e20e4-6073-426c-9159-e359c758d78a@arm.com>
Content-Language: en-US
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <888e20e4-6073-426c-9159-e359c758d78a@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RE5NcHBvQjgvMTg5UGFwZ2UvdjJtWnRPVFRiOThXZ3BMM0FFMkxjTitaOG04?=
 =?utf-8?B?UXhDLzBEbllNdFZ6MCs2Q2o1UFhmL3c4endSeVlQVGtpU3FJeDN4VFdGdjda?=
 =?utf-8?B?enNuSkZTRTNyVGdxdlZyREp6bjAvM1h3eEZKbkhSOWFIY3hPVEJSMWZseE5y?=
 =?utf-8?B?NHJjcmpyTUx1eXB6RysyK1dvVDlSem9vVnRYQUtCSk9uMW03U0xJcENFNThB?=
 =?utf-8?B?YWhvd1ZkTzAwRmNDWkY5bUdMejBSTG5CSTVxVE9LWVFDUUd0SC9OdHliNWpP?=
 =?utf-8?B?RUs5ZU1FZFRoSllETVhCY29sTlJDcWlRRWZONTh6cWNiSmhmSkM0bnZHV2Rl?=
 =?utf-8?B?cnQ4OG9Cc0U5bTRZRWxITGIvUkFuby9ZY3pjbHVTZHVPR0pqdWZqRUtZdytC?=
 =?utf-8?B?UjZTZlZMU0dabzFTUzFvTWNlNXJBdkFZZWFZWU1jZWdLaHZSR3N2UXRNaUpi?=
 =?utf-8?B?RVdjcHo1dGhCQlFUSU5KMDFLUWhBanpJa01xRDhXWWJNVFoxcnFGMFFld21p?=
 =?utf-8?B?em9hSkhlL0FSMUxpWGxIT2s3bHdWRC9lbWI2cUx4UmR0VlFNc0lSWXU3cGky?=
 =?utf-8?B?UVFuYnFGczU5MnF1R0hwRTE2amxFa1hJZDU3enZYUFZ4VlJrNUI0cHpaSzJG?=
 =?utf-8?B?NWpLZnhCbmN1c2tiZGlidzZHc1h3MVRjTGsyWGZ1a2tVZjA2MGNHaXA3MjhV?=
 =?utf-8?B?b2dKekxDbzdNd1NzL21xWThRdXl3STdQNWdzbmpSeE5oRndnVVN0RXFJL3FR?=
 =?utf-8?B?NUdleXptVHB6RVB5RU9CUmR5dGxxVHlLVVNzT1hFU012bWFaNERCRlFZNzFC?=
 =?utf-8?B?K3RycExDbkxrLzNBOFh4ZGEzcUY2dXpocTZoVjRwMWR6WTMzVUhVS0pES3lp?=
 =?utf-8?B?QTRIWlZET04yLzJuWGtMWk9BM2NVb3RjZUliNTNSZnFHWFlGWlZ1NndKc0hD?=
 =?utf-8?B?M2p1a2U4SkdQT05UcFBZZ3A1Nm1nYUR2SWpzcVNtMEROcDhwMCtIOStlRWND?=
 =?utf-8?B?RGN1LzV2NnA1S0ExUTFJQTBiblNFVXhoQkxMY0ZwNUpJbzA0TUlBQlhTVHVv?=
 =?utf-8?B?N1V1UlpvZjNCN25nQnoxREtTQllGYlZyTTVPSGIzL2hkSmV2WCthdkFWd0p1?=
 =?utf-8?B?RU4vSXpOSkNYVHl3ZEE2VjFFWDdid1dWSUY0R3ZZQU43NTVBcmxHNUIvRGh1?=
 =?utf-8?B?NVJkbFM0YzBENlJOVG5JZ050M25QYkd5VGhZNnpYZ0d3bFhwSGFHdTI1LytL?=
 =?utf-8?B?Nk0vYzMxRVdJN01yQlZiVnpmWVMrVnI5YUNGVzZxemVKeHhlZFM0ZUhXaUxj?=
 =?utf-8?B?dlBLdlpWckVTaDYzbXFFYS9RYUVVNk50NUJHbDA3MER1WVdFYmE1TjlpalR3?=
 =?utf-8?B?TGQwVUJvbFA3S3dBcE1kTFV0eVpGZUU5dWFsVE8xLzRlSy9rLzkyMGV6MU5Q?=
 =?utf-8?B?VUN0MmhNd1pqcnZHaktJMitDTEZxYWt0dkl2TUMrTnZBcWxtM0txR2E2WjB3?=
 =?utf-8?B?ZXpaVnFoV243cGZPL0taVFE4aEw0VEZTL2UzekdCUnd2cVFnY3lWeGI2bGps?=
 =?utf-8?B?WDJXRHZ6WUxSRzNVb0ZoZFNWcEMxeUY0bkhxZGlFTjNpVjJqZUVLOHRMSzlX?=
 =?utf-8?B?djdreGYyUmxnbWZhQ0w2MzVIaDJWcUx4YURLckJGa3htYVM3RmQ2MHJXREdG?=
 =?utf-8?B?eEcwQ1dlYlRnWHdZelJZVjhiSE1yN3pMZzREM2QzSWVVTlF4L1hZZXdUVkZD?=
 =?utf-8?B?dFJSZ2x6N2ZLa2pEODlxZjlnOTlNWk54dW0wc3BnM1NPWmt4SGRndHg2d0RJ?=
 =?utf-8?B?bWViVE1hVE5aQ3NHWEQ1QWV6N2JpdnZhaVRwbUFMUzIxVTV2TVFmZTQ0WU5p?=
 =?utf-8?B?a3JCWmI1SnBjZFc2KzZCSDFYMUdibk9pS0NoRG45Sk9KQTgxaC81cEpPckg2?=
 =?utf-8?B?TmZNYmFNOS83VjRyUWlTQ012dWNFbmF0MkkvQmJCQkd0QUxYc2NpV01TeHBP?=
 =?utf-8?B?MW0wajFPZWFSREVmNDZVYS9XYVQyRU1qQm1ycmNOZlNWVmUvRlNDR2M5SGg1?=
 =?utf-8?B?SEk2SGhWL21KOHduZEpUb1dLZkxGZGdpanpTZUd5NVN5ajJteU1DQlMxVnlv?=
 =?utf-8?Q?kpotwrPz4KsRsth8KankmetVp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b734550-901f-45d6-91c5-08dbf5c425d5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 18:58:20.2066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5fkyvaoonyzO8K4V+0RffheHz5LLWPbGp06aj8pvp+ZjAUndr6RKOZ3gQXtlMMR7kEM+JLu38GMOjuL5uri1Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5462
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 05 Dec 2023 10:58:32 -0800 (PST)

On 12/5/23 3:13 AM, Ryan Roberts wrote:
> On 05/12/2023 03:37, John Hubbard wrote:
>> On 12/4/23 02:20, Ryan Roberts wrote:
...
>> With those two patchsets applied, the mm selftests look OK--or at least
>> as OK as they normally do. I compared test runs between THP/mTHP set to
>> "always", vs "never", to verify that there were no new test failures.
>> Details: specifically, I set one particular page size (2 MB) to
>> "inherit", and then toggled /sys/kernel/mm/transparent_hugepage/enabled
>> between "always" and "never".
> 
> Excellent - I'm guessing this was for 64K base pages?


Yes.


thanks,

-- 
John Hubbard
NVIDIA