Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Tue, 5 Dec 2023 11:20:24 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     "Zhang, Rui" <rui.zhang@intel.com>
CC:     "linux@roeck-us.net" <linux@roeck-us.net>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "ashok_raj@linux.intel.com" <ashok_raj@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 1/3] hwmon: (coretemp) Introduce enum for attr index
Message-ID: <ZW93+OhBNRB+T/EM@a4bf019067fa.jf.intel.com>
References: <20231127131651.476795-1-rui.zhang@intel.com>
 <20231127131651.476795-2-rui.zhang@intel.com>
 <ZWkDQ5y3e4oPONni@araj-dh-work.jf.intel.com>
 <0646bcf5-fd41-41e5-b7b1-06b425973c86@roeck-us.net>
 <ZWllSmdI5pVGc0+3@a4bf019067fa.jf.intel.com>
 <a67fdc5ff2401519b99479c1b487b16c707ce0da.camel@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a67fdc5ff2401519b99479c1b487b16c707ce0da.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?kq8SGgxbxzMulxfc3MisP9pXD61wN5r7J+lt+0hHAOqSe6Uf6lOoLY69sh?=
 =?iso-8859-1?Q?DdZs7Z93yMCp9CcvcFPTORXfHEeIMaJAOjSLGdO8aETU0rQLpTZCtZkmFC?=
 =?iso-8859-1?Q?h5N+bylMZjm8LemRkewCgailIXCI6IFt8reJEgw5f98ZBwbumuQLbdrwxB?=
 =?iso-8859-1?Q?6JpLWHl1ZgDVfA2MbCVqBTxUfErth5YKB1+Pr0RhH4T2V27jvqvw5+EvKj?=
 =?iso-8859-1?Q?RxgfCKfR75oasTkPR895ZYkT4lcFbMrpQ+qmYqvP2LtA/5gCpi6nSnlKBP?=
 =?iso-8859-1?Q?RArF0QYd8jJopiHhUU9s2IAGrTrPD6YqNpI/sfBtDudrsnjPTQJhZWBmHK?=
 =?iso-8859-1?Q?yvE2lXWqo8fh3ei/IMqeNbXVsppgs+WsZPG2VVoPNgCHFi2stKmuqy1W3P?=
 =?iso-8859-1?Q?PG/LQyspe2OmntuPdBcjI1oxvrd31G2BxdgE1QFC2HDjbQ2Xc9AM/lj0Xm?=
 =?iso-8859-1?Q?cuGmn7L/2/n0Lb5WgUS6Nbj+USYeFJsZdb+5h2Yn6MQ5+EloTzYJsCMXjs?=
 =?iso-8859-1?Q?vlec9XvBI0rC8Dqntn3016W1On2C534CwULaHZLKXgoNIFBAhxBlnifmvx?=
 =?iso-8859-1?Q?hNQJZtFNZ4xGXYu8YdPbo/95JxRsRvOqhdcSHS3Y0wSew1U7BQl3vHWGQW?=
 =?iso-8859-1?Q?vAr0e1MIVMaS528noEtVzRK7wvtaRSo+s734w1Z3i3TsDpQVq67VFHVaRv?=
 =?iso-8859-1?Q?LCiffqjDlhCgk0hDsHCsqobmkJu76hhWDLGhFSLWKeYzZLYWta4sKmphJB?=
 =?iso-8859-1?Q?fQ3RcWVxsng5GhJPDMRZYEvkv4POB9Ojx4CkC+sMV5w6P6dgoVFaA3iHI+?=
 =?iso-8859-1?Q?mW1CXCSDZnZerDUQ3jUorZHXTFzb7lNYpfhnzV+UjLo+rEhk1EtJO2ElYX?=
 =?iso-8859-1?Q?GSL39pN3icEUseI8KiGeA/8GlCkliM9MY4kNdg1OcWzdkjsm1Nn/Jemefi?=
 =?iso-8859-1?Q?vLx35l6jt8gWP/xqBDBU5wEojDNnkmrP9uaKfibzcsmklewvXF67OVlVPc?=
 =?iso-8859-1?Q?d1Qd6mhMIqATsIUW/WgHpUvE9UKFMK83kf+S3XTLkYECV1+fLjnNNYVyrV?=
 =?iso-8859-1?Q?nfuKG/zPW5r7gemouVnZoL7XWIC7iQHVRaqiFSTcQTLopcJJtXsh0toqdp?=
 =?iso-8859-1?Q?mUgFIhKMVTAhqAmJUI+oTNezdNt0B/0U7y+lQ7+82AkPUiiVBgSjwcnJen?=
 =?iso-8859-1?Q?77rEfi5y/VTdVEAUCwYK1RigM2cnNry0Pwrf3DceXNopVx/UWKx2hP6zKR?=
 =?iso-8859-1?Q?7MHltekYRhf4xRMQfJIAZAj70Np6qR4B/eIsJXRqeEYBJOkiuToD1TOcPF?=
 =?iso-8859-1?Q?aZCKTiAVprkBkIDzsoUC9FwIvDScuohMa7DV9/DRvJNikMNaUvX9fPZkRg?=
 =?iso-8859-1?Q?vzatXPN8egelhqntygTB2oDlm04YGvmEpz1UOgGvQJTXdtT3hrF4REbMAv?=
 =?iso-8859-1?Q?uytfA/RWsPWFxRrXdg1LRC/cB0UMfTTCkVRqRwJFZ0a+mKBG+lbpOHUwHE?=
 =?iso-8859-1?Q?GvPxKOIg3uKFv8ZbHtSfIEKg5ws2AJRLfiaZFi4YMh3Roiq5TS9qcY5rJL?=
 =?iso-8859-1?Q?kNsbXjvYMPsY4Bl/LCYnLnUc4MkWXC3GkOkT4cj60FzW+83eeIuzvHpqns?=
 =?iso-8859-1?Q?LXle46fFGl+YNru+DIjZbNb8fy93tIfmS8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba9c68b6-9a96-4080-9d53-08dbf5c73d13
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 19:20:27.6389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D9UrS0V77eyX6ZW3TcFQeGinGm0/zDZeIM7SSLwk+N/8bl0KaLbHKzsyqLnPTJEZfyylC1dySaYgGYHl4ytxuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7381
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 11:20:48 -0800 (PST)

On Fri, Dec 01, 2023 at 09:29:24AM -0800, Zhang, Rui wrote:

[snip]

> > 
> > How about 
> > 
> > ATTR_LABEL,
> > ATTR_CRIT_ALARM,
> > ATTR_TEMP,
> > ATTR_TJMAX,
> > MAX_CORE_ATTRS,?????????/* One more than TJMAX */
> > ATTR_TTARGET = MAX_CORE_ATTRS,
> > TOTAL_ATTRS
> > 
> > Each enum can be assigned any value, but this way they are just
> > increasing
> > order. 
> 
> ATTR_TTARGET is the next attribute after ATTR_TJMAX so it should be
> right after ATTR_TJMAX.
> MAX_CORE_ATTRS is the number of basic attributes so it should be
> ATTR_TJMAX + 1.
> TOTAL_ATTRS is the number of possible attributes so it should be
> ATTR_TTARGET + 1
> 
> ATTR_LABEL,				// 0
> ATTR_CRIT_ALARM,			// 1
> ATTR_TEMP,				// 2
> ATTR_TJMAX,				// 3
> ATTR_TTARGET,				// 4
> MAX_CORE_ATTRS = ATTR_TJMAX + 1,	// 4
> TOTAL_ATTRS = ATTR_TTARGET + 1,		// 5
> 
> How about this one?

Sorry for the delay... yes, this sounds fine.