Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp546313rdb; Tue, 5 Dec 2023 12:26:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHy5NvEAP9u73mMFqu03ZMNyu0JXcsDMJh6RnCBIcCl2uHhNa13wkBPItg5wygoP5jPiS6o X-Received: by 2002:a17:902:db02:b0:1cf:cb80:3fa5 with SMTP id m2-20020a170902db0200b001cfcb803fa5mr2585406plx.23.1701808001775; Tue, 05 Dec 2023 12:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701808001; cv=none; d=google.com; s=arc-20160816; b=AS+cIfQ19Iy853Knx5AKPtESb8wbh0yRCLLFsuLw3AlNJPgEpsltSft9Qba7XbYndJ hf2JgeY4cI5pq7aeJ/IV959XISrWbmjnPQ+BGmho+jgugSAnfu6B3X0i4SUvRpxhltFz i9OXOu2gaipIoWuv8YZnlkl6Dus2TtOR8yjKhD2f/i3zcF65OXXGYbLkhkHjI1wOZyAJ AzVCvMI4YymTlZZ4AhCxfXhXh1E5oNGlvl8QCpriQA5bcIqkdfziNuGW31Ndyy7sY7eG ZERWNsag+pyUKag2YcCYYXYttA1Lqq3xRSfM18/xuwzAbUjKDW8CSX39/sSwlaH+YxlA xA5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4Z74VK0/+6LO3YLMu3vX1pNpETdyfXDf+myVrrbMuLo=; fh=ZLVm0V9i/IxJQgZofZ9t0mBovr4OvuBNeBOD8MBcLo4=; b=j15m/39VWk0lS+7ni/KsxExbDrLSuTbK2b5R+AUIh20ROd8nJSPPb79NcmsPMYs32l gjN+KGBGkUBUFeGaoXFWuXnc5DD1BPXYNjcz2GTQEnqPMnHT97LL2Ibp9KaRYRzzsl05 Y7+LgNjyIe0fN2Ba8rE0n3fFMBH8DVoJFc5Ei4THhFlOrPCyFfvIkyDuNA5U38bepPvm QtuF754QLg3va2l/uG5OMaRqUB9a2/PkMPH+1FWbL9fSXWmIEHwLHeCaGe1MQVIm7E9z XTuIP1DveER5KtBwR1BVmyDYLX/iCqWaM3tAO8ZmVsc7SijBfecEzKAyHWTMYlaAaWEj t2kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JG4DvRLt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id l7-20020a170903244700b001cf69216445si580895pls.392.2023.12.05.12.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 12:26:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JG4DvRLt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D0EAD80309BF; Tue, 5 Dec 2023 12:26:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjLEU0b (ORCPT + 99 others); Tue, 5 Dec 2023 15:26:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjLEU0a (ORCPT ); Tue, 5 Dec 2023 15:26:30 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE34D181 for ; Tue, 5 Dec 2023 12:26:36 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d075392ff6so1326655ad.1 for ; Tue, 05 Dec 2023 12:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701807996; x=1702412796; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4Z74VK0/+6LO3YLMu3vX1pNpETdyfXDf+myVrrbMuLo=; b=JG4DvRLtvWmVfw20cYFSjcl9zNlGRd5KelOqqOfkJcHjsr4Yu1GcbZ4/alONixRIXf 5gbOwbAObvGJwsYT5xBNidZrPOUWZgPGAXagnIxjP69lc208iXywdIz+wucnnAOb2mu5 0BAItnq4Al82m2lexHOwqDZyfi/tzBkA0miRQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701807996; x=1702412796; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Z74VK0/+6LO3YLMu3vX1pNpETdyfXDf+myVrrbMuLo=; b=Pr1KldpturG4KPI8eqGkrFOm9G55KEfAYzOobGNUqU9MDVoIf4sA+k6oZCcq7QO8cN nJ9ED9n1qMzrJVpv7AzR2uUdQQBN/4cCva3QadKYRD8V8vl7xU5vK9RjcFdbX8/VSX6o rLcIP/Uz4iAh6ss7R8vRVi1H0ZtgADCvVE81uXMq6UxlpWqxqTb+fjRaUQF0oQuJmLft pwVV4qYcZ6azglh25yyLc7ZkbyNUC4Ymt0IMqIQIlDMXTRrsFryiOprQNYka05RhuEcv 3zV/fvjy/UJvenBw4b4QH3Ke0dofxD8mXc0ViUJ8euQdFx6+AqpkWFFDUZr/JhmrJ+xM TP8w== X-Gm-Message-State: AOJu0YzGCViQKSV0Q+cAU/aNIxv/WmPA5cTj1TA6k1rvptBFeAF71Tgl LHdb7eKtBifftUcfe5a23DBe2Q== X-Received: by 2002:a17:902:f545:b0:1d0:b3c4:a269 with SMTP id h5-20020a170902f54500b001d0b3c4a269mr2255897plf.13.1701807996133; Tue, 05 Dec 2023 12:26:36 -0800 (PST) Received: from localhost ([2620:15c:9d:2:5038:905b:ae7e:e6da]) by smtp.gmail.com with UTF8SMTPSA id y11-20020a170902700b00b001cc29ffcd96sm4156496plk.192.2023.12.05.12.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 12:26:35 -0800 (PST) Date: Tue, 5 Dec 2023 12:26:32 -0800 From: Brian Norris To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH] wifi: mwifiex: added extra delay for firmware ready. Message-ID: References: <20231128082544.613179-1-yu-hao.lin@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128082544.613179-1-yu-hao.lin@nxp.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 12:26:40 -0800 (PST) On Tue, Nov 28, 2023 at 04:25:44PM +0800, David Lin wrote: > For SDIO IW416, in a corner case FW may return ready before complete full > initialization. > Command timeout may occur at driver load after reboot. Do you have any idea why? Is it specific to this chip and/or firmware? I'm hesitant to add magic sleeps to everything, just because you have one buggy chip/firmware. If it's a known issue with a single chip, it seems like you should add a flag to struct mwifiex_sdio_device / mwifiex_sdio_sd8978. Brian > Workaround by adding 100ms delay at checking FW status. > > Signed-off-by: David Lin