Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp583569rdb; Tue, 5 Dec 2023 13:44:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEx0qOYTtDtDso3skhEbfy7HpstuBSUkAX+hzTf6DPykpz/4b7OeZiPMZFzLzLHiWE19e1E X-Received: by 2002:a05:6a21:38c7:b0:18b:93cc:c9fb with SMTP id yk7-20020a056a2138c700b0018b93ccc9fbmr6041707pzb.54.1701812653536; Tue, 05 Dec 2023 13:44:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701812653; cv=none; d=google.com; s=arc-20160816; b=y74CTs9G3rh8DVeISEySTDIXKM+X1FFsl7yiFF8tvmgEuzvdMo6joPuZqeQpC/gg+4 geZZdk3F9nLSZjXRWTbZVZbqo+0nUDd+me/uByxiyNo+E/q7eTY79Tx11CblLH58ejMG X5OUjAPS93QkyDrRkF1nMliHXkiZ24jdUu+Xdwpe3G4l9C5yMlm4DNzGErrk06ofduEl TCqiO6wqlkBAD2FIQwVFBFviCxi7sDQaxz4j/vXiydjjrT2U+tKpPRur/X8wgJKJB0Mo MYUdkq8MNnDY9hzLqItW9Bbvg5A2wh5CjKUQjmVf2lE05P4dzk0pZUaFg3M7fBZRsg8T ZgBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Ob0/5+i/dplkA8aeloC30i9UVjoXlmEru6XWrA4njrk=; fh=2wNBg9HW42gPL8RmU74Zrr0644/xhzuMmt0my449IPI=; b=ZpeD1s2ZOMvvmySHRbh6PoeX8eouzZ/ABpseqhvhvm5EvbLCYsO34d7wo3TZxxZ2B/ +qETog78rchAlMXW+/S3hET7fyw6tw2fvuXjig4k98ktEv1k7ddwGpaWFRBOTOv3sJlD yidgqrEY222S9+y1jFq6HQhECO6mi6pC/rrNH/LurV0AGr99tiv0cHioyFmXQ3pvk+3m 6fg4IyEeinrMpkVF4KFQlXUxjCUJUD8RNUj3HHXqGk7E4HWIL3XtZB+th5EgaHUlP/ZC V2JlymPm+1IJJQMBChFx5TCUtVV+lpOjqgBI0NWi8ZYgeO6ewDhyUwuTV9Sq4zLZg9UT 8fgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=TJosacg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id u25-20020a056a00099900b006cdd83f45c0si971700pfg.229.2023.12.05.13.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 13:44:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=TJosacg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id BF85E827AC8E; Tue, 5 Dec 2023 13:44:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjLEVn5 (ORCPT + 99 others); Tue, 5 Dec 2023 16:43:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjLEVn4 (ORCPT ); Tue, 5 Dec 2023 16:43:56 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B63EB9; Tue, 5 Dec 2023 13:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ob0/5+i/dplkA8aeloC30i9UVjoXlmEru6XWrA4njrk=; b=TJosacg92BzELf3f/C9b2mNlgW JS58+N92PYhSO0HC8MeVwNSmBt6jQw6sAc15OuEryEYCON3dY35drua95BjcpxFZRhgwrWDM9L0FQ rLtzbAH8sFvZ+xSdERvnJY+pAXgjsXC2XqDzQIlWowfJsCuUjd0p6MdfSJiVaByK6NEep7j+nWzrB QItb8tPCpIv0T6LuGMJMVR9WWwXl/8NnCBVfGTPjvX10koJnCnQP/xzQurWEGA7egS/IpwgeE6SC+ Ei5NZhfd3Rf2bUu9QJpTuER90O742ilR9Vn4GA11kYFRMsdzcxFUcsLFYLAPAN3k4X2vAL1tOrhH9 V/gZQ6zg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAdCx-007TVQ-1R; Tue, 05 Dec 2023 21:43:59 +0000 Date: Tue, 5 Dec 2023 21:43:59 +0000 From: Al Viro To: Nick Desaulniers Cc: Andrew Morton , tanzirh@google.com, Kees Cook , Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , llvm@lists.linux.dev Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU Message-ID: <20231205214359.GF1674809@ZenIV> References: <20231205-libstringheader-v1-1-7f9c573053a7@gmail.com> <20231205130449.8e330a26ecbed1f7b5ad5d7a@linux-foundation.org> <20231205132452.418722bea8f6878dca88142a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 05 Dec 2023 13:44:10 -0800 (PST) On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote: > The tooling Tanzir is working on does wrap IWYU, and does support such > mapping (of 'low level' to 'high level' headers; more so, if it > recommends X you can override to suggest Y instead). > > arch/nios/ also doesn't provide a bug.h, which this patch is > suggesting we include directly. I guess the same goes for > asm/rwonce.h. See include/asm-generic/Kbuild: mandatory-y += bug.h ... mandatory-y += rwonce.h IOW, sh will have asm/bug.h and as/rwonce.h copied from asm-generic. Still, includes of asm/*.h had been a massive headache historically and breeding more of those shouldn't be overdone. More painful problem is arch- and config-dependent stuff, though...