Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 5 Dec 2023 13:48:04 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Huaisheng Ye <huaisheng.ye@intel.com>, <dan.j.williams@intel.com>,
        <ira.weiny@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Huaisheng Ye <huaisheng.ye@intel.com>
Subject: Re: [PATCH] cxl/core/mbox: get next_persistent_bytes by
 next_persistent_cap
Message-ID: <656f9a94d9b48_18297729452@iweiny-mobl.notmuch>
References: <20231201164005.135912-1-huaisheng.ye@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231201164005.135912-1-huaisheng.ye@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zt/XmRIDNk6FfHrmwCa1MAhoWSXDmQ5ejIThYl9vcvVaDjPNSPdIf3ADryin?=
 =?us-ascii?Q?mmNga0QOBKGkJjf3VLQfmnShr4C7QGkSkSWnDJvlspuUanpYkQFIBjsRNIs5?=
 =?us-ascii?Q?YhN4AGdfAOn97G/zyURuRZ8aRro67fvQfvsk9M7GV0VTt6Ozvt+r102YOaYU?=
 =?us-ascii?Q?Clzc2elrsDbr3lWoKztTb8ki2TYnw75X8692Kt55da48PPkkXBfGf68uO8BE?=
 =?us-ascii?Q?qmc/YtiWQFwLLB3ltMi9i31UkDq+vd19SWnu4/WHji+lcztppdp+ACeatIEe?=
 =?us-ascii?Q?adyTobgYKDCknk4aZ+GPDBvUjxcOpdLltYnqcOaGpwXI4OACeJb1HGB1zrSK?=
 =?us-ascii?Q?hRZVnZX+qQrW6dSclmV5xNk9K7B6mz3XkPZjLr5dPStw7TVgweyI2r1gLFcv?=
 =?us-ascii?Q?rCSFsTT9aDus1nxSjpNw5R2l1UvqqZg3OmSMO7ibvkV8IlychRb7PeMlBPcG?=
 =?us-ascii?Q?KHWGQs2YBryU2auaMrIrRYgUQSoyUm3mMguwnM5TQBHSZlwDpcA3XqWVOw95?=
 =?us-ascii?Q?ujq6gldnmq8Y2ruSmDBAnZlP7dK+gjoC8HvD6gxlffgV7CljUzCJoioikthB?=
 =?us-ascii?Q?D2RHjWLzQgrF4zFfsWxVICpPgDrNHoyOGWB1FPaxFbtEhyw5rCqrg6V3kxYD?=
 =?us-ascii?Q?2djzLGKsq5NbpVTR81s69y+rKLHYMNC9U8N8+4xi3rVZNzngbT7+hEhXOpwD?=
 =?us-ascii?Q?QP5wZpEUiOz+yPaXCukKFVx32Le3C7JxCj6scdbNGDK8NpcogSb9Wmqud2Tx?=
 =?us-ascii?Q?ELzyPJSkChAvz4SqomnQFt9l3gh6k24IOkvwALg0X8QDiigGJjk+rydsoDNt?=
 =?us-ascii?Q?qCi2bs+el1E8J/+hpz4iQAuDxbkhe8OihizNY6nfGQiJWvuJ3iofyOc5IQ+y?=
 =?us-ascii?Q?3ZGxLnXyXEkAOy41iyFZz0P5F959nBbap82CpbCb/R84bVoR8QlqltteVE6p?=
 =?us-ascii?Q?Tt4HliuraI4fPzC7LJ+DPMjOA24XDhnQpUKRY/Z96eoIJO7Rx+GAY4v85qMW?=
 =?us-ascii?Q?VUCR9pYhup5Go6JzF/rg5RHyZ16MzFcjjs+TakNypRTAjFLUh1J3zQRTdQSW?=
 =?us-ascii?Q?vMosg6r13QpPpQ5huafp1X8gD0h4W70oxq0FLsZvyIICYmljECPdHEiG7iRP?=
 =?us-ascii?Q?jiG1hYeHN0s/Htg77Ma0JpftsRVtnttxKkTyVCi3GK2hiywkdx34hY/gKs8K?=
 =?us-ascii?Q?Mos9RngVF8CqAbavjKCIn+Nn6x84iMOWmj2X6oaW2ycI+j5ZL7dOX++sNtXM?=
 =?us-ascii?Q?dSKOFnWqZLpyZd8ph4re26lCgRQW7+i0tf9QUWWPd4p3ut5P5ho7MCgwd1m4?=
 =?us-ascii?Q?Ne6vwzogchCNblO5m4wkt6CWkfRDvhN6vHJEdikF4zrBHl7kPAN6onGxb7HM?=
 =?us-ascii?Q?lJkey99n2NIThl4YnBuPfk3a+ra6une14d4qvQr99N7GASoA898qPJQTxjKY?=
 =?us-ascii?Q?fxzvc6uDMsmYDvkwV7TUXNOT7csTWpRjddqG0PrsJDFt7KqoyuD9+QZXIkss?=
 =?us-ascii?Q?DGz5YEzHctiRjBz3RxF3C62DMgkCzFb+pqoEIU43+6Yg7WTxA2Zb4ruMmnXo?=
 =?us-ascii?Q?WMo4Js8EE5VnIvhijFn+xLJsT9wt9+fN56v5oOg5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dff2c351-215e-4bd3-4f7e-08dbf5dbde54
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 21:48:08.1023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /X+l4qbIf34xxHSSmTD4BpUyWYQvNdf6h2npEpqp8dA2EoMmEPQcMroIsIDDCo7B9JT948aq47lKvx2EPycLqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6655
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 13:48:20 -0800 (PST)

Huaisheng Ye wrote:
> According to CXL 2.0 8.2.9.5.2.1 table 176, the next Persistent
> Bytes should be calculated by next Persistent Capacity.
> 
> Signed-off-by: Huaisheng Ye <huaisheng.ye@intel.com>

Do we have a fixes tag for this?  Was there a bug associated with this
find?

Ira

> ---
>  drivers/cxl/core/mbox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 36270dcfb42e..7b8ec73ca37f 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1069,7 +1069,7 @@ static int cxl_mem_get_partition_info(struct cxl_memdev_state *mds)
>  	mds->next_volatile_bytes =
>  		le64_to_cpu(pi.next_volatile_cap) * CXL_CAPACITY_MULTIPLIER;
>  	mds->next_persistent_bytes =
> -		le64_to_cpu(pi.next_volatile_cap) * CXL_CAPACITY_MULTIPLIER;
> +		le64_to_cpu(pi.next_persistent_cap) * CXL_CAPACITY_MULTIPLIER;
>  
>  	return 0;
>  }
> -- 
> 2.39.0
>