Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <a057ee0b-23ce-41b1-a923-80805c860af5@intel.com>
Date:   Wed, 6 Dec 2023 09:22:57 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 04/39] mm/rmap: introduce and use
 hugetlb_try_dup_anon_rmap()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        "Ryan Roberts" <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-5-david@redhat.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-5-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czFMM0czOVc4RFNMdTNpZWZPRjcyVVN2aFY5bVFGK2hXR1lxNjJ3QnlJaldv?=
 =?utf-8?B?VmFCZ2RkcHBoWUhMOHFFSlNOYWJMSHNOTUcySjZPQWg2Y3NIQ3NxN3dBYU9x?=
 =?utf-8?B?aHVrQU9uKzJaaXhhRHZDVml3S2NsTU5LbWQ2enJqWWtPcDRJdE92UXE4aGc5?=
 =?utf-8?B?NFJwS0pwSTdMVTJJR1JSUVN5MGdza2RvZmtkeHpUOS9aaUV5VjlBRWptZ0NN?=
 =?utf-8?B?Y1BZOFJDYmVSZm11eEduVUlnNHc2ZzY4bHFOdEswOG1tcnRBZ3JHdWFaRSt6?=
 =?utf-8?B?YnA2UDRTN0xRREFBblpLVDlGVmRwRzN0VjdZZ1lpZVRBeFg4YUtKbHptVjBh?=
 =?utf-8?B?MEtWRUpMUHM5S09TbFZLNGVhRjY2WUhrMnlPTlZQUFVUdkI1K1VVUkYydkxX?=
 =?utf-8?B?M0pXVzlObUE2YmRYdmd6Wm5ielg4Q21ubWFScDJCNXJ2bkJOclJJSlhmNEha?=
 =?utf-8?B?UzJRMFlPcVpTTkFHc3g1b3J6YlFqaW0ycUNLUDhPL081ZDhkLytSQlo4SDdk?=
 =?utf-8?B?cDFPa0pVTUF6UUNLc3BPVjF2Zk84Vk1RdHdWMFg5ZmlRZTFyTFh4dmhFaHFr?=
 =?utf-8?B?WmtsQ3luL0xHRXhVUDNpWUZVcGM3NWlmeFlsZ25OaStXSHpRaFlqQTdBRVpZ?=
 =?utf-8?B?ZSs2MVRqejY0cXlpSkN5S3FyVU8zWUUwYzlXYWxiN3ByRGJZQ3g4VXRyeHV2?=
 =?utf-8?B?UXZPcnNYMzlYWURLM0VPNW1nTTBaVkk3SHVpMFIvT0JLSFFDeFBCVno0aVlr?=
 =?utf-8?B?UDJwdWdVTXVMVUVaMHBZeCtJbUNlODI0Q3VaejBucUFqcm9ZSkZselRiQUZj?=
 =?utf-8?B?ckRzK3NyK2dFWk13OWF2bFh2ZnZGVGlyazByeURabktUdEhyc0dZWHNENHRX?=
 =?utf-8?B?YUhUdnYxSUtxdHQyK3BHcjVNVmdvc0o1SWMvbUg3Um41RGRjL2JxRWVydGtV?=
 =?utf-8?B?Zzhkak42RTZCR2hCQ1ZJQ2N5aFJ6KzAzdXRubE5HN0haUWV6MDN3ZERucGNF?=
 =?utf-8?B?MGcwNmRLRG85OG5WcXhJbGhsZEU5ekwrTVVLSk54Nlg1VWtmUkp3dGZ1MmFv?=
 =?utf-8?B?UXRWaUt3NlZGZWpXV1p2TEZQd1hGWDk4elVhRXdDclk0MmJ5OXQ5dUpCRnY4?=
 =?utf-8?B?NHU5Nk1BN0dTajcrUTZPVlp3dUFkdWp3Q0VEaFpIL01ZOGR4N2ZCSXZHY3oz?=
 =?utf-8?B?ZjBsWW9hVThuMUxtWS9DR28xcXFxbG82S2xXRU4xNDJoZUZJNytEbGRjeDR6?=
 =?utf-8?B?Vld6ZnE3WUhOQnlhQ2liNHZXdGg1MEtXTUFMbFFCR0xMY0FIMVU2SlVTTTh3?=
 =?utf-8?B?cWpjeVBhdFQ3TlgxWmk4RGZ5eVJFbUdxUGlJeEZjaklJWUl3YXM0bGJnS3Bm?=
 =?utf-8?B?bU5aUGhCOG9IcWVhUTkweFdreXJpclhiQkNwbS9wRnYwOVRIZlJPYi9pWiti?=
 =?utf-8?B?bENCNDlZc2RoSkFUUnNjWDNQSThOVHEyYzdBL1VmUEI4MWk5VWN2d2lPaVJp?=
 =?utf-8?B?M25wMzhoWUVKNDVTN1NNQzR4cENRR3NHQXNmYzlkUUNwU0NuN0tvQ3dyU2ZC?=
 =?utf-8?B?ZnU0eCs2Ti80bUpkdmV2eVhEUkRZVElDdGR5cHR1cDNQcWNhNkI3MWxuRHVC?=
 =?utf-8?B?ZXRkUEVxN1UvempWbWVxa1dyc3NJaVR1MkhoRi9rQ2dtcjBhejdveWpuTThs?=
 =?utf-8?B?RXE5bjEwTUV4ZkQrTmE0RUZEQ1kzNk43NzhQV2VxaUNyQjY1T051VGRXakU4?=
 =?utf-8?B?U0JqelB4ejczaUdKTWJOWDBhU25URERmYlVhMWZVMXZ6UWtkenQxVGZDUzZ4?=
 =?utf-8?B?c1hCaE5tOHluenE4N3l1Zi9mcTQ1QTB1NlU1K0tLRDYzQ2tHYUJvcm9kK1Zl?=
 =?utf-8?B?eXpKOHFPQS9EanF5d0FSaXRaaXMzcmJTY1N3T2k0RTRvLzhIU0lkWHlxZFZi?=
 =?utf-8?B?M3BxZlJqb1JYM3YybVhLL0tVaFh0SUZUMFBvQXBhUzZzMTY4OXNpTmZ4MU8z?=
 =?utf-8?B?ZHZ3VDNtb2Zqbm53bzJYQjNSNGJTcTU3c1M3K0ozTGRtc1RQMkZXcXFvT0NW?=
 =?utf-8?B?QktYTVBrdzZMN2hWdzNTcytqU0VLT2U5SW1SNm1qazY3OFlKY1VkMXNEaU9s?=
 =?utf-8?B?Zlk3WHM3RUZ1UU1TekVkZzZ0c1FVdlJQWE02bE5FeGN2YXlNTjdUYzFpOW9x?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc48532-96d5-4ecc-dba3-08dbf5fa2ed9
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:25:08.2216
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RyFHdv6xVdtzoUEIPakkM/6mPc3yAa+VaPupcSdK840PN4ile2/dsmjPrHx67oaAsLD3Qmnd8IqlrLkxfomSZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6440
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 17:25:45 -0800 (PST)


On 12/4/23 22:21, David Hildenbrand wrote:
> hugetlb rmap handling differs quite a lot from "ordinary" rmap code.
> For example, hugetlb currently only supports entire mappings, and treats
> any mapping as mapped using a single "logical PTE". Let's move it out
> of the way so we can overhaul our "ordinary" rmap.
> implementation/interface.
> 
> So let's introduce and use hugetlb_try_dup_anon_rmap() to make all
> hugetlb handling use dedicated hugetlb_* rmap functions.
> 
> Note that is_device_private_page() does not apply to hugetlb.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>  include/linux/mm.h   | 12 +++++++++---
>  include/linux/rmap.h | 15 +++++++++++++++
>  mm/hugetlb.c         |  3 +--
>  3 files changed, 25 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 418d26608ece7..24c1c7c5a99c0 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1953,15 +1953,21 @@ static inline bool page_maybe_dma_pinned(struct page *page)
>   *
>   * The caller has to hold the PT lock and the vma->vm_mm->->write_protect_seq.
>   */
> -static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma,
> -					  struct page *page)
> +static inline bool folio_needs_cow_for_dma(struct vm_area_struct *vma,
> +					  struct folio *folio)
>  {
>  	VM_BUG_ON(!(raw_read_seqcount(&vma->vm_mm->write_protect_seq) & 1));
>  
>  	if (!test_bit(MMF_HAS_PINNED, &vma->vm_mm->flags))
>  		return false;
>  
> -	return page_maybe_dma_pinned(page);
> +	return folio_maybe_dma_pinned(folio);
> +}
> +
> +static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma,
> +					  struct page *page)
> +{
> +	return folio_needs_cow_for_dma(vma, page_folio(page));
>  }
>  
>  /**
> diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> index 0a81e8420a961..8068c332e2ce5 100644
> --- a/include/linux/rmap.h
> +++ b/include/linux/rmap.h
> @@ -208,6 +208,21 @@ void hugetlb_add_anon_rmap(struct folio *, struct vm_area_struct *,
>  void hugetlb_add_new_anon_rmap(struct folio *, struct vm_area_struct *,
>  		unsigned long address);
>  
> +/* See page_try_dup_anon_rmap() */
> +static inline int hugetlb_try_dup_anon_rmap(struct folio *folio,
> +		struct vm_area_struct *vma)
> +{
> +	VM_WARN_ON_FOLIO(!folio_test_anon(folio), folio);
> +
> +	if (PageAnonExclusive(&folio->page)) {
> +		if (unlikely(folio_needs_cow_for_dma(vma, folio)))
> +			return -EBUSY;
> +		ClearPageAnonExclusive(&folio->page);
> +	}
> +	atomic_inc(&folio->_entire_mapcount);
> +	return 0;
> +}
> +
>  static inline void hugetlb_add_file_rmap(struct folio *folio)
>  {
>  	VM_WARN_ON_FOLIO(folio_test_anon(folio), folio);
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 541a8f38cfdc7..d927f8b2893c0 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5402,8 +5402,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
>  			 */
>  			if (!folio_test_anon(pte_folio)) {
>  				hugetlb_add_file_rmap(pte_folio);
> -			} else if (page_try_dup_anon_rmap(&pte_folio->page,
> -							  true, src_vma)) {
> +			} else if (hugetlb_try_dup_anon_rmap(pte_folio, src_vma)) {
>  				pte_t src_pte_old = entry;
>  				struct folio *new_folio;
>