Date: Mon, 3 Dec 2007 17:47:51 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux@bohmer.net,
       jonathan@jonmasters.org
Subject: Re: [PATCH] isapnp driver semaphore to mutex
Message-ID: <20071203164751.GB16135@elte.hu>
References: <20071203153743.119714913@mvista.com> <20071203155753.GA32546@elte.hu> <1196697144.1568.1.camel@jnielson-xp.ddns.mvista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1196697144.1568.1.camel@jnielson-xp.ddns.mvista.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1084
Lines: 31


* Daniel Walker <dwalker@mvista.com> wrote:

> On Mon, 2007-12-03 at 16:57 +0100, Ingo Molnar wrote:
> > * Daniel Walker <dwalker@mvista.com> wrote:
> > 
> > > Changed the isapnp semaphore to a mutex.
> > 
> > cool - i'll give it a whirl.
> > 
> > small immaterial nit:
> > 
> > > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> > 
> > it's Signed-off-by (note the capitalization). Having this consistent 
> > makes scripting around patches a tiny bit easier.
> 
> Yeah, I know about it but sometimes still slips by..

it's worth automating these repetative bits. I use small templates when 
creating patches. Also, it's worth running patches through 
scripts/checkpatch.pl - it has a check for exactly this typo. [ Not a 
big issue at all, i just mentioned it in case you get a taste for 
sending more sem2mutex patches :-) ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/