Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Wed, 6 Dec 2023 09:00:37 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     <iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alex.williamson@redhat.com>,
        <pbonzini@redhat.com>, <seanjc@google.com>, <joro@8bytes.org>,
        <will@kernel.org>, <robin.murphy@arm.com>, <kevin.tian@intel.com>,
        <baolu.lu@linux.intel.com>, <dwmw2@infradead.org>,
        <yi.l.liu@intel.com>
Subject: Re: [RFC PATCH 11/42] iommu: Add new domain op cache_invalidate_kvm
Message-ID: <ZW/HtdqoSxhjo1tR@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092041.14084-1-yan.y.zhao@intel.com>
 <20231204150945.GF1493156@nvidia.com>
 <ZW7F3AJZe7vrqzcy@yzhao56-desk.sh.intel.com>
 <20231205145227.GD2787277@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231205145227.GD2787277@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bJkRN6toTAf1siclQXpTPQAtvONbXZh06LwmaM2k6986Byju86KJ9SbDC/qD?=
 =?us-ascii?Q?QLoBdPJ5TptStBbzXzLHiCCzHtnBb8lU6MlZj/nIeVkfJjJHt8Qu+yNMVSjQ?=
 =?us-ascii?Q?TKeF0X1BuLfCdiEH2n1huAt3IfGwOHLLP/jY/weBYI/UPPcp6Ca/mTNuAPu1?=
 =?us-ascii?Q?N2RByCOcTa+hFodBFwI5DbFSg8zMDpcPbLYZLjoW6of7mWkNGkqcGssI/Il/?=
 =?us-ascii?Q?rJ5sW6hb9Rv1g0YcN8NMWIkp+dlqsdzSm3PJdAWCXgrXvfy5+2EUnLLh17zo?=
 =?us-ascii?Q?+BqikrK3IaN83/eILEoGwwzj89uqqDHBSpDV98t2nSpRhXsdHIdOBKIxKe9y?=
 =?us-ascii?Q?46gDyk983RuwN/dB3N3LOsO8lX3Icr+oh2zu/t8puejSg+7csOk0gbd+Hnqp?=
 =?us-ascii?Q?VWtFs2R9+hggZjwNK4JrHnjUbBawPqeE7U3nKPuBpplmaNypC51z/gCZfLPx?=
 =?us-ascii?Q?EerxDXkfupjLI2vpYXpH6wNs6Jfgk3W2uWRt3JJVZwWNQRd7ftzpDS+pSXIV?=
 =?us-ascii?Q?PugFpjvh7BNq3+iux7uTcvhgx2P1F6YkptksW4+uJOCUFnXhtIt6eXr+Y4R9?=
 =?us-ascii?Q?nlOblIneuegXzFKJbwbWuv8I5KnC3PLLKqZB4zN2+KILQwkf+2+GGnmYWJpZ?=
 =?us-ascii?Q?wE6BFHXtukRrMHjsajT67yjITAyKQfqjMtBt1l/M7S/LenIeRMFDo+zKxuj9?=
 =?us-ascii?Q?DxWXmWlaY8ib1Z+lqB30iXM6hgdA1900kZj7PH5fdede20RJSTU2xQO8aBf7?=
 =?us-ascii?Q?teeWbmqqro2+8P9WEcwG60rmUAVuXoNwdwQL8Tx9XywjOMINiI9SYfy36KLe?=
 =?us-ascii?Q?rAXXxhGtbDFh4W7VfT/1gCCHSpp9papM/SNi0xBsv/2z5BSJbbZCrHd/z06X?=
 =?us-ascii?Q?5iPYYpclFSbDV/6cHOiBzlf99kz59dJIYGaXsX9hY2GMhNZX/orjUV7qFCyV?=
 =?us-ascii?Q?DKy807un6+jygAGpQyGNG2TmImEntjbUMNDW8v9daoqFw3sa8uuHXsjQhr1R?=
 =?us-ascii?Q?+mqfBmrdNRCuYOfpcivV8q3P8noGL4MNiXMEbNPslUpNGh2hv/HR8lVb0Pmk?=
 =?us-ascii?Q?v0tEe3vgGotGF+Ee4J9JzKGQcmKOoWJFG+QnTsHH2UFAASyKi22ZgT4i002H?=
 =?us-ascii?Q?DwM9MbfDplfxP1jmybvR7Xah8rwnNTBozKGYkFxFFfqf9Rxfj9CMj1TPC7r2?=
 =?us-ascii?Q?Kv+mcNol9KFOYpYv2oQ62WUGn6a/+S8U9UgUypoN9bZFGuvO3y6BAzww4xdF?=
 =?us-ascii?Q?okvKpQl0ZJa1gzJkRLgh0J45SZUTh1FO/rIdnWfx4B4KPZfl5UMpnnLOScJZ?=
 =?us-ascii?Q?rrZudCuZUJB+Er/RV4R0JPQJsuYU8UxzrehYsGnM9fDw4xly4ve240+nd0xt?=
 =?us-ascii?Q?YHqnch0loZjJuUYuEabG6O94fn7mhF96/SCS/U4ogPc1691j9M+kAbQThp3C?=
 =?us-ascii?Q?X/IO/G0K++AIDSTzwNd+zoxNCHay+ewQcL4j2zJQVakfvmsaOUwDfTPuoFB9?=
 =?us-ascii?Q?xB2Q1AXos9GJA30G9TZFDGMwSxgAdW29VG0Eapff2jKnzBw7BRWVNky8ACEo?=
 =?us-ascii?Q?CAO1hy0KwuGLG1iP/xX7nl9IaxZff39NS5cqPVWT2MwXiBLbi2IKIIhUi/Pq?=
 =?us-ascii?Q?HQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 985d1acd-a66a-4871-15ec-08dbf5fad0d3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:29:39.8919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ob1zCannUR//6+mQLD5u5rmjvP+GNommbXVumzhc66wEUaQ5G0DqNQPHH12cobn9XJVhtFFJTJknnstgtvhM5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8220
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 05 Dec 2023 17:29:54 -0800 (PST)

On Tue, Dec 05, 2023 at 10:52:27AM -0400, Jason Gunthorpe wrote:
> On Tue, Dec 05, 2023 at 02:40:28PM +0800, Yan Zhao wrote:
> > On Mon, Dec 04, 2023 at 11:09:45AM -0400, Jason Gunthorpe wrote:
> > > On Sat, Dec 02, 2023 at 05:20:41PM +0800, Yan Zhao wrote:
> > > > On KVM invalidates mappings that are shared to IOMMU stage 2 paging
> > > > structures, IOMMU driver needs to invalidate hardware TLBs accordingly.
> > > > 
> > > > The new op cache_invalidate_kvm is called from IOMMUFD to invalidate
> > > > hardware TLBs upon receiving invalidation notifications from KVM.
> > > 
> > > Why?
> > > 
> > > SVA hooks the invalidation directly to the mm, shouldn't KVM also hook
> > > the invalidation directly from the kvm? Why do we need to call a chain
> > > of function pointers? iommufd isn't adding any value in the chain
> > > here.
> > Do you prefer IOMMU vendor driver to register as importer to KVM directly?
> > Then IOMMUFD just passes "struct kvm_tdp_fd" to IOMMU vendor driver for domain
> > creation.
> 
> Yes, this is what we did for SVA
> 
> Function pointers are slow these days, so it is preferred to go
> directly.

Ok. Will do in this way. thanks!