Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
To:     Kees Cook <keescook@chromium.org>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Steffen Maier <maier@linux.ibm.com>,
        Benjamin Block <bblock@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Azeem Shaikh <azeemshaikh38@gmail.com>,
        linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] scsi: zfcp: Replace strlcpy() with strscpy()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11qc0p04d.fsf@ca-mkp.ca.oracle.com>
References: <20231130204056.it.978-kees@kernel.org>
Date:   Tue, 05 Dec 2023 20:53:48 -0500
In-Reply-To: <20231130204056.it.978-kees@kernel.org> (Kees Cook's message of
        "Thu, 30 Nov 2023 12:41:00 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8b8LPoksWDVJ7ckCiOhBVJk5FPCXZXgf92+qV/TCNowrB+B7oAbRDjzuGQn0?=
 =?us-ascii?Q?MqK6SvYPxe5Um4Up6pDD2RzoflrG3/w8/ZPP/+SWpoRzM6vQHsAbgVld9sys?=
 =?us-ascii?Q?c1DI/4FLFtNrWpwdiQvq/XrkmVVXNQD5L7fnY8aYE4Qg/4zoYtC3GyJFhGc3?=
 =?us-ascii?Q?z+oxL5v2EGB7JuoZkEj4okmay/4xOUh/JFB1wMEtLqaap6PsBHE4K4o6yu9j?=
 =?us-ascii?Q?M3YieuTZEbCbkruMxk3NSmLObDNxlAqHbu9IlatPmMjlz83Ka4Sp6IJDN0Md?=
 =?us-ascii?Q?zuijSDqbQL7it8SYaWyeJB9YNPR2Z6HJM8G2VzRrk/OPwuUWEHEXslvM8NE9?=
 =?us-ascii?Q?EkzAMvTDbY6mbT9WqhQQJ79oOoY8heFhCvZQDdKgTbQyTQ6+7LXm4wSMIMrc?=
 =?us-ascii?Q?zhfDHB0xu9WHtSxcwYYRvSUS4t3FGzGS+a9K4dYRC6u0bGXkDZLEGkof+hkQ?=
 =?us-ascii?Q?lYXYAtChLfpeVYzXMJmN7DSyRTD/7/yae6rnlooKCjlfyvk0wEtIie5zommB?=
 =?us-ascii?Q?w544xOwronqjvfH+Skmd1I0PFYu9hv8c8Eo7f89RW6o8NSx7q2YjUQyxf0xm?=
 =?us-ascii?Q?PSktHepYcafsg2CYvOS8wJ7T1WZaezOBJwh8ypB87xXaFeaTADwvkKhKTX2d?=
 =?us-ascii?Q?am3LSWFr6CP2r1veqz0RBier1F4sEl32wz1eowp2xNicjhnrrGcQlPMYaVI8?=
 =?us-ascii?Q?Chu4BKIVD20whMZjRLUpfwtrBCag8p9dmAdWSG5z0wJNH2oKgK3bp4UPq0Wq?=
 =?us-ascii?Q?WnWyFpT4IG+EYVEsP4pxmmKDEXke0+x8gYsVdGoHOJ4cERjRAv+ITa6u/tKe?=
 =?us-ascii?Q?rjlL/wnEbyt1UJz0rFoUaia6GNzzJY4HYaSCetdLJJzyEJ1puxJDiWhJaVT5?=
 =?us-ascii?Q?kQ/COjBApBpE8aRoHj6AJP7s9Fz6bxR/gae9HlElR6cCWEvMbKPGQD9raipN?=
 =?us-ascii?Q?igBvSaYLvqWFH42KbtkS9Uj0SL05SxTYGdM6djsJiSi9VAE1idDUUE+FnaW2?=
 =?us-ascii?Q?hKZSRNBeV1fiUEX/Tg7CnvyPnVZEtmiTuSzFmf0RwvQVl4urbbXUKIaKvOvG?=
 =?us-ascii?Q?9nhdy6VfkaHHdqhmiLYO+DHV6HQoEqVWCgXHFaVo9XSkJQ3sNWfvux9bm2pj?=
 =?us-ascii?Q?uv33A4BB8kMpWxeX+8774LkZQZ/RDK+0Rwa7cZUCDl1tqiLGt87ZGb5UHWtn?=
 =?us-ascii?Q?1H+cEphaHFu1pP/A/iMFyYAl2Y4ar5SXRhV+3Q3GyoEYxMCePKA5f9V42xJW?=
 =?us-ascii?Q?7E7ekbaxbQWfFJL3r5GCrxrR8qkibbGj2rQ7X0faPY2Lq0GUYXvXQUF2ApMs?=
 =?us-ascii?Q?CHGqrEUd0aWP4FqPp6LUosknHxFUJ0mOWMdfz/mRIEP1d4cYYC0VV6TG9wCF?=
 =?us-ascii?Q?a5ci8rM+WdpttEOtLAM8dRcQjl+gBjGF0FXqh7iN3f1ZeaR8G24yATzTj4hh?=
 =?us-ascii?Q?sS1Aaf3q1h6q0T2QAXuTxSEQHnG2UzbYUDq5nGwRsvL/cvm9glyXWKzz1cEe?=
 =?us-ascii?Q?vlkdfSasJoan91CysOAuR0pucObLntcTuVB1bEcSPKbc97cECUD42ffInMuH?=
 =?us-ascii?Q?7oplahcSbGGsKickGLdUGczQcmThk/wGg0WN3Rzw09M03STxe/3yGiZ8cBem?=
 =?us-ascii?Q?iA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: i0CFhaEYNBztQd1CRTNaCQIeuPI337G7OetcP39wWwMxEEUMILpaF+X5ozAxj5fjx9Jo2XaQpvovJhEyYt0oJly/GCb7nT7gwdzy0BhmQ/gWXDczX6Myw1yLbz3DaM3bcUKT91RTV6frzqLOLoCYec3rrifLLcWfyB7I4WeXnjtAsOttNpslYpFXUmPXu33py9h56XaUhVrC/42CZ4OT4XLb6DEFpqYVUYhUL68jGc2t0/RkU2aNgX5Yw/TGsRNSvyp5yID3XcelBiu3vIcvhUj647VDIAdGyQ1WYa1m+y1omseXqOgMRnpIknyweLvcFF9Yp3WVhCP+E+2hRSAtRaEkGvZTch1BxgP3pmZXp7fVoDUmJfrIEoxsSNgHKSO+8QJt9/Uva+/mhwe6A5eEUKd4j8Iu6gohc8ZWJRQNsccQkWql8Bh8pHzAemcFcA1zZVB81DXPbSWO2Y0vFySSnF02tOdqEV0wdk1Zfttc8vxHm9cluSsni5P1/Z3AsPH2VvkcUoHKP374SPLEYvIlH4xKd7BZyLb0NjtlMWMoSh23uI3LRuj2TrN+XkHMAmrGpELrUesZEXDZZrtHSdSchVpMS3xHRthugGB3at0bpQjFEt4nqA6eHzHKcw7dq9Lo7FqmWrlKqzdCKOvaycfAKCQM++SMClp016dkv1fEScgdAGqzFRkFpnH7kbvV0HIExh99EL51VnB5pPBCiJHkr4P8Z259QDQU3vMLfU067uxIC8ZsmyVtzE8CSRIbgnhJ9jH6WTl8KXTTUWm7sAydWBfcy4gabzdVXPSQ6R76zjonj3zT8IjXJmwOCeOvGRK051I8LtSD703+oh4T7UgIRja/0cJAW9IsD9K2eP5BWUc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34df966b-6130-475a-d718-08dbf5fe3156
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:53:50.2647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B+8/BiShufQ4AjWPhZV4MUGS+8yefqxQgJB0VzGa0enwaxyp1k7MrTOgD1//sTSvS66/eoMKjj0kFXTf3AL6PPLH+Ak3fAhNlPjd0M0oUlo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6096
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-06_01,2023-12-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312060014
X-Proofpoint-ORIG-GUID: auxKadd7K4NR7815_xHwW4hVXKyH4BIu
X-Proofpoint-GUID: auxKadd7K4NR7815_xHwW4hVXKyH4BIu
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 17:54:16 -0800 (PST)


Kees,

> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead to
> linear read overflows if a source string is not NUL-terminated[1].
> Additionally, it returns the size of the source string, not the
> resulting size of the destination string. In an effort to remove
> strlcpy() completely[2], replace strlcpy() here with strscpy().

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering