Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
To:     Kees Cook <keescook@chromium.org>
Cc:     Justin Stitt <justinstitt@google.com>,
        Tyrel Datwyler <tyreld@linux.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvfc: replace deprecated strncpy with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v89cnlg6.fsf@ca-mkp.ca.oracle.com>
References: <20231030-strncpy-drivers-scsi-ibmvscsi-ibmvfc-c-v1-1-5a4909688435@google.com>
        <202311301311.717549FB@keescook>
Date:   Tue, 05 Dec 2023 20:56:10 -0500
In-Reply-To: <202311301311.717549FB@keescook> (Kees Cook's message of "Thu, 30
        Nov 2023 13:12:48 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/PcasLxYPU3ozvW6EyQJJRT680QVErq7qkEWKHamGtz20bC3xKeCQQLYThK6?=
 =?us-ascii?Q?jAt+gCtnqAl+J/eNr7GiZmDgalioeu3bJ5jEvCEBU958ZiqXE1sX9L9BGngh?=
 =?us-ascii?Q?etcSr5mO6RS4vEVDEQajr9MPmXTdC6ysHR/xV6Y5q16IaFhbuT00vfUIarrp?=
 =?us-ascii?Q?n9wWEw09waFdBvvlp/9/P486lkWpK9pBMstjduy3xraVthJQB9c7recnCAIF?=
 =?us-ascii?Q?GtcSOkT1GKm2oCeMWrS3dyDNx8mwU0r3Ou/R1LZ9yLDL7kJcsJipHuRyrdoQ?=
 =?us-ascii?Q?/897tUvtYyGJjfzaw8B/l7f5x8AO+ITM8R6iX7hQyWuGFUGVGQjzPbQta0yv?=
 =?us-ascii?Q?aQiryq5lE6HE2JZFP7n99WvDY2Fi2bs3fA9kM2UpQLp3p4cNJCIhQgIA0aZJ?=
 =?us-ascii?Q?amvwDVLElSRxEPrOPcMP2fSyuWWi7+fW+fNVQLLLpRPKKVoArZH9+rc6/8nk?=
 =?us-ascii?Q?XopiECUOxDsQNqsjHFyhak0mgKJgLe12KipL0kOHofPrrb09FBpxQ9aEXyj9?=
 =?us-ascii?Q?Lnk1KSQGHPYXXqwvZ8n7K23kv9pGfBVkatJVgxBO1bZMzeL8W7yqZJWCVE7c?=
 =?us-ascii?Q?ADxd0ppxfBbaqIz7Jj5BSqLoqFhpWT2/zYTxxRquEOK4JXvg4u4y9K4yBkGI?=
 =?us-ascii?Q?ekaL5qsXdArHj98N8XvQy2uzd5AVE7KQJ/AepoFmL7egvtDl40h9/tNNIrab?=
 =?us-ascii?Q?qlG+wpoQajeckBqd66oPQCIWn6xGytGVmzTjLX/Jt9Q59nU6gkq4WNPhlPC8?=
 =?us-ascii?Q?6ymZ3G2sE07gWwi7WZBoCSyJB6co9vrvyGmP6aeFATK4OcRz3uy5gSC0UaI1?=
 =?us-ascii?Q?veSG+NK/UV1qAA4bBo5NXVEfswSp251+gzLxpTS43TQwpkPYr++/1Nf9A1zu?=
 =?us-ascii?Q?2PfqN8WDaoo+Kwf2ckUQ7iuZ3mAuhatxr/fIhoMEvPXN/3ob+2BiVtN+KuEd?=
 =?us-ascii?Q?HD6Lo7KeZxj/ENqcHpaCk7Uii0rW2eCyDhrKvYpm7eDTsR1fOoDsqFrxSxwu?=
 =?us-ascii?Q?Fwqi6FdeAg/BiVJzipIYS/2z/dLzBtwNmL3e3Em9v0KOpFWdikhM42gTxfdM?=
 =?us-ascii?Q?blDombO+wlIcAfCwIO5CLX2p2KLtWe5xoBOvtM/G5e2IeG0/Mrc/gfK1ABTE?=
 =?us-ascii?Q?r6s+ptPBRptPw2+8xaHkHn6Z1Jjn9swBrUbgtuf1T9JWeR14iTai41EKGbz/?=
 =?us-ascii?Q?Fvn40NtsBg4Xbge0neGsZFbjpHuLDyWX7WJhVENTAonqct2aiLAVJ5+yFllF?=
 =?us-ascii?Q?iq49DGZBc+JSfo2i1+R4xUjAJhHOm28XgPsyM28XPTrLKdcB6Qq5F0c5gDtM?=
 =?us-ascii?Q?JPrHQ4c1J+7OlJ9HlN6fV21VySbryVyRqPPCVUtSxrYGw/1hmUPSlYBUmKu1?=
 =?us-ascii?Q?eEF+ZBVQwb+vqyYVyom5zpYDVG7Y8X8DDwj3eBnwXjzAuLYh8DXc8hKxtxUg?=
 =?us-ascii?Q?re2a/dPlwFQBcnhYc5cMNR5K1p9th753EQ8nNMCJjbpMvYuSRhi7qeklXqox?=
 =?us-ascii?Q?y4j4u+PDlP/KQELB3oTJ31sor2/tdhLA/1C+Sje1W9ywv4v/bBXUDOanp+Y6?=
 =?us-ascii?Q?qvQ2GbOz3WkjcpFPKgFdrbWFW9cRHgOQ5d2BAFsOGRvkJtWqiDUdFr/98rUO?=
 =?us-ascii?Q?UQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?DTQzZOnAz9NBQWQz5LI45ZqKvU/PAXowRGSRammwnJ1qltCEL8ockEGrxFjO?=
 =?us-ascii?Q?/t8KGyF5bcCDCWrw29+XVGKkiUnVrWB0bBMtrBIEq45Bys2vQn3jDYkKT83f?=
 =?us-ascii?Q?YsCYFjdv8yNh8kc9WylDlKCZBgGIqfn/XjMGkPWx10ZllRlouTB75nJLoN2j?=
 =?us-ascii?Q?+1Ky4r7d+w72za5NATj8yLHjzu7nRT+1TaN2QBZbY+D01IsjxU+fqlklvJRs?=
 =?us-ascii?Q?DLE7SCkUF97fLVxYEOwWEf8hKT8NUXKjag6CwgvCvvrM5vJOwMfrbCyLGKEV?=
 =?us-ascii?Q?jO6ctAQ52/CsRzATry79K9dacfSeHS8vD6nQ03DYQVib+Up0ozE7lRaFJiF4?=
 =?us-ascii?Q?eD0+NQ0SAgTbEac0DQqJ93Z9E7xNwlZ0j6aOFiM36y2NNXNPvulJJZPTt3mJ?=
 =?us-ascii?Q?aJiZMXgErQVmCO08yPKx7vfHqAJah8FKVSffZ/pPtbcS2UcT2crOcHZ9AY4G?=
 =?us-ascii?Q?KdR6X05ddprQ7HuYKdK99XPGgGpu3hbZKTOezxVrxMBy94z6gJ1Gp+K4nnAE?=
 =?us-ascii?Q?4u/6RSpo+8sWcbfpgjYwFislNY/s0fYpcZ36vXkHqS/ADN1PaB3dd+H98dw0?=
 =?us-ascii?Q?k0zEzyrtkEYZ9vIN1IXolE6TMXslh6USyz3N5/JOGCMiuHw7ZfHISyTJhGMJ?=
 =?us-ascii?Q?4wiuHWavi8eIpchD9M7m08baafVXjQDNXyNBseNZMQPmXmlrP9Nx0Sr2fITs?=
 =?us-ascii?Q?j7v5tj9e95C+Kx8d7mlGgFdVu2M4yDlM7txnhbnmITDwMpWAnRg+B8qoXqxd?=
 =?us-ascii?Q?Lfw8SmJ5iPKZr3VU9vfoxwVKBNNipRfdHkY2F8tavuPdZoswbN91EAkaJ7+K?=
 =?us-ascii?Q?n48WXRB9hZ3DWCj1cPUykOxgAg2Fz7xmghDA6EdsFHtw45fmjGmFvu896xx4?=
 =?us-ascii?Q?yXVk/QOzHYuSq5jEy7aFhGC+yrSYODUAapilkih3YwmPgGU8CIIDVk754xz7?=
 =?us-ascii?Q?1W9/cm57l2hSKlePmqsU46e+A74dF6SMNW7fpktgp0jfDuYbDPUHI51s+FCY?=
 =?us-ascii?Q?fDni?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc83e938-61ce-4101-18ed-08dbf5fe860b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:56:12.3473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 18M+zS+3qG+/U36c+J+dLGQqdLDZb7Ua8wubyJePjuU6tSU4w15EPLdQQ/p4tVVZ9/FT8kbnMifRr6PLZAYuayTx6ugDFlcKSeptykFB8/I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6096
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-06_01,2023-12-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312060014
X-Proofpoint-GUID: gFsAE0FaRKvkiN4D6WCACp-byxLXHLiq
X-Proofpoint-ORIG-GUID: gFsAE0FaRKvkiN4D6WCACp-byxLXHLiq
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 05 Dec 2023 17:56:42 -0800 (PST)


Kees,

> On Mon, Oct 30, 2023 at 07:04:33PM +0000, Justin Stitt wrote:
>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.

> Yeah, this conversion looks correct to me too.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering