Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     Justin Stitt <justinstitt@google.com>,
        Tyrel Datwyler <tyreld@linux.ibm.com>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvscsi: replace deprecated strncpy with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1plzknld5.fsf@ca-mkp.ca.oracle.com>
References: <20231030-strncpy-drivers-scsi-ibmvscsi-ibmvscsi-c-v1-1-f8b06ae9e3d5@google.com>
        <87jzpy1cqx.fsf@mail.lhotse>
Date:   Tue, 05 Dec 2023 20:58:00 -0500
In-Reply-To: <87jzpy1cqx.fsf@mail.lhotse> (Michael Ellerman's message of "Fri,
        01 Dec 2023 20:41:10 +1100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jY70zGQeypkmQRvFg2iNV62adkJuBblt+Wk4bLvXgj63ucGMwbZnbtl92Gf3?=
 =?us-ascii?Q?troyniCEQu9NfTpjkY4dswdxYEHCOGtmlwk/8DEypTuOl4dJpgnWXDnxuQZ5?=
 =?us-ascii?Q?ZXXTlXuEnNpM5PUQTOQofxDdiehbi4+52pEcwtpuriTnsInX5Cduh0IhP3+A?=
 =?us-ascii?Q?xnOaQCSK4FSgb/5UwnDlCpOmZW8pqSdOLgpmrD34z1eiE7jjDAlNLyGdJUH7?=
 =?us-ascii?Q?ctwXbilhCKsEsYfCl6vtwbUTUlv1KEBv3Fd7R+rc+0oyPaSP4HbQK29wqFdT?=
 =?us-ascii?Q?gfp388D20PuizCWE9kk7d2oV8VlE4e0ziOTWSJSK23AxLav5twbp7UHAvQFu?=
 =?us-ascii?Q?yfSUi9S9GnzzUwvDNW6Z0HCB1ye8GcF/Ftznzxz7eiG+o8kZt3zrSZcAeCrv?=
 =?us-ascii?Q?+HVEFyLgZWgU0C+N4fpVVV+947gii201Mk+yx/Q8JKoo06RdaIDTgVtbgpLF?=
 =?us-ascii?Q?HUuvVfS2E/DnSzNZtjdXpy9YvktmFLdlAnZD8A9XEDNJ3e+ST0vys7BRLD2G?=
 =?us-ascii?Q?HQsuxwvuSnU8CWXlUBKIljm9djX/RwGA9VI/Uw4Jue6eQf/o/CEM9LZUtZO4?=
 =?us-ascii?Q?cB636/PoH8BhJplmd2L/Dn83a9WP8S13WWlOm9psBNZ3ijwRxGzuAvSJ7zX8?=
 =?us-ascii?Q?yXLrcyy1LHBktVdGLZbheWZBoVtUKBGJjI56E20hEcdhKlxlcxGnRmiK20nR?=
 =?us-ascii?Q?/E43oijInvB94cJjNo6h+b/SzDb5/wsb5Z5hEN3TP1u7zu3ByWGVE2T8iKIy?=
 =?us-ascii?Q?oU+v4abjEFyeAGou9vCskk+ZLdfyWMSShBRZ2ibX3mRe/uhK4i8nin/ILwtN?=
 =?us-ascii?Q?v8GnnPOTiOyqpRJWqyWChFlExxXDLE5XhyT3TzzjUbu4i5lITW9pMFvVmGhO?=
 =?us-ascii?Q?Bqr6fxSumSjuL5Hi1zpPAh0xmzrb2mPtDy9c0kH724goGypw2j2mRoU9m2iI?=
 =?us-ascii?Q?/39S//NOdG19EMhJmhnEvco+yJzEqTVDpdyxJcyh21KW+xs3bB16TPORGhGf?=
 =?us-ascii?Q?xgg9XzUQ549/bR9YTRZKV5ML7lM98hHMi0sYp/Pskaz/YFqVDVz5g+PvYjrm?=
 =?us-ascii?Q?lYO5s2uF6PXF9O1zoI3V1262aYsRzMnFCsnGqpsXcJGAZe7hgx26357zey2z?=
 =?us-ascii?Q?JKuj4CJhqizi8FpEnkG0XaRWmMXXW7B4p96MdSkU1HvVY3PC1aq/OQ9K3PT4?=
 =?us-ascii?Q?MIcqjuxuMbf0xZyjE0wLPal0jKAuhPGMTMzPZpRAi536CdlvL/Wdn1ASbCsL?=
 =?us-ascii?Q?1GeJGSjSkbEYmVRC58eRgYlx61Utk6lW0ZkmEezQZHHfzIUFwz0bpVDV0yQ4?=
 =?us-ascii?Q?xKVusss0qK87rJOAfskztaRMUwZeq3OxYNEYp2A/V0UGHPYKy/UPULZhmfi3?=
 =?us-ascii?Q?fsuIr6YtWACngjNlFywV02TVjhitYh1FNTLVdAPDm8RgymzS9IAM8v1gdF07?=
 =?us-ascii?Q?kXmzkDiQf21ZyRRfFxc0owCsBsir8O2M8UY6rs9UMivnFBtr9pDwVKO6N7UV?=
 =?us-ascii?Q?phad7Ue1hV3ZvyOqIZnd0nHm0Gg7EMX3bTpSxYhh9/vLw7esmPn28ye3S5aV?=
 =?us-ascii?Q?+rOWmPIYvDqxRw8bp8Tm+4ZmPZNSN7X0rwKARi7Sxqx/5EnEMTtW3n+LRgqk?=
 =?us-ascii?Q?JA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?n0wKJ1u9lLgdHW0fTDNdAho5F5n4skhPm1hrAxi3TtSUS23U0rqUgE5R4Nml?=
 =?us-ascii?Q?nXJfgXsHYGzezGrnBUGn5iPj7AKHvaafF5PKX6WW8pv726Vy96MCwMYIjtfN?=
 =?us-ascii?Q?AWbNDYAQcaGWbfZ8W3JpKYVx0/xOsA4BRJi90XVHXkvwgV4u51Q7LVjEYSr8?=
 =?us-ascii?Q?ZOsE2WG2DvV/1ezcqGbGmgqXfQuet49+2CgYULUFLVHAhfxglmM59CeZclGU?=
 =?us-ascii?Q?nsnJFrtrAa+zN75Qop/v73fKiLfUUB/+YeBZNyxVzge9rT7k2w6d/04tlYS/?=
 =?us-ascii?Q?5J6+v3sefXoXRronC8aHuKmE+T4R8r1G7fbPuLGz8/3MHP4Pe6XR9Bx+/etI?=
 =?us-ascii?Q?IBa6rM2BKgJ2b9Y9jtsI5EcEThYy6lmvBVrIrlw9wJDxxwvzpAPSaqINUjH1?=
 =?us-ascii?Q?eU0BjfQu9eoK5LsT3lL/wJH4PEJLW1zhaJu7+meazGv4OxMltC59PXhkEcxv?=
 =?us-ascii?Q?Uq9xyn/7N3I4dfT+W6qzthu+fYxOJfvBOQWX+dN1ke6AYjl0wYI9u+E7EyD5?=
 =?us-ascii?Q?Gh4INMveBBhaZZnSloXOTbXpOFsp+Y7W8I2+zJUAW63IAOtMpRcfN4vnQDu+?=
 =?us-ascii?Q?9+cnvn0UEAIvIjdiUrSXWewUqnmH+jYMy7hZgLr0iRMlxf9yfOFzbrlmpBxz?=
 =?us-ascii?Q?nBdFtCatpjdwMWoBYjGdbLFXzLS0ipH9PLX124cCHEw9/pl8kofA3r8rVR69?=
 =?us-ascii?Q?Fc9jDHKUZZrWKmfNmrrjLXdnqjdS9Li+4utIHnHvZSqzP3vQvT1xla9facr6?=
 =?us-ascii?Q?+gzfTZKc5BVOKAIgsWzkArGuNNrkGYzrFvW6QrtYITGtK3YGrfa1CWIp0a1d?=
 =?us-ascii?Q?C0xjELT9BgQ6YCBTtSGpHtBCLgSrn8b5MzxDJNLUxQ8nI+KrSxydKoniCW+W?=
 =?us-ascii?Q?DWanvAIYDdVUrUOxhRRVq+8pYyNGKK59zs6LKWz43kQY2+y6uj67GPFhXvrP?=
 =?us-ascii?Q?tdYNQbzyDu5f+OwHnCa42Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d2a6757-cdb6-4b79-2a16-08dbf5fec74d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:58:01.8391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OGYQ7NOHqp6F5DFBEdUGThknxxLpiRcDVeRR3jJdiE3I5ejOtjJ9N3wwlNmNIUOtw8lJ3mIqIuuEiOM9B9METzYaFOagYncj9I79sK26aAc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB7690
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-06_01,2023-12-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=784
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312060014
X-Proofpoint-GUID: cEukIiCq6OHiIvhwa5PZ2dGuYZ8yr_ts
X-Proofpoint-ORIG-GUID: cEukIiCq6OHiIvhwa5PZ2dGuYZ8yr_ts
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 17:58:27 -0800 (PST)


Michael,

>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.

> I gave it a quick boot, no issues.
>
> Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering