Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <83b9a088-eea9-4148-ab3f-72a96f2d0c34@intel.com>
Date:   Wed, 6 Dec 2023 09:23:14 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 05/39] mm/rmap: introduce and use
 hugetlb_try_share_anon_rmap()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hugh Dickins <hughd@google.com>,
        "Ryan Roberts" <ryan.roberts@arm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>
References: <20231204142146.91437-1-david@redhat.com>
 <20231204142146.91437-6-david@redhat.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20231204142146.91437-6-david@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWc1SmZ3ZGt1djBCQ1h3aDdNK1FwUVVtZjk0SHNuV29oc3dwb1lVM2VhVEZv?=
 =?utf-8?B?WVdPQ1RudCtRYmtxNzVOYytEU1E1MGl5ekx0YzFsbE5zcTRHaUk1RzI1MUpy?=
 =?utf-8?B?b05pNlM2c296c2E0dVkySWgrQXFWQk12L0dBWS9hVktUbUtSdUl1TDBaYmEw?=
 =?utf-8?B?clRoYVVSb0dWaEpYeVlhRUxwd0tjTzU3Q2ErVmtkaGhvSmkrZEdlNVZDVWZR?=
 =?utf-8?B?V1ptQkFya25heVovK2VkdmZQcDZSN25RQlBMMkQzeHdZNVZNRG41eXhmbUxv?=
 =?utf-8?B?enhiLzlNMkM4VUNmcG1DY1dTbEdvU1pmR291azF0T2ZpeTdxdjJNNlZDVlkz?=
 =?utf-8?B?Q0xaNFhsQlZoaUdmYWFWYXJIYUcvWnA4YTdhTU1QMnBUWGh2d29lbWEzSlF1?=
 =?utf-8?B?eWZxOU5jSWJHSXBzMlYxa0xZNVkrb28rTmh2MTlwcTdlRmxCS3crYnBQREhM?=
 =?utf-8?B?T1MvRlo4YUhtZW9iemZLcGpsSEMxVjA0Z0M2ZTVhbjdRd3phSC8wNW1QUmRp?=
 =?utf-8?B?K2hqRklJdEVYajNtZGMrYkNGa0J4NE1NRk9idEJqZzBTSFlEMXVFWElUZmFB?=
 =?utf-8?B?cVhFZjRvdlJQelBPcURXUGN5clBaNmU1bWl0RGJkbnVSc0VwMFdWOC9WT3F3?=
 =?utf-8?B?YTFrUUxoa2pzMG4xMXRaWS9kVVlMWHB5N3ZkOHJOcDY3Y0lwVTBIdVBZZEYw?=
 =?utf-8?B?UWxRSDloT08zN3RNZVZoY3FCWkMxNUNhYUJ2VHRrUTVJNm9xbWp1dDl1ODMw?=
 =?utf-8?B?RHdvL2d0enFvRDFBMnJvQ2lHYkNib2FTNlc4Sm4yelFnWkxxU1VQUHpOOEJw?=
 =?utf-8?B?dGpsMCtzOTVZQmNWaWlZbWQ5STBNSjZaVDVEN3F0dFRvZC9BU0xoR2NoZzBL?=
 =?utf-8?B?RUo0bS9VMTlNTnEwRGVMOXVGbTFjMTEvd2dka0lFZUJiai9iS3RwMndNYUJt?=
 =?utf-8?B?OFFXazV0bDVhQnkxeGMvRGFJNjdqNjBETjJuYXAzUHc5NmpLVkliMDVVL1Nj?=
 =?utf-8?B?cldjVnFNSm1iR0FxRkVkRTBVamwzSm9rQnh0b0hrNXRyb1M5ZmZrOFBGZ2d1?=
 =?utf-8?B?Z3RwbEVMd0Z5NjZURFBRdC90eGF6YkJaVUJQR0pOdGRMdEVCcHlESkZNSTc5?=
 =?utf-8?B?Zng4OU12VFlDVDRPcW14ck1Tc2pMdk9NRVl0OGYwL1p4MXV6R1MzWDZyTjhI?=
 =?utf-8?B?czFHNVIxcnZsYlplaHFiNjFNdjdpNVNMZ1ppSjZrR2JWLytXM3FYOXlwazRj?=
 =?utf-8?B?ZldnQ1k4eWZNUmFwRmhMRG5taFJPVjRyR2o0bkdpZitnaklBM2RaclgxRXZP?=
 =?utf-8?B?VzcrR2xNVDh0dGw0N25VVnBtWTF0enZiMWZHa1JWMEJDeGt0RUVERmQ5WnZE?=
 =?utf-8?B?aC9uL2JDSFFzVTdkOXRwclVKcko3LzREenFjZThsMVdncCtDa2t5NXlMWWhp?=
 =?utf-8?B?TVRzcXZ2bkRLeHNZemxicUNaVzVzNzFNMkl0YVE2QlU5SnFzOExyRlhkQURE?=
 =?utf-8?B?MVRWakVXRjNZT1dzWnBpWVFyTU5TakJrd3NveXkrUVJ6dmV4ZTdUa2tHbTJF?=
 =?utf-8?B?VVBubHl1SVZxUXI5blg0ek9sR21iNXl6RVBONm1EaEV3bXVCWWsxc2IrTWQv?=
 =?utf-8?B?MzNXeWJGMHg4MmRneE9NTVYzUGRkNEs3Q252RDk3Z3R0a3dYdFFQcW5ycTBH?=
 =?utf-8?B?NVlKa2E2M0t3bkYzcURLOTkyVXBFRURjNnFvWUtEZnpwZjhmUWVpWS9HNGxU?=
 =?utf-8?B?VzN3ZG9OSEE1R2FCSXkyVzgrbkJkd3p1MGFxblExdUh5VGg3K3pSRnAxRDFB?=
 =?utf-8?B?aTIvQjFLQTlTZjN4Ry9vM3NQZ0JQN2NHOTBMN1IzVkVuWm1BWTY0RkhTa21O?=
 =?utf-8?B?bHdWNzNxOURhYlViQkxZaWQ4WWNIaW1HUFhLcHI1ejVIeGhhR2t4bTFzRVBp?=
 =?utf-8?B?d1RpN1pZWjd5V0psaDVBZzJCMXh1SldXTkh0TDZuUG5tdHFMSmhObnlrRzZ2?=
 =?utf-8?B?Q1NEVzkvTzJTc3NwcVZTbmhZYnBSWEdPRnpQcWpaUjNnQXZBVVdkKzZFOG1O?=
 =?utf-8?B?VUF6dy9oSWdyZkxZWjE1aFlkc0NJUGRpeDBRb3huenl4Y1dVcmUybEF3cnY1?=
 =?utf-8?B?ekUvRkpFWjhCeVErWU84TGNpeXBrSFhHcXJxb1gveGNHSDc5MjEzclFoVGFv?=
 =?utf-8?B?TEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f85b176-f550-4f48-9ece-08dbf5fa38ed
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 01:25:25.2303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sSgUO3/TIPlFrg0dVvlG3iSJDIDbCqjge6hvowEmGclYNeK+NKPs83OIU+YDGRJpm84hzFhTcRwiuUKCUxNqUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6440
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 18:11:22 -0800 (PST)


On 12/4/23 22:21, David Hildenbrand wrote:
> hugetlb rmap handling differs quite a lot from "ordinary" rmap code.
> For example, hugetlb currently only supports entire mappings, and treats
> any mapping as mapped using a single "logical PTE". Let's move it out
> of the way so we can overhaul our "ordinary" rmap.
> implementation/interface.
> 
> So let's introduce and use hugetlb_try_dup_anon_rmap() to make all
> hugetlb handling use dedicated hugetlb_* rmap functions.
> 
> Note that try_to_unmap_one() does not need care. Easy to spot because
> among all that nasty hugetlb special-casing in that function, we're not
> using set_huge_pte_at() on the anon path -- well, and that code assumes
> that we we would want to swapout.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>  include/linux/rmap.h | 20 ++++++++++++++++++++
>  mm/rmap.c            | 15 ++++++++++-----
>  2 files changed, 30 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> index 8068c332e2ce5..3f38141b53b9d 100644
> --- a/include/linux/rmap.h
> +++ b/include/linux/rmap.h
> @@ -223,6 +223,26 @@ static inline int hugetlb_try_dup_anon_rmap(struct folio *folio,
>  	return 0;
>  }
>  
> +/* See page_try_share_anon_rmap() */
> +static inline int hugetlb_try_share_anon_rmap(struct folio *folio)
> +{
> +	VM_WARN_ON_FOLIO(!folio_test_anon(folio), folio);
> +	VM_WARN_ON_FOLIO(!PageAnonExclusive(&folio->page), folio);
> +
> +	/* See page_try_share_anon_rmap() */
> +	if (IS_ENABLED(CONFIG_HAVE_FAST_GUP))
> +		smp_mb();
> +
> +	if (unlikely(folio_maybe_dma_pinned(folio)))
> +		return -EBUSY;
> +	ClearPageAnonExclusive(&folio->page);
> +
> +	/* See page_try_share_anon_rmap() */
> +	if (IS_ENABLED(CONFIG_HAVE_FAST_GUP))
> +		smp_mb__after_atomic();
> +	return 0;
> +}
> +
>  static inline void hugetlb_add_file_rmap(struct folio *folio)
>  {
>  	VM_WARN_ON_FOLIO(folio_test_anon(folio), folio);
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 5037581b79ec6..2f1af3958e687 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -2105,13 +2105,18 @@ static bool try_to_migrate_one(struct folio *folio, struct vm_area_struct *vma,
>  				       !anon_exclusive, subpage);
>  
>  			/* See page_try_share_anon_rmap(): clear PTE first. */
> -			if (anon_exclusive &&
> -			    page_try_share_anon_rmap(subpage)) {
> -				if (folio_test_hugetlb(folio))
> +			if (folio_test_hugetlb(folio)) {
> +				if (anon_exclusive &&
> +				    hugetlb_try_share_anon_rmap(folio)) {
>  					set_huge_pte_at(mm, address, pvmw.pte,
>  							pteval, hsz);
> -				else
> -					set_pte_at(mm, address, pvmw.pte, pteval);
> +					ret = false;
> +					page_vma_mapped_walk_done(&pvmw);
> +					break;
> +				}
> +			} else if (anon_exclusive &&
> +				   page_try_share_anon_rmap(page)) {
> +				set_pte_at(mm, address, pvmw.pte, pteval);
>  				ret = false;
>  				page_vma_mapped_walk_done(&pvmw);
>  				break;