Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 6 Dec 2023 11:36:10 +0900
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Sourav Panda <souravpanda@google.com>
Cc:     corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org,
        mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org,
        david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com,
        yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com,
        bhelgaas@google.com, ivan@cloudflare.com,
        pasha.tatashin@soleen.com, yosryahmed@google.com,
        hannes@cmpxchg.org, shakeelb@google.com,
        kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com,
        adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com,
        surenb@google.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-mm@kvack.org, willy@infradead.org, weixugc@google.com
Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information
Message-ID: <2023120648-droplet-slit-0e31@gregkh>
References: <20231205223118.3575485-1-souravpanda@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231205223118.3575485-1-souravpanda@google.com>
Precedence: bulk

On Tue, Dec 05, 2023 at 02:31:17PM -0800, Sourav Panda wrote:
> Changelog:
> v6:
> 	- Interface changes
> 	  	- Added per-node nr_page_metadata and
> 		  nr_page_metadata_boot fields that are exported
> 		  in /sys/devices/system/node/nodeN/vmstat

Again, please do not add any new fields to existing sysfs files, that's
not going to work well.  You can add a new sysfs file, that's file, but
do not continue the abuse of the sysfs api in this file.

thanks,

greg k-h