Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 5 Dec 2023 19:23:46 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jijie Shao <shaojijie@huawei.com>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        Hao Chen <chenhao418@huawei.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v2] net: hns3: reduce stack usage in
 hclge_dbg_dump_tm_pri()
Message-ID: <20231205192346.4409ee16@kernel.org>
In-Reply-To: <7df7cfcb-d39b-4643-a378-a18b8d2b5b35@huawei.com>
References: <20231204085735.4112882-1-arnd@kernel.org>
        <7df7cfcb-d39b-4643-a378-a18b8d2b5b35@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 4 Dec 2023 22:50:55 +0800 Jijie Shao wrote:
> >   static int hclge_dbg_dump_tm_pri(struct hclge_dev *hdev, char *buf, int len)
> >   {
> > -	char data_str[ARRAY_SIZE(tm_pri_items)][HCLGE_DBG_DATA_STR_LEN];
> > +	char *data_str;  
> 
> We want to define variables in an inverted triangle based on the code length.
> so, "char *data_str" should move four lines down.
> 
>    	struct hclge_tm_shaper_para c_shaper_para, p_shaper_para;
> 	char *result[ARRAY_SIZE(tm_pri_items)], *sch_mode_str;
> 	char content[HCLGE_DBG_TM_INFO_LEN];
> 	u8 pri_num, sch_mode, weight, i, j;
> 	char *data_str;
> 	int pos, ret;

I took the liberty of fixing this when applying.
Don't want this to fall thru the cracks.

Applied to net-next now, thanks!