Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp719688rdb; Tue, 5 Dec 2023 19:26:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMZcO9JmfJVuUkRLCUxMJMqfj8uII3OUrXCkR9KBxbDfwOfhShy9KWqfk5joGEzGSEYv/l X-Received: by 2002:a05:6a00:c89:b0:6cd:ed99:efe0 with SMTP id a9-20020a056a000c8900b006cded99efe0mr398473pfv.13.1701833173542; Tue, 05 Dec 2023 19:26:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701833173; cv=none; d=google.com; s=arc-20160816; b=Yi1SECMd0F2QLyPe3zOckXZMr80qVGmrpyx1C7Mxj8JlxWCSrYvsqu2Hw5yWboIzjU QxNsjeC6lfjcrTw0ydqQaOrXAtfNaHu7rkRvVcXfJlUalcx9RLnmSWa2z3WF7rMdu71s mDZubJRnyKnPNMWm7DKDVQH1QUwgsl+maYz/bb48SucdBWE2hlMPJtW2EHDNKF3YvXLw lvgNmlF6wVLBuHSdS4OG6NK5Cp+VwZBhaJBwO533m/K4FWVpb+v3CmtUbVH2Ty+6rwAu Kl9beFmzxleGesIZ6uPcYcbe3BZdqWgyjO34SYiETXsUAg/zT7X+H3FZO9ybpvZMnlGS eRvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=faQsfCR32SmynHzxms7TMiEndrZGrhEhdsB18uSNh3s=; fh=pMwGAXyKID2ouUUNxFV+kVo/CxMEsuSkIg/501ZDRwI=; b=K4d2cQqRxB8JI/T0nyJi5mUJ/ohuYP3fNIDJ+qwua6Lv2xOFogljtB9b88cTpuGWyY sVuGFGmYili0oJaEqDBEGzqrxyUoQj2RhDUiLqtFTaowjNYI6lC8JhKs8dXB2mETw+R/ 2c1KmaqvOe/CS8pJBHzFo6UoGXVgoSTeBh6cHVZXWbTwXsD9Ppti1l7yOxKV4Mb5tHuv ZRIQVbKIWShdRetBZeK0OHg45qAlQ/Whc6dDJdSGUBYNqOSbke1GShVLLUaxQD5msQ7t Ej/LTPvC7asqs7s9jMnAjBmzt7Rn84Z4rczEk9hcvntZRXxCUxIAUu1AMz3g34pv9KLb qrYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=Co1DVdD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id b7-20020a056a000cc700b006ce7c7570c6si1117518pfv.288.2023.12.05.19.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 19:26:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=Co1DVdD8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C0ECD80505EF; Tue, 5 Dec 2023 19:26:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjLFDZ5 (ORCPT + 99 others); Tue, 5 Dec 2023 22:25:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjLFDZy (ORCPT ); Tue, 5 Dec 2023 22:25:54 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F3AC6; Tue, 5 Dec 2023 19:26:01 -0800 (PST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B61xYpg017584; Wed, 6 Dec 2023 03:15:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=faQsfCR32SmynHzxms7TMiEndrZGrhEhdsB18uSNh3s=; b=Co1DVdD8Cs29G4m+RqMH4P9ZsEorgYHC0z1Uad7nlkK9ogNovIDwq3X/Kf6rJIrg5gkF lb1fmHUkiKQ5sGLX6mD93J1PB2XIG04MzifsXHuUV0if1vGE36vvr0qzZgi8SyfX8Umw m6mON2snqkkPOx6mQs+CDKQm6z4A0Gnb0Kkt9V+Ze1j15jaFUAmw0ps6W+ArK4OzWn82 TzZtNia1faeY2WyIzslhA9qCQwzH4Lm90XNYXBip1abeHGAVwVfqTbxvladOi5sEcm0R oUvTOSzWVB2VLT7c0iddoc5uaXxfb1QL0w9ihTX0O5cdwgHaWc8b4xorefaUy0a+AHZl OQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3utdmbg6tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Dec 2023 03:15:42 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3B62So2G039465; Wed, 6 Dec 2023 03:15:41 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3utan56ayw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Dec 2023 03:15:41 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B63FeNO029625; Wed, 6 Dec 2023 03:15:41 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3utan56axn-1; Wed, 06 Dec 2023 03:15:40 +0000 From: "Martin K. Petersen" To: Dinghao Liu Cc: "Martin K . Petersen" , Ketan Mukadam , "James E.J. Bottomley" , John Soni Jose , Jayamohan Kallickal , James Bottomley , Mike Christie , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: be2iscsi: fix a memleak in beiscsi_init_wrb_handle Date: Tue, 5 Dec 2023 22:15:33 -0500 Message-ID: <170183237805.1755281.6903745084335290167.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231123081941.24854-1-dinghao.liu@zju.edu.cn> References: <20231123081941.24854-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_01,2023-12-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=556 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312060026 X-Proofpoint-ORIG-GUID: xFgCyMNec_q89i1gb7heEGh5MP2DBYDe X-Proofpoint-GUID: xFgCyMNec_q89i1gb7heEGh5MP2DBYDe X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 19:26:11 -0800 (PST) On Thu, 23 Nov 2023 16:19:41 +0800, Dinghao Liu wrote: > When an error occurs in the for loop of beiscsi_init_wrb_handle(), > we should free phwi_ctxt->be_wrbq before returning an error code > to prevent potential memleak. > > Applied to 6.7/scsi-fixes, thanks! [1/1] scsi: be2iscsi: fix a memleak in beiscsi_init_wrb_handle https://git.kernel.org/mkp/scsi/c/235f2b548d7f -- Martin K. Petersen Oracle Linux Engineering