Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp753753rdb; Tue, 5 Dec 2023 21:17:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGAAjrlNrLlKK0NMOqZHS5cFQN4iYfnxXiNq2DGRhzrSpzhf2MsMmROyu5MBj69U3bZ2AS X-Received: by 2002:a9d:7f98:0:b0:6d9:ca43:be9b with SMTP id t24-20020a9d7f98000000b006d9ca43be9bmr114625otp.25.1701839823124; Tue, 05 Dec 2023 21:17:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701839823; cv=none; d=google.com; s=arc-20160816; b=F6OFYBJvxn5jYnBtF1V0fDdkU2V+sy4gEAHnlqLNinZG5zOjApVjwiPts+u/ollNNi Sicuj4yEtIrWWySiBbkiWn54705cZNE7r5NnDcw9abeDScShK3vi75Cg7GXCniFT56PO DyNE2kW1CsV1e75cdRFZySRpNBVpfe6xR4nKzs8chMGWaih09b815yYy/Ua8RMqFZMlG EQ7h1+T4Ur5QM85BIGWnsjLWmpDp0ywn5H7K114zHCo8TVLmomWLGziL7alGTSOiF+Pp Ca7RKzxVUVu/JWX5+Li4bmGwJ3TSNGqNa3W3WPA73AJr9cSbkC1F0e3PGhv31dUsRFie 4eOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:in-reply-to:references:to:from :subject:cc:message-id:date:content-transfer-encoding:mime-version; bh=RuIxHEDD+RXw/cLq5v9YrXqnL9DXiKkAJT4JDjXHs0o=; fh=uB/DLx8+LgO1sMDRgeJ5GST5LAuiFzs+TJzmuis+9zg=; b=Q/0lNXeqLKLBoWh21PX3VCIM7wb05mhlUDjaWLbgW/sXE2JnAWHYuZOkefJr0ST24T 7n4tPL/8fCXpI7+SQiMaZTNJynb/YDI6JXmoUFw+NDAzjOYqh6cQW1rswgFY9yWo1bKm K7HG7+Yu2KrUQiaJMmdTQPV3MChOZFT9dXpjs99wOFG6sddq3g5BQsr39OrOr1U5ukdU kcuicTDvbYszas2DaMMYzSuS2bbInjso7/qSjShMb21wUATotwEFHSZ4GSZ6WF0rHwgB /8RI3bK0n/8FwcZYx2UNmdgt/nPeZQWG1qk73o8faKFRpWGJLrWtOTqzelyMoo8PMcbR sJkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id 191-20020a6300c8000000b005c65fe43747si6381948pga.279.2023.12.05.21.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 21:17:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 135A480AF820; Tue, 5 Dec 2023 21:16:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376643AbjLFFKm convert rfc822-to-8bit (ORCPT + 99 others); Wed, 6 Dec 2023 00:10:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbjLFFKk (ORCPT ); Wed, 6 Dec 2023 00:10:40 -0500 X-Greylist: delayed 774 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 05 Dec 2023 21:10:45 PST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 978B7188; Tue, 5 Dec 2023 21:10:45 -0800 (PST) Received: from localhost ([80.209.221.177]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MuUvU-1rRa6d307e-00rVDB; Wed, 06 Dec 2023 05:57:37 +0100 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=UTF-8 Date: Wed, 06 Dec 2023 05:57:37 +0100 Message-Id: Cc: "Valentina Manea" , "Shuah Khan" , "Hongren Zheng" , , Subject: Re: [PATCH v3] usbip: Don't submit special requests twice From: "Simon Holesch" To: "Greg Kroah-Hartman" X-Mailer: aerc 0.15.2 References: <20231130231650.22410-1-simon@holesch.de> <2023120641-krypton-presume-a375@gregkh> In-Reply-To: <2023120641-krypton-presume-a375@gregkh> X-Provags-ID: V03:K1:tCHZ4gb+sEMuSuuvLLnYBL4UZRAdD1wYRUP9ZQGMkCK8d2KqZgN l9ZDICCFETLpD/ixLbnSMS8BaraDvXphGU1Dtn3KYm8D8sTNLzlHXpJbUlXTbCO1c8Rxufv n04T80XeBbLB+pKOyeJJdtRX/RWtRwdIhlk9ep+ct9BN8kIwM5z23gI6Z4vefBpF0Vvgs4w hL4OMCdahx6Ktjrz344jw== UI-OutboundReport: notjunk:1;M01:P0:jmQnVkyOyQg=;s138cwMb8b1W3fDoAnPcRP2w4R5 Z6K6fBOnVaJJC7b0YTpLdNKs1C3mvuE3iuRqnZLk/mNrkiVEB/1kpmBB5D62tcawTHMxs7rlQ ryoLySywKmVQYehFvb+6H9rhLLsjJKDmQm4wN/Lf4eEXgF1lfMEoLzh27a6Kd+GrnWOz6GyDf OBuw7J2nueqO8TnHAqOvvlnPO3Y1T8+hlbJNrR/A2RafBCs0pAht+zzKhy+zxRfQKuiQCeA1i XYghmfm8bGRNTgmJMcxnCPjPcqRfa9ZGB0FHWSFeG0TQNcYo1pH2BZyR6GiVxh4e/6RdVSUZZ 3LzG3Erg+xW+aIw9posMhY9vB2YKLrc4lLLZ00Eoc0Q9vGNjx8p59HT2L3DCrwCIRCbidYe19 8jv1KnH04EsBAlbVxGqTcyDrm2d815vYb7k20iwMwSnlizTBzveIo6zr5pv2Pb+9YgDld7nEg e7widnPWLTY3PWXZxkPOVjjNxyKzonEaDFaaq8vRHI7nWZ6adXqTu0MSFIlDBxGqEzgM/78yW ZO4H5MbZfFnZY9qlNAgIGVGjt2Uu9uLYfU9gn+hMpADvsM59bHg9Vrmx6BUVf3klbprOgr5SH G1f2Ux94LqELdHoWL2N2l6NkU+ahi0F/c1xLeONuJrK6DPr2umVREZOORurxPU0tiqHPCZQ0v riJchyFTprc+LvFs+nLb7iAXq8Rbk26jh3uSGVhexTWTP0lbRuEplNKL8pnSUBtvNSd295wSI LIwbjD4CdWqSyOsuqnuWZdnbFpWddxGmfPFxJiyB9oqXvnSZ8wTOZjRC9zz0tGjuzl12gdWcd ktxhjeHhCMy2vNMQSjygsyLSGanLJLxVfyq9R2PYxmVXb/Zo5wqh49gNrXgPPYigCx9F+Gfk2 +Iu6w2sbKrmkKvA== X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 05 Dec 2023 21:16:42 -0800 (PST) On Wed Dec 6, 2023 at 4:38 AM CET, Greg Kroah-Hartman wrote: > On Fri, Dec 01, 2023 at 12:10:13AM +0100, Simon Holesch wrote: > > - if (usb_lock_device_for_reset(sdev->udev, NULL) < 0) { > > + err = usb_lock_device_for_reset(sdev->udev, NULL) > > You didn't actually build this change, so how was it tested? Last thing I did was update the comment of tweak_special_requests(). Must have hit undo once too often, because I've seen (and fixed) this error. Really sorry about that. I'll send a v4 with a detailed test description. Simon > {sigh} > > greg k-h