Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <fdc7e70b-67a6-4e5d-a622-450cf4270690@intel.com>
Date:   Wed, 6 Dec 2023 13:58:00 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/2] misc: mei: Add support for IVSC device
Content-Language: en-US
To:     Wentong Wu <wentong.wu@intel.com>, <gregkh@linuxfoundation.org>,
        <tomas.winkler@intel.com>, <hdegoede@redhat.com>, <krzk@kernel.org>
CC:     <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <alexander.usyskin@intel.com>,
        <zhifeng.wang@intel.com>, <linux-kernel@vger.kernel.org>
References: <1701651344-20723-1-git-send-email-wentong.wu@intel.com>
From:   Hao Yao <hao.yao@intel.com>
In-Reply-To: <1701651344-20723-1-git-send-email-wentong.wu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejZYb3pPK0gzM3ozcUFrVExRSW9CVCtucTlVQmVQbEpHYnM5WjhCa29GdEhT?=
 =?utf-8?B?SmFSa3VKc0lMNjNMQ1JJTlpMWVJ3UFRheTNvVGdEMHR3cGk2eTVCMGxhb2NE?=
 =?utf-8?B?UVhqZVMzdWUxWlhDN1J2L0tmaUlUYjZRcCtqY0xWOVkwZ1dIZmV1c3pXcUNB?=
 =?utf-8?B?c2VTSXg2NXdlWXdFaTlVYWpGdjJWTGJsc2VZQUhYb2x6WFdZVzdlYVRrSE1S?=
 =?utf-8?B?MGUyakFlK0VuSmNNZlNVWnNrVllKU1ovbU5scXFRMm9wQ3lRSzdpN1JrVENT?=
 =?utf-8?B?K0VHN3NwQUVQcTZ2TVFuZkRvUXlvaVhtT1BhOGZFQUlhdGRzTExvR05jM1Zj?=
 =?utf-8?B?MmdTMk1Ra216MGdlVFpHS3plQ3RJT2IzZEp2RG1zMGhFeHUxUHlMcTdDSUtE?=
 =?utf-8?B?b3JwRzBNdjEzVFpBdEkyNzl6V28xT1Zta1Q5UkkzL0ZRVi9BQ1NvYXp6Zmp5?=
 =?utf-8?B?SWk4dEdVQXo1bGdGS3Y1MnRkbWxkSHYyNndJRlM2YjZjeUozUE9OTmxsUmh0?=
 =?utf-8?B?SkR4S2tJYnlBaCt4MDc5K05TMG5jcGpHejlwQ3NPUlF4MzBsSGlWSmRiZUhG?=
 =?utf-8?B?U3M0R1o1SnNZeFNIanJROVVWdDRtQzBYc3U5M0V0RU45a0d6WWg1V0ltWGg5?=
 =?utf-8?B?OHV0SXBMQjBxN1V1NGx1RFU5WHNvRDdTSzFOM1VDSjVVNzNRNXAwQzNDdWtr?=
 =?utf-8?B?VTdXL3lqZUVnTG5oTnJZZ25jclZZRXU0N3UyeFdWZVB4aHBsWHRSNHVMamRh?=
 =?utf-8?B?KzhkSVR6N3JoWHBUWGZaUlg1cVptR1l3M3RjVUxtWC9GMjlyMjlHZG5JSTZq?=
 =?utf-8?B?bWloS2E5Mzdnd1dOZFBxUFhJR04wNU5iZE50L1hSaVRqWWdpSzJFMXRISXNR?=
 =?utf-8?B?b2hTRy9CM2ptU0Q3R0pKRkRGeUZXOU43bTdwVEhhWUxYV0E0aHFSa1hROFBU?=
 =?utf-8?B?bEZZK1ZwSXcwQW1WcWZKQVM5ZG96T21jWjlWSFJ4WElrbytuNzBEODhibWJO?=
 =?utf-8?B?bjhzbHFBU3lidEJZTkpIQVdGYll4eTN5aDY0bDVEQ3hYckwrME1pbEJOMHNt?=
 =?utf-8?B?d0lqOU00NW9TNHAwbzM3SE5pOVR4UzJ6eTAxcWdWM1pUWUdJc0RxRVk1SkJU?=
 =?utf-8?B?dGhXZ0pNYUVjL0JYWWdYcU5abTRKdCtxc0VrckNuQTB1cnIzTUdTNENkMy9v?=
 =?utf-8?B?cHI1amQ4YjVHK2QzY2ZNUjB3eUhOSjVxb01kL054RXdHbzg1Qng3SjNFVFNX?=
 =?utf-8?B?ZnpIbXR6QnNpc25rZGVUOWx5WUltM1JidUZPVHZxTE80QXBiVVVFcG9OUktw?=
 =?utf-8?B?MGNPdnFnK0xoNCtKakVWRVBBZXBSUjRPb1VBdHVTM3dtOG9qSzVWaC9RMnBW?=
 =?utf-8?B?SlNhNi9hSVJVV2hGRmZEUUI3TVFrVmVQSzVaRFN5QU82UXdjMlVoNVFKU09W?=
 =?utf-8?B?cHVpNXlhTnEzVFlrM0pJdkU1SXFzVGp2SlhRZFQ4ZnJnamtlWi9nenJIUElY?=
 =?utf-8?B?S1M0UVlFa2FHeEtDNFBmcVVSWlRzOUd4Q2QxRmRWdW8yRis1WTU1U3A2ZGxV?=
 =?utf-8?B?SWZ0ekJwQWFzMnJxWWo3OUt2TmlpN0JLK21DTlIycVFlQ3lhZUxhQlY4N3Mw?=
 =?utf-8?B?Y1JHSmVaUVpySVAxS09vSUY2OFMvYzNwN1YwSHpkcUJIWXY4OUUrUGpNVUdS?=
 =?utf-8?B?RERnTFlqOEZPMXcvalQ2SjZiRFg4WFJrb0NadzhOMmovK0M4V3VreXRFcG1r?=
 =?utf-8?B?cWtpRUdheGdJNUhPenZWTU4xdm9ScXN3cXNlbnQ0WVVNdzlrTjhFRng4b3Zk?=
 =?utf-8?B?dDdoVzZjLzh3VllWeGR3VjdtWm9JUE5vNDhiODdpRHRFQU1DR0NWUGMxbjND?=
 =?utf-8?B?aXZYMVVIZ2FCUzM3YUNYMFlqcW1LSDhvTlNwT3ArT0Zrei9kK1pQbjJTd0s1?=
 =?utf-8?B?ZGQ3TlZaVkxvWisrZ2ZnQmNKQmV5TnNKRzFCNDJNSWRqVldDVTRyMFMzRXVJ?=
 =?utf-8?B?dlVnSnVITzhHc2o0bzRzT0V2T1FzY0tXWFFPMVdOQ0tjYmZCdFNxMjN3QWp1?=
 =?utf-8?B?aSthdkJsdE01TXpiYmMrWnF1QnVzRHJJZ1krNzI2TllLNm9xa3hSaUxOVnQ4?=
 =?utf-8?Q?qE5robXtEUdOM1xKDxwbVMVNf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8da8b213-e48c-4b79-ebbd-08dbf6205239
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4071.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 05:58:08.5391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MK3oPqC/UsI86ljfbJjVXuF2khc1A0n8oo2qGt/FO+n1FdsBJgof9BuT/M2BPlkl2i3bOrjden+rGIFVG2l9pQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6511
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 21:58:33 -0800 (PST)

Wentong,

On mainline v6.6, I cherry-picked IVSC/LCJA related patches and these v2 
patches, added Intel IPU6 driver on Github, then made some changes on 
IPU6 HAL to auto link IVSC device. I tested the build on a Dell Latitude 
7440 which is using HI556 camera sensor and it previews normally.

If it's properly, you can add my "Tested-by:" tag.

Tested-by: Hao Yao <hao.yao@intel.com>

On 2023/12/4 08:55, Wentong Wu wrote:
> The Intel visual sensing controller (IVSC) device is designed to
> control the camera sharing between host IPU for media usage and
> IVSC for context sensing (face detection).
> 
> IVSC is exposed to host as a SPI device and the protocol used
> for communicating with host is MEI. This driver implements the
> transport protocol and MEI hardware interfaces for IVSC device.
> 
> The firmware downloading for IVSC device is implemented as well.
> 
> ---
> v2:
>    - change to `depends on INTEL_MEI_VSC_HW` for INTEL_MEI_VSC Kconfig
>    - remove MODULE_ALIAS and add MODULE_DEVICE_TABLE in platform-vsc.c
> 
> Wentong Wu (2):
>    mei: Add transport driver for IVSC device
>    mei: Add MEI hardware support for IVSC device
> 
>   drivers/misc/mei/Kconfig         |  24 ++
>   drivers/misc/mei/Makefile        |   7 +
>   drivers/misc/mei/platform-vsc.c  | 450 +++++++++++++++++++++
>   drivers/misc/mei/vsc-fw-loader.c | 822 +++++++++++++++++++++++++++++++++++++++
>   drivers/misc/mei/vsc-tp.c        | 555 ++++++++++++++++++++++++++
>   drivers/misc/mei/vsc-tp.h        |  50 +++
>   6 files changed, 1908 insertions(+)
>   create mode 100644 drivers/misc/mei/platform-vsc.c
>   create mode 100644 drivers/misc/mei/vsc-fw-loader.c
>   create mode 100644 drivers/misc/mei/vsc-tp.c
>   create mode 100644 drivers/misc/mei/vsc-tp.h
>