Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <b7053425-65eb-46a0-abd9-59ade5e78211@bytedance.com>
Date:   Wed, 6 Dec 2023 14:59:18 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Re: [PATCH bpf-next] netkit: Add some ethtool ops to provide
 information to user
To:     Daniel Borkmann <daniel@iogearbox.net>,
        Nikolay Aleksandrov <razor@blackwall.org>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc:     bpf@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, yangzhenze@bytedance.com,
        wangdongdong.6@bytedance.com, tangchen.1@bytedance.com
References: <20231130075844.52932-1-zhoufeng.zf@bytedance.com>
 <51dd35c9-ff5b-5b11-04d1-9a5ae9466780@blackwall.org>
 <16b4d42d-2d62-460e-912f-6e3b86f3004d@bytedance.com>
 <94e335d4-ec90-ba78-b2b4-8419b25bfa88@iogearbox.net>
 <57587b74-f865-4b56-8d65-a5cbc6826079@bytedance.com>
 <2a829a9c-69a6-695d-d3df-59190b161787@iogearbox.net>
From:   Feng Zhou <zhoufeng.zf@bytedance.com>
In-Reply-To: <2a829a9c-69a6-695d-d3df-59190b161787@iogearbox.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2023/12/4 23:22, Daniel Borkmann 写道:
> Thanks, so the netkit_get_link_ksettings is optional. 

Yes, netkit_get_link_ksettings really not necessary, I just added it in 
line with veth.

I don't quite
> follow what you
> mean with regards to your business logic in veth to obtain peer ifindex. 
> What does
> the script do exactly with the peer ifindex (aka /why/ is it needed), 
> could you
> elaborate some more - it's still somewhat too vague? ???? E.g. why it does 
> not suffice
> to look at the device type or other kind of attributes?


The scripting logic of the business colleagues should just be simple 
logging records, using ethtool. Then they saw that netkit has this 
missing, so raised this requirement, so I sent this patch, wanting to 
hear your opinions. If you don't think it's necessary, let the business 
colleagues modify it.

Thanks.