Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp818615rdb; Wed, 6 Dec 2023 00:13:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1ymSWNaJErYWu410Znv1N+Xy18LMsTTBUxc0q9QkY5htzNBJ881uW3iHURvsWTRfBKEJS X-Received: by 2002:a17:90b:4a82:b0:286:9e2f:475c with SMTP id lp2-20020a17090b4a8200b002869e2f475cmr540794pjb.47.1701850389792; Wed, 06 Dec 2023 00:13:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701850389; cv=none; d=google.com; s=arc-20160816; b=Sjoe8z7yGiukkTf760xjbUW7VNM40afXzbZ6DQmQPMAlc30hAL/6tdW5vpIXEY4+OQ XKtZCHWxBxeSOk9DzJfT/qTET6NDXIlEXK/H0FrPOnLJYUeCUVAKXHyFEW/W7NsLV+YW uaPA1iQPId478xBU8JqxuHDQHmzghmS//duFB3zqqE41XTRmPIC63684p9wpxIj7Bknj Zd+4WI7It9Pd1ogQA7UiAxTubNZwbKaDD/qQlAa6upykl19c7HoL2ACpqkxosclfgaJY sa8kqIA72vcJnz08/vp8otkcewkUqU32Or4wQoJyKtv5mfwip2kAvYnZJPy/zRagggcz +gRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0EQpfS7ucerLfy2TMEIonaRwXBXatilAvTAIHrEXghw=; fh=DJbT8ne4Efjik5M2lT8AzCh46QRFyMX3tPkPd3UGLh8=; b=AXbUyCPdOCqlN7atTcCHF99/rZwX/RLGk6rW8L88I4fK/peayrkKsKUI0/u9YYmtg/ cE1YWaVcoMcV0kDepW0FkorE+EOl6WznVoGP1Ja2SsQMFeL61sq4yzbxeKhfjKmtTtx5 gs6Owe1lxGNc/fiDR89aXf9vAuT1/nGuAY3eF6wXiSG2TfwzavVsXPWl4X1mjowUav6T Hf7rjplszZSAaIdkr8330GtCM0lSvi3NTW9A39tBYJoMj/OwE4IyHzPrsxUuiWJhfq+Z I4nxjhVtdHKrJydHzRUJ4de6Nf9oMZCkGxxC63Xacv8wJiJuSwkvwKe60M/ME18k5QvC ODWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id t10-20020a17090ad14a00b00285fd6f078asi13235719pjw.142.2023.12.06.00.13.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 00:13:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7AFA580BD3A5; Wed, 6 Dec 2023 00:13:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbjLFIMp (ORCPT + 99 others); Wed, 6 Dec 2023 03:12:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjLFIMo (ORCPT ); Wed, 6 Dec 2023 03:12:44 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BDA4D3 for ; Wed, 6 Dec 2023 00:12:50 -0800 (PST) Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 069232206B; Wed, 6 Dec 2023 08:12:49 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id E5D57133DD; Wed, 6 Dec 2023 08:12:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id TNGhNgAtcGUPHgAAn2gu4w (envelope-from ); Wed, 06 Dec 2023 08:12:48 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , Daniel Wagner Subject: [PATCH v3 0/4] nvme: add csi, ms and nuse to sysfs Date: Wed, 6 Dec 2023 09:12:40 +0100 Message-ID: <20231206081244.32733-1-dwagner@suse.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 4.21 X-Spamd-Result: default: False [4.21 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:98:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(2.22)[0.738]; BROKEN_CONTENT_TYPE(1.50)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spamd-Bar: ++++ X-Rspamd-Server: rspamd1 Authentication-Results: smtp-out1.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:98 is neither permitted nor denied by domain of dwagner@suse.de) smtp.mailfrom=dwagner@suse.de X-Rspamd-Queue-Id: 069232206B X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 00:13:03 -0800 (PST) I'v dropped the RFC status and tested it lot more which found an obvious bug. When initializating the disk in nvme_alloc_ns, the ns->head pointer was still NULL. This is why I added the 'nvme: initialize head before namespace' patch. I can't really explain why my testing didn't catch this earlier. Anyway, I rebuild my test setup completely to make sure I got the most obvious things tested. The blktests with loop and nvme-tcp pass, nvme-rdma breaks but so does the base line test. So not a regression by this series. Thanks, Daniel libnvme changes: https://github.com/igaw/libnvme/tree/tree-no-cmd changes: v3: - cut overlong lines shorter - fixed disk (queuedata) initialization order - more testing with blktest - added nuse ratelimit - added reviewed tags v2: - moved ns id data to nvme_ns_head - dropped ds, nsze - https://lore.kernel.org/linux-nvme/20231201092735.28592-1-dwagner@suse.de/ v1: - initial version - https://lore.kernel.org/linux-nvme/20231127103208.25748-1-dwagner@suse.de/ Daniel Wagner (4): nvme: lookup ctrl from request instead from namespace nvme: initialize head before namespace nvme: move ns id info to struct nvme_ns_head nvme: add csi, ms and nuse to sysfs drivers/nvme/host/apple.c | 4 +- drivers/nvme/host/core.c | 279 +++++++++++++++++++-------------- drivers/nvme/host/fc.c | 4 +- drivers/nvme/host/ioctl.c | 20 +-- drivers/nvme/host/multipath.c | 31 ++-- drivers/nvme/host/nvme.h | 62 ++++---- drivers/nvme/host/rdma.c | 10 +- drivers/nvme/host/sysfs.c | 31 ++++ drivers/nvme/host/tcp.c | 8 +- drivers/nvme/host/zns.c | 34 ++-- drivers/nvme/target/loop.c | 4 +- drivers/nvme/target/passthru.c | 8 +- 12 files changed, 291 insertions(+), 204 deletions(-) -- 2.43.0