Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp832794rdb; Wed, 6 Dec 2023 00:48:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8aHB9aIWVt2fF+Znd5gomNwxTLNe3mMf4K4eT0XkvRKIdMzihwCmIQvKRjrHlvRLvLKeo X-Received: by 2002:a05:6a20:7fa0:b0:18b:594a:284c with SMTP id d32-20020a056a207fa000b0018b594a284cmr3800425pzj.15.1701852538697; Wed, 06 Dec 2023 00:48:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701852538; cv=none; d=google.com; s=arc-20160816; b=nkRDLKJMAL9WJhJpuYGWdPhL0DmSnCe47AKxltqxTrf+pBMSiaip8A/VoAtzyoUOek 8H15HGV7Cw8fw/4V46SIi/s+C82bYvvqAmsd8Ushay8ToNp1dOZgX++T4mt6hDenKqSN VoUMjhfESJh+pZv5FxyidACLQ55tvNoS4qKeLSnov4XQaV5UyNHk+Of3vpRaS0cNwP2k UNt8qE272CGmlYLeS9mKRuAqtUze2ja8kF0CdvYVS4dKlO5KgQ4FqZG/iULc2K06D8+u Jx1WFND4H9O3p7hb5ELQFc+TlaICcTTc05Zah1NB1sIp81y+wZQKUtNAPz6DFMkeX35s EG1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=pXmU1gNnBj3Tt3nEqdJBVq6k9oNwDcN0iBSlGWAhSmA=; fh=dAlwgM/pc0WB3wrQeNI2ynkzERGK/K0xMg+Ng2ZIMoE=; b=M1ApzBwjIvD93BVBZy8469iI9fPva69VORn7x6ZMlC8S2CdugTDFHKDMZKZthzResx BtPO+Qv8praVHGgw7TNk1nI2Q339ku9jxXDXu8typwAFGjNk66zpS6XTV5sL8YrBnN49 14rDRiLZlyuWTKnPJkE2EA9KHdzys36rQR79hSbZa3SEUNf0I0f1y7XYCEEovD60FGam F5Pi8cA+baQBixoi1pcss920CecB8K1yr7+a0G/i21ms37E5H/i7k94dSCS2aBDoRsWf 37bEO1ZNKnOfT2YkTdHMZ/ADXSJvfoJXJRaMRBSqDvAe5B5aERVkq7d5Q3YEE/CKgxAk V8Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xYejhFky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id bw33-20020a056a0204a100b005b87df75d54si4977393pgb.83.2023.12.06.00.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 00:48:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xYejhFky; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 45AE8802F19F; Wed, 6 Dec 2023 00:48:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376778AbjLFIsr (ORCPT + 99 others); Wed, 6 Dec 2023 03:48:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjLFIsp (ORCPT ); Wed, 6 Dec 2023 03:48:45 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8205B11F for ; Wed, 6 Dec 2023 00:48:50 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c039e9719so47415805e9.1 for ; Wed, 06 Dec 2023 00:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701852529; x=1702457329; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=pXmU1gNnBj3Tt3nEqdJBVq6k9oNwDcN0iBSlGWAhSmA=; b=xYejhFkyNraAOrAPBoHtiZx2rl27FlZYRHeDkctg7il+hyd2CMsuAk4mAcWWc4JX/U G5Qk8vH9CyEqLKVR9SH1wQBgKXdURDSONL3AAMnIfmdSJ+r94PBcNzwuUNwWSVdqB+N7 Wz5Mcry1qpbg55Tk4uQ2flxYhMkrthCvCjzt3igNGYlVJi9DNkV4fIZoj+hy6PanrGw0 6sFG6fEYq/lHnsS1VKRJp7EN3yqSSBsSMHm6hnQwohJxMNBHHm16I1mKdaemQoJNqICl GWeefjZX9md506oWm/QVUvtYCu2LobJs/S6C/A9s5/Szf9b5nxloq6MSLdzMrvLnZqsR FPxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701852529; x=1702457329; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pXmU1gNnBj3Tt3nEqdJBVq6k9oNwDcN0iBSlGWAhSmA=; b=KXp1EWKTOpWLaOeVXQCLDymE2aC7aU1l2/ziavpKHdSnPBaMsNgmpHZstwGwJbWU05 zN3eqlyO7GnVeHI70U17hmm4udvNTZ5j9+zaTGr/T0rFURCtTssefu9IYGKik+LI6bZ+ rrmspl0Zklx1Wt5l1RgdNa/YGZlgusA2y2TyQJ3FWjqx3UuOmUNqZdz7ruPec0l1y6tQ U2Z36nRjVqgNT+aYyr25gETruQqb4ZW+CdLRnk8MngVg7vcxIHeEE56sezmyx2uXqRR+ F+YlD8Awt/GZJc3mwiLVj3KWfRRW/jkI7V++NFrxZOOQoWLwS6R9pi5HxeLD1eJdaNsJ 60ag== X-Gm-Message-State: AOJu0YwUUe9JjoNBmMq+GSWzWkpjrD5durJl/sxNUuscpBmnjexlCojb eyHFmYjeiNR6eXy9o6XdUoZUnw== X-Received: by 2002:a1c:740e:0:b0:40b:5e59:ea0c with SMTP id p14-20020a1c740e000000b0040b5e59ea0cmr354556wmc.171.1701852528918; Wed, 06 Dec 2023 00:48:48 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id bg36-20020a05600c3ca400b003fe1fe56202sm21513479wmb.33.2023.12.06.00.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 00:48:48 -0800 (PST) Message-ID: <288fa09c-a140-4939-bdfb-767f8ff98f14@linaro.org> Date: Wed, 6 Dec 2023 09:48:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local To: Siddh Raman Pant Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Suman Ghosh , netdev , linux-kernel , syzbot+bbe84a4010eeea00982d References: <4143dc4398aa4940a76d3f375ec7984e98891a11.1701627492.git.code@siddh.me> <18c3aff94ef.7cc78f6896702.921153651485959341@siddh.me> <18c3b245f39.5eac9b5898943.4628342226240608054@siddh.me> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <18c3b245f39.5eac9b5898943.4628342226240608054@siddh.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 00:48:57 -0800 (PST) On 05/12/2023 19:01, Siddh Raman Pant wrote: > On Tue, 05 Dec 2023 22:57:28 +0530, Krzysztof Kozlowski wrote: >>>> Mismatched order with get. Unwinding is always in reversed order. Or >>>> maybe other order is here on purpose? Then it needs to be explained. >>> >>> Yes, local_release() will free local, so local->dev cannot be accessed. >>> Will add a comment. >> >> So the problem is just storing the pointer? That's not really the valid >> reason. > > Oops, my bad. What would be the valid reason? (if any) Just store the local->dev pointer and use correct order. Best regards, Krzysztof