Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\))
Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE
 define
From:   Sean Nyekjaer <sean@geanix.com>
In-Reply-To: <DM5PR11MB0076D755B7492A38337A6A7DEF84A@DM5PR11MB0076.namprd11.prod.outlook.com>
Date:   Wed, 6 Dec 2023 10:00:52 +0100
Cc:     Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B0DA4901-0C2F-4D4D-966F-BF89C67219DD@geanix.com>
References: <20231206072442.1628505-1-sean@geanix.com>
 <DM5PR11MB0076D755B7492A38337A6A7DEF84A@DM5PR11MB0076.namprd11.prod.outlook.com>
To:     Arun.Ramadoss@microchip.com
Precedence: bulk

Hi Arun,

> On 6 Dec 2023, at 09.58, <Arun.Ramadoss@microchip.com> =
<Arun.Ramadoss@microchip.com> wrote:
>=20
> Hi Sean,
>=20
>> -----Original Message-----
>> From: Sean Nyekjaer <sean@geanix.com>
>> Sent: Wednesday, December 6, 2023 12:55 PM
>> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
>> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
>> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir =
Oltean
>> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric
>> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
>> Paolo Abeni <pabeni@redhat.com>; Arun Ramadoss - I17769
>> <Arun.Ramadoss@microchip.com>
>> Cc: Sean Nyekjaer <sean@geanix.com>; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
>> _VALUE define
>>=20
>> [Some people who received this message don't often get email from
>> sean@geanix.com. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>=20
>> EXTERNAL EMAIL: Do not click links or open attachments unless you =
know the
>> content is safe
>>=20
>> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
>> DSA_TAG_PROTO_LAN937X to improve readability.
>>=20
>> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add =
dsa_tag_protocol")
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>=20
> Not sure, whether it is a bug fix or not. Since it only improves =
readability.
> I believe it should point to net-next.=20
>=20

Agree :)

Feel free to remove the Fixes tag while applying.

/Sean=