Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp838722rdb; Wed, 6 Dec 2023 01:02:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHquH5Femr05o/BexqT1TyyZbljaFelmbguh6Gja0aB0PQzww2QEFvMJMcTN0L7D3N3i2zq X-Received: by 2002:a05:6808:1389:b0:3b8:bb95:97ef with SMTP id c9-20020a056808138900b003b8bb9597efmr763946oiw.48.1701853353956; Wed, 06 Dec 2023 01:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701853353; cv=none; d=google.com; s=arc-20160816; b=QRWkSDcQON6CHKy19xDq0MFtxVIbmBfws5tOpmHLx9Nw2HzjjVdzc8XHwKVSORt/fl MD1tzml57GS8fohSy8t1WW3xmODlPEtPzVsw9lqLKf6Lh2ot+WqE5sNUkdVKhFsk4epJ sT2YpfwHiLWg74ZG2rDNH9r0xKwb1k23bWHYxRHA5x3hSxi+nYM9nb2eXJ7vzfgB7ia4 WRYfglYNscmzlgEFQWCDQkvWnJHqks2aUxyHgUxFeYqZzR3OcSl25NKUIQaR8Kvode8y xPDV0EzCqt3OkdF94LQ3AutDMAGJZ6UcK+JTZz987tILTyE3ll/955idpBBlDicyZKbo 4VAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ABnlKyy3xcPzTAvTlIEIOdRTL3YhRZabOC0JsEORLd8=; fh=b0X2yU2ZUfPl9DS9VSZAQBUN2lT9fJn2LM0fdfMS6go=; b=PBcl2Cy+tW2P0ddsAgjO0Wb7Jh4a1pUeLCLFxuYcNYIG1i1mi7SihkYdgG7PzY6Yl6 p9lS7WKqBZnp63ZCYWVco9MInAssrPe/Fx3SPzIPqJeqKglrO8oSzRItY0EmdU5XyHic RhsgBW+5qENoraMVfND/xZsrHGTiOzGObAmtW3aLmHWOX9qsH9nqHP8Nr2tVNjmRPAGb WPNZzNxy1qxhupQwtEg/XcQmY2Fq+UsgZxIjZvYPurfl49sIPf2y4YdghcGianYl7nUs aiSfQVO6WjIvfKf0Rmf5hXYpskliEAnjoUoxv0FCS831OPOqYALqy63P08oO2QhiGBTn +HhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="MV5/DkUa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id y19-20020a056a001c9300b006ce61c266e3si3652509pfw.318.2023.12.06.01.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 01:02:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="MV5/DkUa"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5EA2D807F949; Wed, 6 Dec 2023 01:02:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377115AbjLFJB7 (ORCPT + 99 others); Wed, 6 Dec 2023 04:01:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjLFJB5 (ORCPT ); Wed, 6 Dec 2023 04:01:57 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9033A19AE; Wed, 6 Dec 2023 01:02:01 -0800 (PST) Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B68m20f018926; Wed, 6 Dec 2023 09:02:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=ABnlKyy3xcPzTAvTlIEIOdRTL3YhRZabOC0JsEORLd8=; b=MV5/DkUatUooXjyUuW++zLHfO8BOVb4iviffw4yWhRwhXOxkg67a2OO/kFmNTwHS23a8 oRq81BbaFiPTIzJXfubNExzwqjXCNraoLy/2N6pFgEvGj9oNDMGMtW4Y91gHHhdaYleS HgJ6uVL3Vy6Ou77KVBc8LIfWwDM0xpY+y8PKvyium+zjF4gSJVOq10gNOKlIm7lWe6hv L8bUQczFvJGhnjnes7UdLpCpoJBjty9VwphKlIfPbTC0O8BkHdUjWRZh85hp7gO2oTnO sVPHJSE5I4eGEBR96EI6lZ1pjvWoeRqjrYVtHkdUnVr7NAI62mPw1UHR2GQkk4YHrUwf ow== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3utnru0hgy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Dec 2023 09:01:59 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3B68eIqv017788; Wed, 6 Dec 2023 09:01:28 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3utav2b9xn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Dec 2023 09:01:28 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3B691LO413238968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Dec 2023 09:01:21 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BDAE2004B; Wed, 6 Dec 2023 09:01:21 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7506A20040; Wed, 6 Dec 2023 09:01:20 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.9.211]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 6 Dec 2023 09:01:20 +0000 (GMT) Date: Wed, 6 Dec 2023 10:01:18 +0100 From: Alexander Gordeev To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux390-list@tuxmaker.boeblingen.de.ibm.com, kvm390-list@tuxmaker.boeblingen.de.ibm.com, hca@linux.ibm.com, borntraeger@de.ibm.com, frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, svens@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com Subject: Re: [PATCH v1 1/1] s390: mm: convert pgste locking functions to C Message-ID: Mail-Followup-To: Alexander Gordeev , Claudio Imbrenda , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux390-list@tuxmaker.boeblingen.de.ibm.com, kvm390-list@tuxmaker.boeblingen.de.ibm.com, hca@linux.ibm.com, borntraeger@de.ibm.com, frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, svens@linux.ibm.com, gor@linux.ibm.com, gerald.schaefer@linux.ibm.com References: <20231205173252.62305-1-imbrenda@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231205173252.62305-1-imbrenda@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 7xU8E8UIsYPsx-OAM8UiQ0nq83LgGxBi X-Proofpoint-GUID: 7xU8E8UIsYPsx-OAM8UiQ0nq83LgGxBi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_06,2023-12-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 mlxscore=0 adultscore=0 mlxlogscore=346 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312060073 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 06 Dec 2023 01:02:14 -0800 (PST) On Tue, Dec 05, 2023 at 06:32:52PM +0100, Claudio Imbrenda wrote: (Internal lists only) ... > + do { > + value = __atomic64_or_barrier(PGSTE_PCL_BIT, ptr); Would it make sense to cpu_relax() here, e.g with a follow-up patch? > + } while (value & PGSTE_PCL_BIT); > + value |= PGSTE_PCL_BIT; > #endif > - return __pgste(new); > + return __pgste(value); > } Thanks!