Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp839337rdb; Wed, 6 Dec 2023 01:03:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGodfSHlkk56j8cMkYA5LGAML+d+wFLNWJlFZwidZplNrVvF0fAWQhMcwK7obf4DKqbpCyE X-Received: by 2002:a05:6871:8794:b0:1fb:75b:9999 with SMTP id td20-20020a056871879400b001fb075b9999mr577425oab.72.1701853413622; Wed, 06 Dec 2023 01:03:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701853413; cv=none; d=google.com; s=arc-20160816; b=rBQ20LS5uYsyeBsf9uorAO4Cr7wcqJzyXoUYxbdQ1e354fZ7GqLfK9fD3woRMrFShJ qXWj9AUtnEzkg94yj0uIl+RmH6deSehxPkd9/3exF+Vvpf/54z0ZMCRNfwBWg4I9mKwN x84p5hAx1nErLhhEdb/x2gEZAYOmPl44Bls4+kf1XMAPpjy2W9CX5OIxazLr+aR0DYx9 ZUQBMbjs0CQlucpHwtRjZ4ZsZTrbINtMGnvOTppWzifl231Dq1JqpOQUIhj5VKexpjkZ 4hNmynxjQ35pFOJV40vaJgfh+4VQvx4k17HwWMuLoER1NmMBGnIIFOCjDuB7LUAM0fxh Z1ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:in-reply-to:cc:references:message-id:date :subject:mime-version:from:content-transfer-encoding:dkim-signature; bh=bSXEOtYvTrwoUoXd1xh88uMJIjGpO/qF5Wv13PfY9Rs=; fh=0SxEWj049dGtkiHTQsHa7M2NCzrM6pj0ll3VBH0JHU8=; b=zs6Srj604ix+y+Q6SbTefC5oDplO400Cz/Bv6pZM25YIy6WLPGb6LrOCy/SA5TPsNZ 8v5+Z1uZItEF6YsB2acQUSxkJug/szCwunOmFvdJlV0PJJuhM28nIn1IOao9D9bNWc9H eX+1Ja3wOm8rm6rJKozONKW9t+onnZXF51jQHgNjlSlTWqIdIWue+qZ5UlYhlM0K1BP3 PLah5rJsLCwhke83DWgiA2w80dPuJDW2e7MnYPXeNbGDnmemyzmhDVOyqZDWqPpxx/Ck Okr9UxZiMicb5posBjIamFKZEeVnhAalbAje20sbojhZQIiSTXLsM9QM16v+nBOJ1PUU Qm+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=cgP78Lhu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id y14-20020a63ce0e000000b00578c64433c9si11096366pgf.894.2023.12.06.01.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 01:03:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=cgP78Lhu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E0C88804279E; Wed, 6 Dec 2023 01:03:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377200AbjLFJCw (ORCPT + 99 others); Wed, 6 Dec 2023 04:02:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377144AbjLFJCu (ORCPT ); Wed, 6 Dec 2023 04:02:50 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C345DD62; Wed, 6 Dec 2023 01:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Content-Type:From:Mime-Version:Subject:Date: Message-Id; bh=bSXEOtYvTrwoUoXd1xh88uMJIjGpO/qF5Wv13PfY9Rs=; b=c gP78LhuN7x6FQstyZBJFesSlH0rZOkb8F6XwZdNye+SDrAo+BA/+Jt7UMHCgoSE1 gPVi888MJxHGdM2MmK7F7c4+hZMQbebG3ZSXxoHMNH/JkSqGxKvzGY+O/u9IsVkT KaUC9SG6usfmg2b9Tcz+MuNRYa32SOZ9gnV4qgz73o= Received: from smtpclient.apple (unknown [223.104.132.42]) by zwqz-smtp-mta-g4-3 (Coremail) with SMTP id _____wAHD6+kOHBlnYMHDA--.36351S2; Wed, 06 Dec 2023 17:02:30 +0800 (CST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Hao Ge Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] fs/namei: Don't update atime when some errors occur in get_link Date: Wed, 6 Dec 2023 17:02:18 +0800 Message-Id: References: <20231205-endstadium-teich-d8d0bc900e08@brauner> Cc: Hao Ge , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231205-endstadium-teich-d8d0bc900e08@brauner> To: Christian Brauner X-Mailer: iPhone Mail (21A360) X-CM-TRANSID: _____wAHD6+kOHBlnYMHDA--.36351S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFyxWryfGr13Zw43Cr17Wrg_yoW3Xrg_uF sY9a1vkw13JrW5A39rWF4Fyrs0qa93Wr1UJ3s8K3WUZF43X3ZxJr1rGayfArnrX39rKa4r X3Wjvw1qqw13CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0nvtJUUUUU== X-Originating-IP: [223.104.132.42] X-CM-SenderInfo: 5jhkt0qwryqiywtou0bp/xS2Bgho+Flc67gXv7QABs1 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 01:03:17 -0800 (PST) > On Dec 5, 2023, at 19:07, Christian Brauner wrote: >=20 > =EF=BB=BFOn Tue, Dec 05, 2023 at 03:17:33PM +0800, Hao Ge wrote: >> Perhaps we have some errors occur(like security),then we don't update >> atime,because we didn't actually access it >>=20 >> Signed-off-by: Hao Ge >> --- >=20 > We didn't follow the link but we accessed it. I guess it's not completey > clear what's correct here so I'd just leave it as is. Hi brauner Thank your for your reply. I just thought of a situation that user access a link failed due to some err= or(like permission issue),maybe report some error to user, actually user don= =E2=80=99t get anything,but atime still update. Maybe your are right,after all,we still tried to visit. Thanks Best Regards=20 Hao=