Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp849426rdb; Wed, 6 Dec 2023 01:24:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEm0b+eZ/WC0b6nvTV3GztCYojNDLPWrJUS0CwAG4DO40Qu07zVnCNv3xnNlZ2rUh1fuN7 X-Received: by 2002:a05:6830:1db1:b0:6d8:7b4e:7c15 with SMTP id z17-20020a0568301db100b006d87b4e7c15mr756887oti.76.1701854678610; Wed, 06 Dec 2023 01:24:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701854678; cv=none; d=google.com; s=arc-20160816; b=clKXSWMObCbf04hiWpfnxuLoDhGMUzVyKehUFNdI3pr7R9U1qpr9k6cnVtMrZ6PB29 PyeIq5tVugau9NTQc2r6C3zsLcRX17pZScZIyVkoL0e2WOl15UdrMqJpZ0sdp6XtPU1J 59KyzXnxFpyJ77RMJ/SFAnoNzl/zc3modT4dZoznd2ysq6Avorn+5IGXYz970uQH3yPp H2LwSTzCaqXNiXRgO8aZXZkm9+ak7R78TKL7E1V4Pc/CGwk1ygs+6RpSO6t1QJeRLjQp L14F1WAgqHK2WsvC3PQKymfzzRmIaoTGvXbrS5dDRHA7CQDSYl3S6ExWUNGBR18hsKK7 rffQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=4RYf8+tqeX3IUwBxD0UySznuzapx40R7CguL98JU9as=; fh=37dfXQo96BwGxQwTMA+vPXQmTX20hM/nW5KTV2tZiPA=; b=uzxyApavHuvhorrQ0fka3BWjH0k8kbBXDCQV01MKQPYJBC4O1d7uXqDyNTe4aRmhP6 oQMmb58b2ty8G8rtfy4lgV1MPjKfixrmJqzmKQbgieVRaPV30rik914IpVIbZZLumtBc 9XBHXWNUI0r+b+OkBkxnJ2fdLWFQmIFUE+kYRl236b1vqhyQs9JPVgDgrX85HQxll1Z3 LMCfSLvf30CcnV7xlojpRx5JybjlXa8N4ihZJ00UL+8W2+qJa2FjQbwZQV4UbFybBETO nDdkxQuK2jNtLLpBpQ6+XCohDNuJjZo5XgrXkIjJOVB1XyAL7wDJsZWDrA4cR2QfkoiN to0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id g10-20020a656cca000000b005855f67e491si12112132pgw.696.2023.12.06.01.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 01:24:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3951E82DFD27; Wed, 6 Dec 2023 01:24:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346776AbjLFJYU (ORCPT + 99 others); Wed, 6 Dec 2023 04:24:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346728AbjLFJYS (ORCPT ); Wed, 6 Dec 2023 04:24:18 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89DF8D40 for ; Wed, 6 Dec 2023 01:24:25 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B04CF227AA8; Wed, 6 Dec 2023 10:24:20 +0100 (CET) Date: Wed, 6 Dec 2023 10:24:20 +0100 From: Christoph Hellwig To: Werner Sembach Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Georg Gottleuber , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-pci: Add sleep quirk for Kingston drives Message-ID: <20231206092420.GA27348@lst.de> References: <20230920085210.22573-1-wse@tuxedocomputers.com> <12d32e8e-e20b-4023-8299-39d2a69c0cd9@tuxedocomputers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12d32e8e-e20b-4023-8299-39d2a69c0cd9@tuxedocomputers.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 06 Dec 2023 01:24:35 -0800 (PST) What does save a lot of power mean, and why does it only apply to some platforms? I suspect the more likely case is that APST is simply completely broken on this device?