Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Anna-Maria Behnsen <anna-maria@linutronix.de>
To:     Sebastian Siewior <bigeasy@linutronix.de>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Eric Dumazet <edumazet@google.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Arjan van de Ven <arjan@infradead.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        Lukasz Luba <lukasz.luba@arm.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH v9 17/32] timers: Introduce add_timer() variants which
 modify timer flags
In-Reply-To: <20231205182835.DNCNokiI@linutronix.de>
References: <20231201092654.34614-1-anna-maria@linutronix.de>
 <20231201092654.34614-18-anna-maria@linutronix.de>
 <20231205182835.DNCNokiI@linutronix.de>
Date:   Wed, 06 Dec 2023 10:24:45 +0100
Message-ID: <87r0jzel9e.fsf@somnus>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Sebastian Siewior <bigeasy@linutronix.de> writes:

> On 2023-12-01 10:26:39 [+0100], Anna-Maria Behnsen wrote:
>> Timer might be used as pinned timer (using add_timer_on()) and later on as
>> non pinned timers using add_timer(). When the NOHZ timer pull at expiry
>> model is in place, TIMER_PINNED flag is required to be used whenever a
>> timer needs to expire on a dedicated CPU. Flag must no be set, if
>> expiration on a dedicated CPU is not required.
>
> Slightly reworded.
>
> | A timer might be used as a pinned timer (using add_timer_on()) and later
> | on as non-pinned timer using add_timer(). When the "NOHZ timer pull at
> | expiry model" is in place, the TIMER_PINNED flag is required to be used
> | whenever a timer needs to expire on a dedicated CPU. Otherwise the flag
> | must not be set if expiration on a dedicated CPU is not required.
>
>> add_timer_on()'s behavior will be changed during the preparation patches
>> for the NOHZ timer pull at expiry model to unconditionally set TIMER_PINNED
>> flag. To be able to reset/set the flag when queueing a timer, two variants
>> of add_timer() are introduced.
>
> and here.
>
> | add_timer_on()'s behavior will be changed during the preparation patches
> | for the "NOHZ timer pull at expiry model" to unconditionally set
> | TIMER_PINNED flag. To be able to clear/ set the flag when queueing a
> | timer, two variants of add_timer() are introduced.
>
> I let you be judge of this.

I will take your reworded version.

Thanks,
	Anna-Maria