Subject: Re: [PATCH] isapnp driver semaphore to mutex
From: Daniel Walker <dwalker@mvista.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux@bohmer.net, jonathan@jonmasters.org
In-Reply-To: <20071203201159.365d49d8@hammerfall>
References: <20071203153743.119714913@mvista.com>
	 <20071203155753.GA32546@elte.hu>
	 <1196697144.1568.1.camel@jnielson-xp.ddns.mvista.com>
	 <20071203164751.GB16135@elte.hu>
	 <1196706902.1568.11.camel@jnielson-xp.ddns.mvista.com>
	 <20071203201159.365d49d8@hammerfall>
Content-Type: text/plain
Date: Mon, 03 Dec 2007 11:20:33 -0800
Message-Id: <1196709633.1568.12.camel@jnielson-xp.ddns.mvista.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1025
Lines: 27

On Mon, 2007-12-03 at 20:11 +0100, Michal Schmidt wrote:
> Dne Mon, 03 Dec 2007 10:35:01 -0800
> Daniel Walker <dwalker@mvista.com> napsal(a):
> 
> > Speaking of automating.. I created a little .vimrc add-on which helps
> > doing sem2mutex type changes. Here's the chunk I added,
> > 
> >     function Semtomutex( lo )
> >         exe '%s/down(&'.a:lo.')/mutex_lock\(\&'.a:lo.'\)/g'
> >         exe '%s/down_trylock(&'.a:lo.')/mutex_trylock\(\&'.a:lo.'\)/g'
> 
> From the comment above mutex_trylock():
>  * NOTE: this function follows the spin_trylock() convention, so
>  * it is negated to the down_trylock() return values! Be careful
>  * about this when converting semaphore users to mutexes.
> 
> Michal

Thanks, I didn't notice this .. I've only run into one tho..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/