Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 6 Dec 2023 12:54:44 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc:     hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field
 to vb2_queue
Message-ID: <a2011bd9-8d1d-486d-8a54-794193dc99ec@suswa.mountain>
References: <20231206085608.33246-1-benjamin.gaignard@collabora.com>
 <20231206085608.33246-2-benjamin.gaignard@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206085608.33246-2-benjamin.gaignard@collabora.com>
Precedence: bulk

On Wed, Dec 06, 2023 at 09:56:07AM +0100, Benjamin Gaignard wrote:
> Rename min_buffers_needed into min_queued_buffers and update
> the documentation about it.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

[ snip ]

> diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c
> index fa672cc8bc67..2c91f75e8d79 100644
> --- a/drivers/media/pci/zoran/zoran_driver.c
> +++ b/drivers/media/pci/zoran/zoran_driver.c
> @@ -749,9 +749,6 @@ static int zr_vb2_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsi
>  
>  	zr->buf_in_reserve = 0;
>  
> -	if (*nbuffers < vq->min_buffers_needed)
> -		*nbuffers = vq->min_buffers_needed;
> -
>  	if (*nplanes) {
>  		if (sizes[0] < size)
>  			return -EINVAL;

This was not mentioned in the commit message.  And anyway, please do
that as a separate commit.

regards,
dan carpenter