Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
Message-ID: <fd877ca8-6deb-9bc1-877d-57817a8913ac@nvidia.com>
Date:   Wed, 6 Dec 2023 15:43:40 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Patch v7] ACPI: processor: reduce CPUFREQ thermal reduction pctg
 for Tegra241
Content-Language: en-US
To:     <rafael@kernel.org>
CC:     <rui.zhang@intel.com>, <lenb@kernel.org>, <lpieralisi@kernel.org>,
        "Sudeep Holla" <sudeep.holla@arm.com>,
        <linux-acpi@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <treding@nvidia.com>,
        <jonathanh@nvidia.com>, <bbasu@nvidia.com>, <sanjayc@nvidia.com>,
        <ksitaraman@nvidia.com>, <srikars@nvidia.com>,
        <jbrasen@nvidia.com>, "Hanjun Guo" <guohanjun@huawei.com>,
        Sumit Gupta <sumitg@nvidia.com>
References: <20231123121433.12089-1-sumitg@nvidia.com>
 <ZV9bGtUsjF1v1oIW@bogus> <6ccd1598-3c8b-1290-9494-01a3cdbb3003@huawei.com>
From:   Sumit Gupta <sumitg@nvidia.com>
In-Reply-To: <6ccd1598-3c8b-1290-9494-01a3cdbb3003@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 10:13:57.5598
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e3591aba-e20e-4385-7fd7-08dbf6440f39
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC4.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4223
X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 02:14:43 -0800 (PST)


>>> From: Srikar Srimath Tirumala <srikars@nvidia.com>
>>>
>>> Current implementation of processor_thermal performs software throttling
>>> in fixed steps of "20%" which can be too coarse for some platforms.
>>> We observed some performance gain after reducing the throttle 
>>> percentage.
>>> Change the CPUFREQ thermal reduction percentage and maximum thermal 
>>> steps
>>> to be configurable. Also, update the default values of both for Nvidia
>>> Tegra241 (Grace) SoC. The thermal reduction percentage is reduced to 
>>> "5%"
>>> and accordingly the maximum number of thermal steps are increased as 
>>> they
>>> are derived from the reduction percentage.
>>>
>>> Signed-off-by: Srikar Srimath Tirumala <srikars@nvidia.com>
>>> Co-developed-by: Sumit Gupta <sumitg@nvidia.com>
>>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>>> ---
>>>
>>> Sending this patch separately as the other patch in the series is
>>> applied by Rafael in v6[1]. Revision history before this version is
>>> in the cover letter of v6[1].
>>>
>>> Please review and provide ACK if looks fine.
>>>
>>
>> For arm64 specific changes(a minor nit below though),
>>
>> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>>
>>
>> [...]
>>
>>> diff --git a/drivers/acpi/arm64/thermal_cpufreq.c 
>>> b/drivers/acpi/arm64/thermal_cpufreq.c
>>> new file mode 100644
>>> index 000000000000..d524f2cd6044
>>> --- /dev/null
>>> +++ b/drivers/acpi/arm64/thermal_cpufreq.c
>>> @@ -0,0 +1,20 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +#include <linux/acpi.h>
>>> +
>>> +#include "../internal.h"
>>> +
>>> +#define SMCCC_SOC_ID_T241      0x036b0241
>>> +
>>
>> [nit] We really need to find better place to define this globally and not
>> locally at each usage site like this. We already have it in GICv3 driver.
>> But that can come as a cleanup later if it causes issue for merging this
>> change.
> 
> Agreed.
> 
> Looks good to me as well.
> 
> Acked-by: Hanjun Guo <guohanjun@huawei.com>
> 

Hi Rafael,

If the change seems fine, could you please apply this patch?

Thanks,
Sumit