Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp932752rdb; Wed, 6 Dec 2023 04:21:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzkwLwvm/QnJL5jM6/swxV2We0Rft68SBFvYahYuW5bObUXoXgL9rfgJsGb99XKT1sGZn5 X-Received: by 2002:a05:6a20:7286:b0:18f:e485:c868 with SMTP id o6-20020a056a20728600b0018fe485c868mr328779pzk.35.1701865268039; Wed, 06 Dec 2023 04:21:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701865268; cv=none; d=google.com; s=arc-20160816; b=o5YhaUK3u7QScZD5hBxa703Hl/le3HGcpKFZfJAB/tOpK3RokVg3LvRC3cBQsI+duN /EGFUHwpeFDKWI4jGaYQCdgDsUPmffHOXjL/4sM+PMbi3/uyw6DwzdBpDqvoxRD22sWw wQzXaJy2+TTvYh+xnHKOTTyA7h5mgcJ99Af2Q3Yhuw/YniGPdZgIgx7qdBkSKn2JuNtL sX3MIXBc+VzJRJrF5m2ptFa3EDxHsntK2HLmvtNzt8SqNJSxVQTyG3zLvft780rPAHit he9v1QbfjiJBVzXO56ovAec2+32tKwuSHyeAU0u72tNGzVWeQXFvXhr/olO2b0PFZeuM 8wag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:autocrypt:from:references:cc:to:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; fh=4rWRxpC+kgjvaym2cpd+ZAR9Cs0SAd5708OGjvClHGo=; b=LFFzsJbXsUT2v9dYPBetBvfYsYEk45LJ0eDgG3GvC3eU5LPseclbGeyzeywwP4PNlY Ex0/Mif2ZWjT+6G/Oy5rTBkSvFunSrxH+31Cv61el0XWp5d7KmIpuyt6qQVtSpXTVp2q 5GJGBOtqaL2CSMUlrHjFZv5vk77+tOcEQ1AU/zGunsWKekom7Aa9vC9XFhXr6nH0T2vf bg25I2h34GJIe+rBOKUT4KFfykLJnaR5kBSeKiIKZSvxGazue29ktEm+MhbgXpzJDTr+ +rF1OdXtakNLAzZ+zFEfUVRwi/Sptl79/tOHGaKPCwrRt42lX4/KMboZCIOTyHAP+Tyr QE4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VeThNjMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id i5-20020a17090332c500b001d1d73caf96si421767plr.258.2023.12.06.04.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 04:21:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VeThNjMF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 25ECF827AC97; Wed, 6 Dec 2023 04:21:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377925AbjLFMUr (ORCPT + 99 others); Wed, 6 Dec 2023 07:20:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378290AbjLFMLA (ORCPT ); Wed, 6 Dec 2023 07:11:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CD3BA for ; Wed, 6 Dec 2023 04:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701864665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; b=VeThNjMFX/J8+p2fuXu3oFUc9oJIyopI99XRoIamaCihnL5JKP8MHcfqyHl6HoGDQ44AKf 9SQ+ivlWCIbxOcQhBUbAgWjblpaEbJjrKin1jEcKVPijKHs3OD9tH5YwpQ6etrIjB3OTsq vX4pYcK5XhL78vbf7vFQvBUmKK0EUfs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-suBHWtSjM72kYUQJAwruhw-1; Wed, 06 Dec 2023 07:11:04 -0500 X-MC-Unique: suBHWtSjM72kYUQJAwruhw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-332e71b8841so653114f8f.0 for ; Wed, 06 Dec 2023 04:11:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701864663; x=1702469463; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V2xrfJjLvNaX6xs06Zc+BsclCS3wWmWAaewcZJwi4wc=; b=o9rPdA/w357e3jvnbSn8bKUT9DC4QQri/N4m61P8JvrdG5Go0dokUlaI+jCmAr4ZT6 pWwqhbbMKC5B5wHb5xMsdiGmlugwrwnp3rREm9d4udN/6+KsFT1UTPHBDzAt8wEp6Ppc GSemAe3dpiQI6R+ADRvU48uC/Kf5FNVAB/ubR1zQhv8W48sqB9FG/TaK2CQg5xKMgvOa DUk8yI9S4Ck3pJn9szUPLJWUG3/c36OKxNxHEwyZ4E8qwX5/WAODP0RykSYRpHAbntMz hR6DstR41NWz/pHRm5HBr71i8luMWSjEccjdoCiy5IPH5gz8u38QIqWe6sAJv3znM8/B gv6Q== X-Gm-Message-State: AOJu0YxkGHeVRGUtfa/SZi4MTlUoTMMZM4v6WUb9u1t9tyYx3K/jaUPb AhvZKIA4qWooQhlRgFbXqxErRb6QPl3j7iAcsG8SKXQUR4jbfuUexMnktzMqZgcmMkA4Nm/+R3d S21tj2+gVp3+CC4rFdZlMOX0h X-Received: by 2002:adf:ec0c:0:b0:333:2fd2:5d30 with SMTP id x12-20020adfec0c000000b003332fd25d30mr517885wrn.98.1701864662915; Wed, 06 Dec 2023 04:11:02 -0800 (PST) X-Received: by 2002:adf:ec0c:0:b0:333:2fd2:5d30 with SMTP id x12-20020adfec0c000000b003332fd25d30mr517878wrn.98.1701864662545; Wed, 06 Dec 2023 04:11:02 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id x16-20020adfec10000000b003333beb564asm11180742wrn.5.2023.12.06.04.11.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 04:11:01 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 13:11:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 02/39] mm/rmap: introduce and use hugetlb_remove_rmap() Content-Language: en-US To: Yin Fengwei , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Mike Kravetz , Muchun Song , Peter Xu References: <20231204142146.91437-1-david@redhat.com> <20231204142146.91437-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 06 Dec 2023 04:21:05 -0800 (PST) On 06.12.23 02:22, Yin Fengwei wrote: > > > On 12/4/23 22:21, David Hildenbrand wrote: >> hugetlb rmap handling differs quite a lot from "ordinary" rmap code. >> For example, hugetlb currently only supports entire mappings, and treats >> any mapping as mapped using a single "logical PTE". Let's move it out >> of the way so we can overhaul our "ordinary" rmap. >> implementation/interface. >> >> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb >> code from page_remove_rmap(). This effectively removes one check on the >> small-folio path as well. >> >> Note: all possible candidates that need care are page_remove_rmap() that >> pass compound=true. >> >> Signed-off-by: David Hildenbrand > > I suspect you wanted to place your RB tag here? :) -- Cheers, David / dhildenb