Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp936660rdb; Wed, 6 Dec 2023 04:28:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHI58Xdeyt/vOSgBL17H/QwPTVsMWXSaLjDInFYlt+wHMqtagDQXcKvMujiavEZH/kNjCU/ X-Received: by 2002:a05:6e02:6cc:b0:35d:6bc5:e72f with SMTP id p12-20020a056e0206cc00b0035d6bc5e72fmr952779ils.47.1701865732534; Wed, 06 Dec 2023 04:28:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701865732; cv=none; d=google.com; s=arc-20160816; b=BdiWHCs9ZODCSIADNAWWtmhc0pMqmN+7tl7qjfhrLvAEi7zrhbkrPHRa2BqNHZBPl2 /RTykQw6XSEpgbD0samSjgy6S/rMIfvObxfArdj1vmPi6FaaVSuZxJQRDkqMlfswTlt7 JpREFkYDjVq93Xoya7eBhQI7F3xEgOn1d/1dTPoq1He1Gbw34aeRgC74xA9uCKw2eBvj FPI5jSAsGB+pxL6S5DOcmf9RT1UKmqeZq9chQgr6jxFk5mS+aq3Yke/EuqpL4RRR+ndj hQfWMj8r4QcLd1PL+lCs/QQJznJ+dYO/83wL8NpWtSOXgnRZ83a+RUJTMkWmcyBzd4CB 2qow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=bGOyXBc8VpYXUIzqop1SwzGsMBqr5Cx6QC/TSPQu1wg=; fh=xomkctMLhzv1QIlquAIPojPz4fVoRZ1Nn+p8FldNHhM=; b=hQ++B0WKb4m52YbmGN5E0pOzMJXJZwOrjR5tg2V4F0TYEt6Yu4qDspdhGq+JMITOs7 Eb9L6IgR40DkwrcAM0Qa7VGuyJHO7dYHIyXNPxqcKeWYRpXg1xbOsEkL+eov759WGjX/ J8H26Y2f9e7j5ukAcANI9f6fymwoygWnzCVJ+lhgOgtMieR1a4K1ykv/9rTV6QoJ7cI6 EN70JQTlxi78uFEaOnwhT7VOp+0IpE8XHIFVZ/Pj5fHPpXgZmCgO7mnBDs4XHk6hPQhU /atBC7z7XefvFn2PEn0AKRjKGQYYBwkTYiCWBPEG2AFn0pAP0MSBzCugQHqHKJ2AyUW7 RKUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NQ4mEUVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id s190-20020a632cc7000000b005a9fde46fa0si11301623pgs.130.2023.12.06.04.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 04:28:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NQ4mEUVH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id AE24680CC111; Wed, 6 Dec 2023 04:28:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378058AbjLFM2f (ORCPT + 99 others); Wed, 6 Dec 2023 07:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377925AbjLFM2e (ORCPT ); Wed, 6 Dec 2023 07:28:34 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E4398 for ; Wed, 6 Dec 2023 04:28:40 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a1db6816177so70891266b.0 for ; Wed, 06 Dec 2023 04:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701865719; x=1702470519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bGOyXBc8VpYXUIzqop1SwzGsMBqr5Cx6QC/TSPQu1wg=; b=NQ4mEUVHOg0m0nHeWw9lS+377zGiZRay6YJ91WsONO5FknLQD4Sda86lXfuLhrmT9D ENwEfcami6RJo/G0G24C0GzYmVa4U6iC6NpCnYfQiQG+XC81fY5yQiSqx1AmYdNW959T 2W2n0i7UOijaHUYOt/5WlGPjVuI5XVCWFkHHQV1VRWLQ7+XyWLQuNJVE7o5s4WTIo35b PRziR+J5EGxsAC1zg+gum1Y69IIH4zwpCWqDJgLkAhBmhslYm9xkbCeV0n9R2M+5pmmr z2CP/nfaJRv7uRVOR4MwIM8/MnWLdciK6/xyD9qbA0SwCPZnKvGzlRRWwVLp1b1m7jWA aJgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701865719; x=1702470519; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bGOyXBc8VpYXUIzqop1SwzGsMBqr5Cx6QC/TSPQu1wg=; b=CqxfawcppJQltb4myrjO48b2UXU9XtprESjaylciV8NPcgx2VReR4L3ETUbjwAvj2q u/EdLrzVOMVqctYyHJVfwB4JI8ioMKHSptFrCxWIDi3NG1jWLOy6ivhKhFoGABRi/XFp 93MuGh5ztK7L7zdTvCm+aNXpFgpFD8WXEmyggZ43+qAhfET78duWu8tyv38alkF4tC/d 6OV7eRqc6mxoKIAz4N7aAWVHqAb3xXB+qrFz9CQRTvIuu71CbQxPmyQUBG5PNei2ohDo FwppbwjMmO/YF13qLIF+zshRTtjHgzxkB5xu1EULeMCiP0Pf7oUP6AyTsi9XVnFOykxQ cbaA== X-Gm-Message-State: AOJu0YyZcil3aOgNcgfi0WRhPoZ3zXFVKc9kdSdj3lEfXcJjj08Ex1pK nQ8YTjmsfvpDg7kyf/TsRsgFnQ== X-Received: by 2002:a17:906:7497:b0:a08:1224:abd6 with SMTP id e23-20020a170906749700b00a081224abd6mr529383ejl.3.1701865718694; Wed, 06 Dec 2023 04:28:38 -0800 (PST) Received: from ?IPV6:2001:1c06:2302:5600:366d:ca8f:f3af:381? (2001-1c06-2302-5600-366d-ca8f-f3af-0381.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:366d:ca8f:f3af:381]) by smtp.gmail.com with ESMTPSA id ef10-20020a17090697ca00b00a1b6ec7a88asm4358000ejb.113.2023.12.06.04.28.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 04:28:38 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 13:28:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/8] media: qcom: camss: Add support for named power-domains Content-Language: en-US To: Hans Verkuil , laurent.pinchart@ideasonboard.com, Robert Foss , Todor Tomov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mauro Carvalho Chehab , matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231123-b4-camss-named-power-domains-v6-0-3ec2fd9e8e36@linaro.org> <20231123-b4-camss-named-power-domains-v6-5-3ec2fd9e8e36@linaro.org> <43621420-2482-4634-9c3e-1a3278481540@xs4all.nl> From: Bryan O'Donoghue In-Reply-To: <43621420-2482-4634-9c3e-1a3278481540@xs4all.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 06 Dec 2023 04:28:49 -0800 (PST) On 06/12/2023 12:35, Hans Verkuil wrote: >> + if (IS_ERR_OR_NULL(camss->genpd)) { >> ret = PTR_ERR(camss->genpd); > I get this smatch warning here: > > drivers/media/platform/qcom/camss/camss.c:1555 camss_configure_pd() warn: passing zero to 'PTR_ERR' > > I'm not really sure what the intent is here. > > If the fix is small, then I can change it myself, otherwise I need an updated patch. > > Regards, > > Hans Update sent