Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp942330rdb; Wed, 6 Dec 2023 04:39:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAiCO3HYiOGnUpf3gba4VSLMtw+sohhfbHwypdCT7liKZxdOg0uF6GHMU47iE77pHbPFOu X-Received: by 2002:a05:6870:71c1:b0:1fb:75a:de7e with SMTP id p1-20020a05687071c100b001fb075ade7emr872216oag.108.1701866343810; Wed, 06 Dec 2023 04:39:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701866343; cv=none; d=google.com; s=arc-20160816; b=HNr23WEHza+bCM2KMz1VwDeEGnVNVru3MGdLztsPkBVWiSXmmgACBm97D/rrKHcVuM cRCx5JYrWQBYLauX/PqQcnzQXNc10523J9vZZCguzDZ4xTGqCasCz/yN2Z+jUt9qSqv6 YM+sbAByL1v3Xn7391mbQoD5g9/HblVGPoy6gIbpg8faOYnqgXc3tFLRG7bdemw6/3JE bFXn8mKe2Wm0MAIxUXrrigSll3uqeL4TTKQ8doZM3tznWulbJ5pF54jnl8CWaKZJNHTG h04uwqp8q2TGRRCUWoP2PdjV9voMeknADXm0bMUFaHqa/yk08B39QemmkSuyPadgndL8 CY/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=TZQQ6BqHEI6hRsDFbv1/FW96mENZWMKFWNl0n0AGdhw=; fh=GxA6Oi016Eylm1odaFFUGtxSgNDu2JfeJ4/Vh/BOLbo=; b=FYJYFukJtcZZtczTCFJtbmKt9PQN7LncHRDFtYVsY3D++pZl/Iuc43wkubaTYbPXHW 8gKKxIw4mfIZfyJWh1GcWT652Cg9oMncAOTdd+vafdokiVvpjHKzOqKmOoZTu6sdNnwZ eH0/lwcZ858DpLQUZeuYyKzpzieI3syOLVWEn3NK6RkhSgaf/s6EFEB1Cs7qfMs/IOhC b2NA70WDuOUaPVfF7wSch5ZEtUi/eBRlQo6nWqypApRVCflbcT28KLo4T31UNZishff8 uzWRDr14rWACXGAGRnWR6BmoG0aE7mroHqs4E7hSQcRSigtNRAY3HGtdYtXxJxzkNeTp LZbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jVISvmAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id q7-20020a634307000000b0056952b496efsi11478017pga.366.2023.12.06.04.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 04:39:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jVISvmAW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 493FD80C3A2C; Wed, 6 Dec 2023 04:39:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378382AbjLFMib (ORCPT + 99 others); Wed, 6 Dec 2023 07:38:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378326AbjLFMia (ORCPT ); Wed, 6 Dec 2023 07:38:30 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37B412F for ; Wed, 6 Dec 2023 04:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701866316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TZQQ6BqHEI6hRsDFbv1/FW96mENZWMKFWNl0n0AGdhw=; b=jVISvmAWQCxftrAgR0WXMbr1r6rJPZTLPh+0On0WaSzV0TF+5AC94pV5915Rdo2BQzapDM cwKFcu1T5PfsT3CrbxqwW4cSxbPygJm+jUpFozoldVhTfjO06nz5gJlBir/BEgNtOezbB9 vdN1SacXazgaHvpQo4j7FFmz7y/D3Gk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-thj-CJ5vMACQz1wZWLOP9w-1; Wed, 06 Dec 2023 07:38:31 -0500 X-MC-Unique: thj-CJ5vMACQz1wZWLOP9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F74F29AB3F3; Wed, 6 Dec 2023 12:38:31 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id C252E3C2E; Wed, 6 Dec 2023 12:38:29 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <447324.1701860432@warthog.procyon.org.uk> References: <447324.1701860432@warthog.procyon.org.uk> To: fstests@vger.kernel.org, samba-technical@lists.samba.org, linux-cifs@vger.kernel.org Cc: dhowells@redhat.com, Steve French , Paulo Alcantara , Dave Chinner , Filipe Manana , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Issues with FIEMAP, xfstests, Samba, ksmbd and CIFS MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <449657.1701866309.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 06 Dec 2023 12:38:29 +0000 Message-ID: <449658.1701866309@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 04:39:01 -0800 (PST) David Howells wrote: > So: > = > - Should Samba and ksmbd be using FALLOC_FL_ZERO_RANGE rather than > PUNCH_HOLE? > = > - Should Samba and ksmbd be using FIEMAP rather than SEEK_DATA/HOLE? - Should Samba and ksmbd report 'unwritten' extents as being allocated? > - Should xfstests be less exacting in its FIEMAP analysis - or should t= his be > skipped for cifs? I don't want to skip generic/009 as it checks some > corner cases that need testing, but it may not be possible to make th= e > exact extent matching work.