Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp983744rdb; Wed, 6 Dec 2023 05:47:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLnij9t1ypAt9k7yhXGnWF1AjNPrzW9OMHQB2JRzgmYXfm0yEzI6YnfagGDfYbMqrsKOtr X-Received: by 2002:a17:90b:1987:b0:286:c55a:d9e0 with SMTP id mv7-20020a17090b198700b00286c55ad9e0mr725809pjb.32.1701870453420; Wed, 06 Dec 2023 05:47:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701870453; cv=none; d=google.com; s=arc-20160816; b=PR9jeakZ33BbLYchAS8eqMF1lczsYTDoQHUo/f7xnfdxAOPoVzzvLboH3ZfObbWSF8 lXK2LJ8hWGx4RLeW/hhy3wZuHGRaP8OgJIE9FELM32ZWTF334+1Exugkxd3EMDQJnE9m P/utYCM7EHTMAAlNQRnKkaLD5upeijybzxWrT/UzpFIwoALIAHEy/grFifAeM28V1XW4 lnu3v/ZP4G/9ywCIufECb1vbIJ8I5GvvlQWfFFxvcEhe+f3rCXcI/urF0J3zTFOX+n0x TnrHmnLE8Qu21QmpRRFtEkt9qwmGtMytrb7g8YureMNLHhzKmc3bxJNcZaniKmir5E91 mmYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZACtLZ0OUAag1h+i7PrAm6kPbMYspljF/6azzS4ri4s=; fh=fQy2U1EHEenx5Fa9IRwgW870ZHNU/PX8gDkVUH1Zfy8=; b=cvKnxFfV6FYiPacMFDcJbKI7b8Z+KasscuCcJEb8v/T9V4+Tk3Zhf8XIPN0aIrduCq uSC/sBlnQ2yxQVuNBzCIeHOQFgQhCyjwTGKLpLgWPtJ4Wgw4+2uFYKYkqOeFpsXaHRBe 2KgOKvpVFzS/E4jJzWE9iMcD8KzsYWrTt02Ep+Lc8K0jr5+apQ3XKYBeLk4YUfnSwE8Q sIe+fi4XkOWw8xI9n8x4VbrNZ1i6bSWXXIkBiDVB1zuuDEmzfkgh2Ih4/uCwuAeyotW5 tdBi+FwW1g+stiguobOs8t2RqiMKMH5zRrSYj6OBFZq0Mo5hhN4exryQcxZcTuFS29er vNSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jd4z+QBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r5-20020a1709028bc500b001d07b6a0aefsi7110790plo.214.2023.12.06.05.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 05:47:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jd4z+QBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7F3238029DD8; Wed, 6 Dec 2023 05:47:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378555AbjLFNrU (ORCPT + 99 others); Wed, 6 Dec 2023 08:47:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378530AbjLFNrS (ORCPT ); Wed, 6 Dec 2023 08:47:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15FFD4F for ; Wed, 6 Dec 2023 05:47:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48689C433C7; Wed, 6 Dec 2023 13:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701870444; bh=pN7ek/mF4Oc2DQGrSxYppSDy2KSxkWe9q08aNujDOf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jd4z+QBc8VWOIMuZ7yOWg1WhiF/HO0ejs5m34x9xAZGHeqT9sds1JobDii52CWUNF K/Uv1RajgOejBlAW/B/n4/jO8ubSb5yP4v8tvLWGiXWX/4FCw40OtqtWKOmEbs8m5m Ynzs+yYj2LMtjNmlgg64T7JL7rwhkh13fA1b3W5QASdTvD+biyWdLtpehhZJwMywxT oSpr5j2d/PdYOG2WYdYCJ5x/pD97Ox0/qGeeIsoOBGQ3yN3npZRL+VZbGJ5VfFC1q2 TwdXoVgukkE1CRGIKVEraeXTg/zOpeuq58A/zW0R5K43QHbENJbH9JASGFzZ0crlx9 bLUwMEcTwMd7g== Date: Wed, 6 Dec 2023 13:47:19 +0000 From: Lee Jones To: Florian Eckert Cc: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, m.brock@vanmierlo.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [Patch v8 0/6] ledtrig-tty: add additional tty state evaluation Message-ID: <20231206134719.GF3375667@google.com> References: <20231109085038.371977-1-fe@dev.tdt.de> <170142723852.3350831.6373465907279189004.b4-ty@kernel.org> <8acd2694429af4f7205db7d7bb39eab6@dev.tdt.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8acd2694429af4f7205db7d7bb39eab6@dev.tdt.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 05:47:32 -0800 (PST) On Fri, 01 Dec 2023, Florian Eckert wrote: > > > On 2023-12-01 11:40, Lee Jones wrote: > > On Thu, 09 Nov 2023 09:50:32 +0100, Florian Eckert wrote: > > > Changes in v8: > > > ============== > > > - As requested by greg k-h [6], I have send the patch 2/7 of this > > > series > > > about the memory leak also to stable.vger.kernel.org [7]. This has > > > already received a 'Reviewed-by' from Uwe [8]. > > > - As requested by Maarten, I have adopted his suggestion to invert > > > the LED > > > blink, so that I do not have to save the 'state' in the tty data > > > struct [9]. > > > > > > [...] > > > > Applied, thanks! > > > > [1/6] tty: add new helper function tty_get_tiocm > > commit: 5d11a4709f552fa139c2439fead05daeb064a6f4 > > [2/6] leds: ledtrig-tty: free allocated ttyname buffer on deactivate > > (no commit info) > > [3/6] leds: ledtrig-tty: change logging if get icount failed > > (no commit info) > > [4/6] leds: ledtrig-tty: replace mutex with completion > > (no commit info) > > [5/6] leds: ledtrig-tty: make rx tx activitate configurable > > (no commit info) > > [6/6] leds: ledtrig-tty: add additional line state evaluation > > (no commit info) > > I think that was a mistake? Patchset v9 is the correct patchset [1]? > > Thanks for applying v9 [1] It's automated. Not sure what happened now. Please check to ensure the correct set was applied. -- Lee Jones [李琼斯]