Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231206063549.2590305-1-srasheed@marvell.com>
 <CADEbmW32rjDJgr4xEArasguWfsSNTJpw__AgsE9n8mwE3qXwFA@mail.gmail.com> <PH0PR18MB473488E1ABF01D5E35A4AAF0C784A@PH0PR18MB4734.namprd18.prod.outlook.com>
In-Reply-To: <PH0PR18MB473488E1ABF01D5E35A4AAF0C784A@PH0PR18MB4734.namprd18.prod.outlook.com>
From:   Michal Schmidt <mschmidt@redhat.com>
Date:   Wed, 6 Dec 2023 15:20:36 +0100
Message-ID: <CADEbmW1R64YsLxjZV3FPZDR597OmJQ6J5FaMP0=QHsoEwFCaWA@mail.gmail.com>
Subject: Re: [EXT] Re: [PATCH net v1] octeon_ep: explicitly test for firmware
 ready value
To:     Shinas Rasheed <srasheed@marvell.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Satananda Burla <sburla@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 6, 2023 at 3:12=E2=80=AFPM Shinas Rasheed <srasheed@marvell.com=
> wrote:
>
> Hi Michal
>
> > -----Original Message-----
> > From: Michal Schmidt <mschmidt@redhat.com>
> > Sent: Wednesday, December 6, 2023 7:28 PM
> > To: Shinas Rasheed <srasheed@marvell.com>
> > >                 pci_read_config_byte(pdev, (pos + 8), &status);
> > >                 dev_info(&pdev->dev, "Firmware ready status =3D %u\n"=
, status);
> > > -               return status;
> > > +#define FW_STATUS_READY 1ULL
> > > +               return (status =3D=3D FW_STATUS_READY) ? true : false=
;
> >
> > "status =3D=3D FW_STATUS_READY" is already the bool value you want. You
> > don't need to use the ternary operator here.
> >
>
> In some abnormal cases, the driver can read the firmware ready status as =
2. Hence this need for explicitly checking if status
> is indeed 1 or not. If it is 2, the function should understand it as the =
firmware is not ready. (It has to be strictly 1 for the driver
> to understand it as ready)

I'm not disputing that. I'm saying that this:
  return (status =3D=3D FW_STATUS_READY) ? true : false;
is equivalent to:
  return status =3D=3D FW_STATUS_READY;

Michal