Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Frank Binns <Frank.Binns@imgtec.com>
To:     Donald Robson <Donald.Robson@imgtec.com>,
        "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
CC:     "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        Matt Coster <Matt.Coster@imgtec.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "airlied@gmail.com" <airlied@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sarah Walker <Sarah.Walker@imgtec.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [PATCH] drm/imagination: Move dereference after NULL check in
 pvr_mmu_backing_page_init()
Thread-Topic: [PATCH] drm/imagination: Move dereference after NULL check in
 pvr_mmu_backing_page_init()
Thread-Index: AQHaKFJoYLStFTrtckSeP2dGEpkpIA==
Date:   Wed, 6 Dec 2023 14:42:17 +0000
Message-ID: <48c059b9542fb453998dd77a676d2ce08fefdd4f.camel@imgtec.com>
References: <13f4278e-af9c-4092-9196-bc0e6b76f1eb@moroto.mountain>
In-Reply-To: <13f4278e-af9c-4092-9196-bc0e6b76f1eb@moroto.mountain>
Accept-Language: en-GB, en-US
Content-Language: en-US
user-agent: Evolution 3.36.5-0ubuntu1 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b2xZcnVVUmVzTmlGdmJXNGRPR1hPM0MrWjgrYkhvK3Y1bVVhZ3djVm5vN3Jq?=
 =?utf-8?B?d2M5cnhkUWZKSU5kQUFVQ0JHbkRkZzZoNkJ4ODg2REhBSTBlMjFuYWdPZ1cy?=
 =?utf-8?B?Y1BGR1FLWVhxQXZaTGlTaVo5NFY5RzBKSTVXOFlGeU5iZVZkT0p1M01lQ3Ax?=
 =?utf-8?B?amRMdUZkR2lERkpBdUFqL0oyM3MrWVRreXFJbEVwUlFXR21MR0tWSm1kT1Bs?=
 =?utf-8?B?cXU0TEFMeHJnTTlJMTFkOVJnRlNnV09ya3RPekVCb1VhOWtiYmNRWmJZdzFT?=
 =?utf-8?B?S1BKeWdIRWp4N00yM1JUN1Q5N1c0UHQ1ejBYQzYzbWVGVGMzNGR1dll4OHZ1?=
 =?utf-8?B?M3pKODF1WThMVEZxbjhMTGRiWHgySTBHVHRnOU82UXNDYXZVVHRBOUVKbTBD?=
 =?utf-8?B?bllqb3ovWU54c2Z0RjY4Q1Y5VndGcU1IS2xJTTVBNDdHOUJvM1NWeDAxdzBC?=
 =?utf-8?B?STVadWlFS2lEbWV4REFGeHhUZGVDVU4ya2NCQzNVMjNNQUsvWWprTUpRcHRt?=
 =?utf-8?B?WEZWZStnQXhYYWtNQW5ZYlRuUXZGMGVyQzRwWjZmM0FtWkZxZjRpUGRvK2NL?=
 =?utf-8?B?TkhEazM5Q2kxRFBjQnZ3VVBDWHpYNFd6RHNLTDRvVUdWQVF0UTV3cDZsMUpu?=
 =?utf-8?B?MzMxeEI1MXgyY3Z4VW0yYTBUeVpzZmlzS1QzZ3lGbXVrOVBEcUJSOUVMREJm?=
 =?utf-8?B?SmVPR05Md1A1UnN3b0JMQnlRSFFrcDF3QUpqMGkxYlh1YmtuTExiT1lMOUty?=
 =?utf-8?B?aTVGR0pPWGFMckVPOWpZR0xTbGVaM2lnRm0vdHB5YmlsMEZPNXJWSzBFM2Nn?=
 =?utf-8?B?dG0vY0RkNktoSUlENGQ0RC96QzZ6OS9NaHlmb3BnNVVPREVVSzdyS2s1YkpI?=
 =?utf-8?B?WUVMMnRoZmc2VzlWMEsyVTdXenhZS3ZuOVBXQ2NBS3Q0aHdERk5YL1E2aUhX?=
 =?utf-8?B?V1kydmxJaTd1OW5WaHN0ZU9VSy84N1NOaWpxdDZMMURRS2ZKWlkyTkttUWJF?=
 =?utf-8?B?NkswTmJON1l1VDlZTUMvMjNKVVREMG5rajFjTDdDRXgrRUI2KzI3YnhuaGlW?=
 =?utf-8?B?VjRqQ1NVeE1kWUZyVStGQzNtMmZMS2dBcGRSMnVpcStMOFYvd2Q2UkdvS0tZ?=
 =?utf-8?B?cy90b2VId2ZZVWh4YnRSWllKZUYwOU92eGxTRG1uRk5ZYUFuUTJsZzhrK1lF?=
 =?utf-8?B?STloZE1SbzU3L0xOWnJIVC9qMjFyd1BodkFuZ1hFVXFuNnJkM3JBSjBCa3Ja?=
 =?utf-8?B?RmtUZFZFUzlhOFo2dWk1alRDYUFXV05lVitUYm9iVENYcTB3Sjd0dHRnWWhs?=
 =?utf-8?B?UG80R0crdnZyYlJ6T2VRd2hsZmpDOUlaQ1RqRHlCMUxXcnBiZmxtaUVRNVNG?=
 =?utf-8?B?SjB5cnB3bGEvYkFwMzlRSWhWeEd3VUhjRFVNZ29RR2d2aC9yc05FNXd4dUdW?=
 =?utf-8?B?NXFtTHZqRDYzMitsdWlaQXloaGoxN2VGU3BsMXNQbWZtbUJ3THV0ZXhPNlBa?=
 =?utf-8?B?encyeUFCV2czMldUcEx4TmpoUnNreUZRbjhTQ2lJa1BnU2htVXR1dzlidkdu?=
 =?utf-8?B?cURIZ1cxUURheHhNc2pndHdPSVhFcng3OFVoTFFVRGFpTENidlAxNmdMKzUz?=
 =?utf-8?B?cXRMcGRRUXpoRmZTelJ5UHRNaVJsQy9xa21Pbk5HY2xwS3R3bDJFTDZOWEo1?=
 =?utf-8?B?dlRCS2hkLy9kNEVVMFpURllsOE5LZWNYQmNUaXRXd0RZVFZEL2VKcXpMVmtH?=
 =?utf-8?B?ZzMzNVhJU1ByNlc4RFE4ZTZPQ0hmd3E5WkhhUU1RczkvRDNUSzFPbXAxZkx0?=
 =?utf-8?B?WlJXMy9PVGtUelF1QW84dUFXNjV2b21ZL0pMZDNYMjNwUjNtaXREd3p5aDRS?=
 =?utf-8?B?K2dlL2NtdThSZHJMRDNSUXRuL0NHWW80TnpIdFVwQ3p2SXN1N2VmbmxhbVJk?=
 =?utf-8?B?ZTZWTk9aOTNrWEM3bUcwcnR4L2YzOEZWdXhlNzdmb0ZLd2tvb0hHUjZ6L1dq?=
 =?utf-8?B?anN5QkQwUS9UZFNMQy94TXJkYjAya25JWFlzaTQ1cDlNajgvUGhPaFFObnpu?=
 =?utf-8?B?b3dWZUdtdWk0Q21kVzZMZ2FTTzhDVmNNbHhWa3dkQ0hRbFVoY3h3cUNrYlNL?=
 =?utf-8?B?c0hYbGZreGk0a2FBai9tYTRuanBHSVNLNVd3VWNoUGFuajdXeSswUWVXeUY2?=
 =?utf-8?B?QWc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5B46404E3CF687499F2BC3CBBD649CA7@GBRP265.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LO6P265MB6032.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: fcd21261-44ac-4d57-07d8-08dbf6698b74
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 14:42:17.4359
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: R+lrDMYHyqV2M1g6JDUkViBAcqWLOLiC5u+M+08nUgGhgmZEdWMYa1gNki241G94EU/a6wtPbqEsVzAQvQ6/zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP265MB1792
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-ORIG-GUID: oTinOv9L6s1wVgmsFJo_y2qEQVyMbadH
X-Proofpoint-GUID: oTinOv9L6s1wVgmsFJo_y2qEQVyMbadH
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 06:42:47 -0800 (PST)

SGkgRGFuLA0KDQpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4NCg0KT24gV2VkLCAyMDIzLTEyLTA2
IGF0IDE3OjM3ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0KPiBUaGlzIGNvZGUgZGVyZWZl
cmVuY2VzICJwYWdlLT5wdnJfZGV2IiBhbmQgdGhlbiBjaGVja2VkIGZvciBOVUxMIG9uIHRoZQ0K
PiBuZXh0IGxpbmUuICBSZS1vcmRlciBpdCB0byBhdm9pZCBhIHBvdGVudGlhbCBOVUxMIHBvaW50
ZXIgZGVyZWZlcmVuY2UuDQo+IA0KPiBGaXhlczogZmY1ZjY0M2RlMGJmICgiZHJtL2ltYWdpbmF0
aW9uOiBBZGQgR0VNIGFuZCBWTSByZWxhdGVkIGNvZGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBEYW4g
Q2FycGVudGVyIDxkYW4uY2FycGVudGVyQGxpbmFyby5vcmc+DQoNClJldmlld2VkLWJ5OiBGcmFu
ayBCaW5ucyA8ZnJhbmsuYmlubnNAaW1ndGVjLmNvbT4NCg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1
L2RybS9pbWFnaW5hdGlvbi9wdnJfbW11LmMgfCA0ICsrKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAz
IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vaW1hZ2luYXRpb24vcHZyX21tdS5jIGIvZHJpdmVycy9ncHUvZHJtL2ltYWdpbmF0
aW9uL3B2cl9tbXUuYw0KPiBpbmRleCBjODU2MmJmYzBkY2QuLjRmZTcwNjEwZWQ5NCAxMDA2NDQN
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2ltYWdpbmF0aW9uL3B2cl9tbXUuYw0KPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vaW1hZ2luYXRpb24vcHZyX21tdS5jDQo+IEBAIC0zMTYsMTIgKzMxNiwx
NCBAQCBwdnJfbW11X2JhY2tpbmdfcGFnZV9pbml0KHN0cnVjdCBwdnJfbW11X2JhY2tpbmdfcGFn
ZSAqcGFnZSwNCj4gIHN0YXRpYyB2b2lkDQo+ICBwdnJfbW11X2JhY2tpbmdfcGFnZV9maW5pKHN0
cnVjdCBwdnJfbW11X2JhY2tpbmdfcGFnZSAqcGFnZSkNCj4gIHsNCj4gLQlzdHJ1Y3QgZGV2aWNl
ICpkZXYgPSBmcm9tX3B2cl9kZXZpY2UocGFnZS0+cHZyX2RldiktPmRldjsNCj4gKwlzdHJ1Y3Qg
ZGV2aWNlICpkZXY7DQo+ICANCj4gIAkvKiBEbyBub3RoaW5nIGlmIG5vIGFsbG9jYXRpb24gaXMg
cHJlc2VudC4gKi8NCj4gIAlpZiAoIXBhZ2UtPnB2cl9kZXYpDQo+ICAJCXJldHVybjsNCj4gIA0K
PiArCWRldiA9IGZyb21fcHZyX2RldmljZShwYWdlLT5wdnJfZGV2KS0+ZGV2Ow0KPiArDQo+ICAJ
ZG1hX3VubWFwX3BhZ2UoZGV2LCBwYWdlLT5kbWFfYWRkciwgUFZSX01NVV9CQUNLSU5HX1BBR0Vf
U0laRSwNCj4gIAkJICAgICAgIERNQV9UT19ERVZJQ0UpOw0KPiAgDQo=