Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 6 Dec 2023 11:33:44 -0500
From:   Frank Li <Frank.li@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>, robh+dt@kernel.org
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        alexander.stein@ew.tq-group.com, alexandre.belloni@bootlin.com,
        conor+dt@kernel.org, conor.culhane@silvaco.com, conor@kernel.org,
        devicetree@vger.kernel.org, festevam@gmail.com, haibo.chen@nxp.com,
        imx@lists.linux.dev, joe@perches.com, kernel@pengutronix.de,
        krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org,
        linux-arm-kernel@lists.infradead.org,
        linux-i3c@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
        robh+dt@kernel.org, s.hauer@pengutronix.de, sherry.sun@nxp.com,
        xiaoning.wang@nxp.com
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2
Message-ID: <ZXCiaKfMYYShoiXK@lizhi-Precision-Tower-5810>
References: <20231017194657.3199749-1-Frank.Li@nxp.com>
 <20231017194657.3199749-2-Frank.Li@nxp.com>
 <ZUz/8fBWtnwdSW9w@lizhi-Precision-Tower-5810>
 <20231127022140.GJ87953@dragon>
 <20231127-cherisher-falsify-8193656e8872@wendy>
 <ZXAKp1WS97cAI5X2@lizhi-Precision-Tower-5810>
 <20231206093106.GE270430@dragon>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206093106.GE270430@dragon>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nYfrRwhGJhza8d0TJDgtD4JhzVhxh2u17xfw/t2TQhSW/Xz5FO0bKZXN0aPm?=
 =?us-ascii?Q?SzT6v30mqMpEAypBarsdKy418z8e/6D6lq2xwCH7wijEJQNHCtuiNeX/Ufv9?=
 =?us-ascii?Q?hAm0vsPYbicvM2lJ688uJ0pbIR8jv6gH++Vovtgpi67KIO1hbLpp+EB3qzxp?=
 =?us-ascii?Q?Iyp+3CZUALLqPduWaj5Mw2/sIqCRx8+AaLMs0j0mpfopB9MUpwkg1wpf8vXU?=
 =?us-ascii?Q?umzlWEGwvke+BRot9J0bWuQAHKxtSS6vkYDvZddmddXMhKHnQLK5frpSU1Zq?=
 =?us-ascii?Q?qiV3dn9GpxTb6fowpKZ8MVQce1rcErLp6XRlj2/HIo+c8dgiJy7TqDeX1L3V?=
 =?us-ascii?Q?kIDVZLHvGwNkrxUK6/drbuQNBb1tmALPY6ZXTb+hSB0msOeyuPY9H9kBR4nj?=
 =?us-ascii?Q?eUgPB+Fdl584oGkO77V6tJUzSgI4A00VaectMSwba0O8L7Az4YWcqz0ahrdI?=
 =?us-ascii?Q?QjmPnFiMBeR+FrGusuOB8Q9xZ9ebofaqRWrxHVrvqsgwCyu5ZmZFRqAP3PzD?=
 =?us-ascii?Q?Xl6Rej6nNYBV39zzW7+fVefpJL+QTRPr+6LZYzjNbVZ5A/8TduWYkwx8W99w?=
 =?us-ascii?Q?X8LlzdT8advRnakzBwIJhPL57/m2oSa4WkZOxZjGIgT0skwDRbx3Re3qM91c?=
 =?us-ascii?Q?d5bBRq74if1Le5crk3qefhiBqLUCFP6N/i18P8uB2YFudSmzR1YRbobclWRf?=
 =?us-ascii?Q?r2yhuUr56dNuaPYe9JytfOU/Qn6KiwYei2TJS4ktZyPFDliGk5UryEJOzSne?=
 =?us-ascii?Q?V1MUBtpo6jEjvjepZ+GPpTL3GmUVoJlA2quqvwfUtXmykAPgOMIXrTk8SbIN?=
 =?us-ascii?Q?Nl2P/qhg22QJs1cpdapSDfgZ0cNmqYGc8ZNWF0khDKnpuekzIa9c414QY2GB?=
 =?us-ascii?Q?kMJro0LWmqX1fU4vHpACYOAEHEJZCuM1UO3buzvLfZdj//WkYjMw0Gu9nYUR?=
 =?us-ascii?Q?RbcDAA1e0VOhIG3/XlKYRB1wuadrdtB2t0eJaMEBoEnPiuwdSWeTJ1BTWeRA?=
 =?us-ascii?Q?yVHZwp4Wl/30o5O4stA+LlcUXMur1Rhd3iF0jaJjynGxaifs0o1d3iXqnIaT?=
 =?us-ascii?Q?ZcvZKqExncEPjraY8Akwnc+DSodeGQSMNnA6PuEHGf6Gic+B7d7RgBT8FDc3?=
 =?us-ascii?Q?7zEA9U+Gw5m6S10mASmO+tunQxmLN9YjAK3OYK47CQYDxUNTkA9PYiMY2BEY?=
 =?us-ascii?Q?+zN769evjGKDm3yuP18lMofk+edm5S9pBcVLJcKyXhWlOFgq2EcoNwvn9nlV?=
 =?us-ascii?Q?fIPm6iemmh3EX4ZQgBFjJrSnuZbrLpLmbgVTwK3sNi10ToRKB1Lg/lgQCO6U?=
 =?us-ascii?Q?LALYmabyvNlebf/2c3NHEstlVdM/LajV06kVzjISCx+UI6XkxBgpH1syr/9O?=
 =?us-ascii?Q?JTKKCxrtN0V3YChSxRFHN9ZVZUAEmfol7kILnBDW0duK1ll1aYOzGCZZ8m+g?=
 =?us-ascii?Q?E1JLvkix1VN929L3L6xYkqVcluT6klu0YuU8EA12CsPwlv0EMX61CE3CuIFD?=
 =?us-ascii?Q?z9bT3pwh4D8Qva778x2ThaRF6f22MTO1Yj1TpwYnoShsNvqg02P2jvhIoKwI?=
 =?us-ascii?Q?o82qjICrad17xXKyKbA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f5596d8-5adb-4fda-d326-08dbf67922cd
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 16:33:54.0640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vKx1VWak+oTjAO+G4HPGDuFiUFvASbLTouLO3r+P1uebV+awBBZ+vRuKZZ7mGp2woa5ZPYL4wZmMgaFWDQmU/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10023
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 06 Dec 2023 08:34:19 -0800 (PST)

On Wed, Dec 06, 2023 at 05:31:06PM +0800, Shawn Guo wrote:
> On Wed, Dec 06, 2023 at 12:46:15AM -0500, Frank Li wrote:
> > On Mon, Nov 27, 2023 at 09:35:39AM +0000, Conor Dooley wrote:
> > > On Mon, Nov 27, 2023 at 10:21:40AM +0800, Shawn Guo wrote:
> > > > On Thu, Nov 09, 2023 at 10:51:13AM -0500, Frank Li wrote:
> > > > > On Tue, Oct 17, 2023 at 03:46:57PM -0400, Frank Li wrote:
> > > > > > Add I3C1 and I3C2.
> > > > > > 
> > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > > ---
> > > > > 
> > > > > @Guo Shawn:
> > > > > 
> > > > > Driver part already merged. 
> > > > > 
> > > > > Please pick up dts part
> > > > 
> > > > Rob had a comment [1] about SoC specific compatible.  That's not what we
> > > > want?
> > > > 
> > > > Shawn
> > > > 
> > > > [1] https://lkml.iu.edu/hypermail/linux/kernel/2310.2/03035.html
> > > 
> > > Yeah, Rob's request here looks valid to me. Should just be a bindings
> > > change Frank & fall back to the "silvaco,i3c-master-v1" compatible.
> > > 
> > > Cheers,
> > > Conor.
> > 
> > @shawn:
> > 	rob agree on "silvaco,i3c-master-v1" compatible.
> 
> Hmm, not sure I have seen that.  Here is what I saw from Rob:
> 
> "
> The real problem here is not whether we have "v1" or not, but you need
> an SoC specific compatible. Unless there's a public spec where we can
> know exactly how many resets, clocks, interrupts, etc.
> "

@Rob:
	Previous existed binding doc is "silvaco,i3c-master-v1". So far
this IP in our difference SOC have the same resets and clocks, and only one
interrrupts.
	current existed i3c controller compatible string is

	snps,dw-i3c-master-1.00a
	cdns,i3c-master
	mipi-i3c-hci

	mipi-i3c-hci is standard. "snps", "cdns" are similar as prefix
"silivaco".
	I think the same IP vendor and same IP version should have same
resets, clocks, and interrupts. So far still not met exception yet.

Frank


> 
> Shawn