Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1107927rdb; Wed, 6 Dec 2023 08:47:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpcLpVbLhh2wwsPezPwCzz5D1mtEDJGyv+lCiGMOoBYpzyOWhnpwaZC9rrxT7b00EI1kfU X-Received: by 2002:a17:90a:4982:b0:286:6cc1:279 with SMTP id d2-20020a17090a498200b002866cc10279mr891672pjh.68.1701881227820; Wed, 06 Dec 2023 08:47:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701881227; cv=none; d=google.com; s=arc-20160816; b=SHhRpmRIET27jSCAwgeHYnWMA51vfoBWle3cNXsU2d9Gf4xu7gjqv8EwQ2MxUkHX5K AkOxdXF7TM+Nt4+I7czQ+408TOcwcQ2uHTZysSpO3Ldzk88cC+OP2dSHre9NUOAvvYAj qgO1r3XRBRtP0j6kbzKznfzZAx/FD8EccecZfnh0SLN1BxaeI2Y/OTW2/4FX1l+gXmEw RNtfhaC7gkrpOo/6Hzo+seaZxcXdqNFDQFbxLvr5jkeCJA1um+5arLckT0MgeDj9usGw JdBQfT5crf8MzkkbUO4XPz3lI99g1c9OkJg6ogrLNJSgWfhDpVQFxnMvRKvKrYButs1z lhFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8QwJmoDP7/rLy9hDhj5qWhLLbFCrWOxFl2C6kKd4gBI=; fh=eDRiVrvdkXNDJ6i1lHTbE7zmkm2Mb7Y+9c+vjeORh+Q=; b=iHT8AREBQgJtDSWbfzjepPqGMrTUTOSnNr/tdPPOU0I5COV5AswQ2gY4bvq9CFYsSI MzndTdBu0+hPiB5276MCzSO1FhbzHUA+lcfWB59URO2s4BMfkNh0Tf7kyb+aP/gHwAvZ 3aLfFty9gJ27CoQVVYxAbhF6mDRkiuJY82kCj/178K7iT3p6NRHjqNg5VgAD1qO3/7US my0FxhWSDRl57ssEoV5VQiC5xeNlqvs3QY0MKtK6hn4KfYwopeTGhVDUWCPP7ewUQbEl 7uzi4FHWFM/efmdwQrLXePzsT/2sKL2pQyKixK4AzU0o3Lk9aHKtnCGKkvgEE3sqIBFp my+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="lkr0L8/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id fa24-20020a17090af0d800b00286785e0bfesi105803pjb.147.2023.12.06.08.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 08:47:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="lkr0L8/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 06D74802F216; Wed, 6 Dec 2023 08:46:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378546AbjLFQqh (ORCPT + 99 others); Wed, 6 Dec 2023 11:46:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378367AbjLFQqg (ORCPT ); Wed, 6 Dec 2023 11:46:36 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE6C5D3; Wed, 6 Dec 2023 08:46:42 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a1cee2c1620so141557966b.2; Wed, 06 Dec 2023 08:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701881201; x=1702486001; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8QwJmoDP7/rLy9hDhj5qWhLLbFCrWOxFl2C6kKd4gBI=; b=lkr0L8/pSK/6RL1zWrAyCRsQjlQrjEJa0Y80vHQNZIiEoVJCVqxbe+s1zlFZQ5Xf2j ZrDKt8VdYl08nd4xqoOEub3NiNRVbIprYFkRF1l0eBs+g551GFpTYRSkNieSi5/Qgs2X jq+WW3og1jlPF07Ukn30fUXu0+SfGbBhqQL3v6dl+MqXNzbyrGo/AIFHP6dBlyodQGFY Hq85CDQQia4QlHyfHkR6wHoxTxXjNpgHNYyHE/Nu0RKyF9kDJxYPgWpD/nMuKlcJ9d05 Ek7mUeknj3ZgpPQlw2rL6GOOD9j7W4Gsqv+4bR+3z5kvIbGKeZNOi/C2cQBkwg0iWDKI 2QDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701881201; x=1702486001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8QwJmoDP7/rLy9hDhj5qWhLLbFCrWOxFl2C6kKd4gBI=; b=L40EJKdsNgB9U7I82NwAcdnn6rDcVoqN22yQTM6gWrhMOxk+PBSdaJbnUozgqHNvki IFiSrUK4HrcfvAS8P/CrBDiSvk3CQ1LvUDVeH1v5ITO/lkpq56Tx2Xb1EPjcNoUooZmY w+87l+RXIa4/rXmTLDSH5sRlZeZT+BBAxFIXMDHlcIXIxo0yzRL4xjMPPZzcemLgIYA4 2wFI+i8Om7Ym7UwXAKjdRjjVgpbyoZ5SJxf2d5zFyhUe94JjklW6VlzgjY4JbMR6CNU+ qXGnUq+nlC1xOlxWkFk09z/pd2I2xtYybggcs2pleD/Vg/MY5TAtBKSV95aeXw9B7CFk gTCA== X-Gm-Message-State: AOJu0YxP77v+T6bV7+uE4qfnUkiZqPQN2XGWYfNQzhgIAhfGDYpj9s6g z30/kdA5tI2lpw/pVn01SISOIY6anDRzHq6s X-Received: by 2002:a17:906:739c:b0:a1d:ef9f:6ba2 with SMTP id f28-20020a170906739c00b00a1def9f6ba2mr323825ejl.285.1701881200826; Wed, 06 Dec 2023 08:46:40 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id lj12-20020a170906f9cc00b00a1b6d503e7esm146930ejb.157.2023.12.06.08.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 08:46:40 -0800 (PST) Date: Wed, 6 Dec 2023 18:46:38 +0200 From: Vladimir Oltean To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next v1 1/3] net: dsa: microchip: ksz8: move BMCR specific code to separate function Message-ID: <20231206164638.sizbc664kxv3enks@skbuf> References: <20231121152426.4188456-1-o.rempel@pengutronix.de> <20231121152426.4188456-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121152426.4188456-1-o.rempel@pengutronix.de> <20231121152426.4188456-1-o.rempel@pengutronix.de> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 08:46:51 -0800 (PST) On Tue, Nov 21, 2023 at 04:24:24PM +0100, Oleksij Rempel wrote: > Isolate the Basic Mode Control Register (BMCR) operations in the ksz8795 > driver by moving the BMCR-related code segments from the ksz8_r_phy() > and ksz8_w_phy() functions to newly created ksz8_r_phy_bmcr() and > ksz8_w_phy_bmcr() functions. > > Signed-off-by: Oleksij Rempel > --- Reviewed-by: Vladimir Oltean Let's see if this does anything: pw-bot: under-review