Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 6 Dec 2023 12:48:02 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Marc Zyngier <maz@kernel.org>, ankita@nvidia.com,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@huawei.com>, oliver.upton@linux.dev,
        suzuki.poulose@arm.com, yuzenghui@huawei.com, will@kernel.org,
        ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com,
        aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
        targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
        apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com,
        mochs@nvidia.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] KVM: arm64: allow the VM to select DEVICE_* and
 NORMAL_NC for IO memory
Message-ID: <20231206164802.GT2692119@nvidia.com>
References: <20231205130517.GD2692119@nvidia.com>
 <ZW9OSe8Z9gAmM7My@arm.com>
 <20231205164318.GG2692119@nvidia.com>
 <ZW949Tl3VmQfPk0L@arm.com>
 <20231205194822.GL2692119@nvidia.com>
 <ZXCJ3pVbKuHJ3LTz@arm.com>
 <20231206150556.GQ2692119@nvidia.com>
 <ZXCQrTbf6q0BIhSw@lpieralisi>
 <20231206153809.GS2692119@nvidia.com>
 <ZXCf_e-ACqrj6VrV@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZXCf_e-ACqrj6VrV@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vgXhN8xZjUaXP/Jkn9+XSSJYKDQAFzhMBnBi9G6IWC5NbmgalQB0qi0Pl+fh?=
 =?us-ascii?Q?sPtKfcSaY5+6v8faQ/AjmA6Q5Ll5Jjei4uy4jljyJOztwPSS841ZGKC+c7IF?=
 =?us-ascii?Q?4GaPd4QTEV/rfwfGefYzjfq/n6+z7qKMikiF/Uj7zofkItqarD/yYp3oXKCi?=
 =?us-ascii?Q?xeC8lJ9kfqE1kKIkmgh6yspm3I7f5jCcJLty3MQCLVwfTu+T8umI6QAo81eG?=
 =?us-ascii?Q?W5dC44SEnuyj0WT3K3b7k4DafT54sS6luWWI/JdJ0rHPKzKmc/8h7TRcJys6?=
 =?us-ascii?Q?Zk7Ta5EzSbMSmzhqeG7gcufymiBXBdU90GiceTvZsCgUTGC0AlWlM8mvANeF?=
 =?us-ascii?Q?tMgFztutzr7smddQRjJqRPMvniBVJdAb1yd714V7HkeIwQFzRsSS4mubECu4?=
 =?us-ascii?Q?6obYHSg3gxy3bPwF9Ic0uzKDMi7ZQ1A/tmOwJCHKEBdt4pSmxZL6NSDamWQp?=
 =?us-ascii?Q?GPk3AlK6vSeNNN1srxgTELIgh/t7hA6PdFH5Hm3o2Lw69t3VQYzvP+cdhXCw?=
 =?us-ascii?Q?TbJrt+3lLqfCD/dWaMR8GmVxxElc5v8NCpNJeUtiqUUnLtAv6Y/n6LDedNmo?=
 =?us-ascii?Q?+R1c5ZueFU9PHfelIaFJ8dQUhOWGi31u2CHiiziyx7hWHx1Umxp8ydjXowei?=
 =?us-ascii?Q?UlbBK/UubxdIJ0BaXEa6usOSTKqClM2Y2+Nnqxzs/7DUxxEEtVkLXl8Tk2W1?=
 =?us-ascii?Q?np1ZVmGMgIMJoB/bJu8K6TF6FzcJOyaitZlI8sPnbzoyFvSUM55At3AQvPv7?=
 =?us-ascii?Q?xNpkO1RFDfe3CuBw7SOw0Pa00L+jrnULLtq6nP3tb9AEoIJOBZ82fC4C/1bU?=
 =?us-ascii?Q?SIgukHP9HJ3xpjN52g0HEIYCYlO1TArUfhLk09uCYETg9gFUxfwTX6qPhu39?=
 =?us-ascii?Q?0q1wIqidLBGp+mVEtmlW5v3O7WOQuKPJ4QHjgtZ+Ude6VReDQsPjiCq0cB4+?=
 =?us-ascii?Q?zmyRab23UZtUnb8E2kNgOnDcZ7EZn+/Yao/Us1lEfVDDfRDhyjkGDXgD3xSx?=
 =?us-ascii?Q?YzzRDURZuiVwpdB5oFhVhAru6/8H/Rc4QsWBIs27lMbcjwaDw5ab8UegPsgn?=
 =?us-ascii?Q?rdsOIyNSqxGXe4Z5JlC1aq20gBLAhEiftpk7nzjRl0LpDe0a/sKm32Q3htcG?=
 =?us-ascii?Q?Mi2q+kuqavA2QtiHXYuHeXQhqD2LRfkydw3fO+sTd0smo9JURentJmj6n48H?=
 =?us-ascii?Q?aS3+eVPkQt1Q0T4nqmEma2ixNDXEaelVp1/xDuWLFKldLC66FW7RAllVJU9q?=
 =?us-ascii?Q?dx3u9QiDOcd0wQ6K+xesYbmKWNJCqPD9UAug+4DzJ895WAy0SHNoIffogq4Z?=
 =?us-ascii?Q?Yl2ToX3XgXzfIPR92Ij0wTdlCuFN8Oi6NpidAuwEK7BdSyF4Oyey6Wkot9Kb?=
 =?us-ascii?Q?/P/RGo4d/OJIqlxff/UKSQRqSJnPeiDQdrGNo2oQHO685g4e+2xetIfCGfgT?=
 =?us-ascii?Q?AFc9Iz7VokhAo47ZqAYduktFOrrjngL61a7WHtQIpGKc8zC7PRnaG7TfbFD6?=
 =?us-ascii?Q?Jw7ksQYeY8sRaK0dP7aessAMYl3awZsUPt6TrZdks3xUiEKZP0+MYD22xgNU?=
 =?us-ascii?Q?TY3DR24Cns9LNjmWQtJ4Us0B0mrNgabKuVW5Fc0J?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3866fe20-9d9b-4d36-a84b-08dbf67b1d01
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 16:48:03.3145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gwBaVBxLkcJYB8Vl88lNk0uBtFZaU+27YDo7zSdcKDI0f/b1zDhTZhSTYhHYlVnX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6171
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 08:48:12 -0800 (PST)

On Wed, Dec 06, 2023 at 04:23:25PM +0000, Catalin Marinas wrote:
> On Wed, Dec 06, 2023 at 11:38:09AM -0400, Jason Gunthorpe wrote:
> > On Wed, Dec 06, 2023 at 04:18:05PM +0100, Lorenzo Pieralisi wrote:
> > > On Wed, Dec 06, 2023 at 11:05:56AM -0400, Jason Gunthorpe wrote:
> > > > On Wed, Dec 06, 2023 at 02:49:02PM +0000, Catalin Marinas wrote:
> > > > > BTW, on those Mellanox devices that require different attributes within
> > > > > a BAR, do they have a problem with speculative reads causing
> > > > > side-effects? 
> > > > 
> > > > Yes. We definitely have had that problem in the past on older
> > > > devices. VFIO must map the BAR using pgprot_device/noncached() into
> > > > the VMM, no other choice is functionally OK.
> > > 
> > > Were those BARs tagged as prefetchable or non-prefetchable ? I assume the
> > > latter but please let me know if I am guessing wrong.
> > 
> > I don't know it was quite old HW. Probably.
> > 
> > Just because a BAR is not marked as prefetchable doesn't mean that the
> > device can't use NORMAL_NC on subsets of it.
> 
> What about the other way around - would we have a prefetchable BAR that
> has portions which are unprefetchable?

I would say possibly.

Prefetch is a dead concept in PCIe, it was obsoleted in PCI-X about 20
years ago. No PCIe system has ever done prefetch.

There is a strong incentive to mark BAR's as prefetchable because it
allows 64 bit addressing in configurations with bridges.

So.. I would expect people have done interesting things here.

Jason