Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   <Madhuri.Sripada@microchip.com>
To:     <sean@geanix.com>, <Woojung.Huh@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <andrew@lunn.ch>,
        <f.fainelli@gmail.com>, <olteanv@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Arun.Ramadoss@microchip.com>, <ceggers@arri.de>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler
Thread-Topic: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler
Thread-Index: AQHaKBRhZLeoCpYepkqcVAzm+JG6R7CcgKEg
Date:   Wed, 6 Dec 2023 17:22:55 +0000
Message-ID: <DM6PR11MB4124D98726836442169C2C55E184A@DM6PR11MB4124.namprd11.prod.outlook.com>
References: <20231206071655.1626479-1-sean@geanix.com>
In-Reply-To: <20231206071655.1626479-1-sean@geanix.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ky33LOPRgDMERNTKYggubkeib6En+i9mrn2Eko67Gv/LuYqYcz2j8okIHoQc?=
 =?us-ascii?Q?ep2+M42by9i4eDZnGp8NuDjfoz61tYyULydGt67oj7uAVDjidaBKhxd+Sd2k?=
 =?us-ascii?Q?+Pen9lCJSKcvAtlo49YANPJQycvT+nguNCBX0ZgBaMYKb1HuVtgr9s6NNDkD?=
 =?us-ascii?Q?LVMnUcK/IcUi2oGIS5dJ2xThqi/cl1IAyrLEpvKdOAbls+6I7BGYIC6GkvkS?=
 =?us-ascii?Q?aIJ14xZkmk32jd1VLPGSSDHv3d6ARjfAh4MK4WnYlK1cdivBxUMxet11fX/w?=
 =?us-ascii?Q?Z3Y2dxFz9Rmt7TCvoY8dhlbZOQck6RvsQUUcNe8JxgIDSNQH9oTePith6eYI?=
 =?us-ascii?Q?kp4DQsIigsNUmo//6+vFEVgc5+iLyRDpaN7okzWfSs7zhVki2twUVBnSIPle?=
 =?us-ascii?Q?QdlEQ/4vvbuA882MkZ0MXFzCb7gwsnRVRtgMAnVjE+fmTzF1FVfOqtXJEI/3?=
 =?us-ascii?Q?sQJ4VdUfxRM31CtgCl+wKzHSxW9YaOzN4ZZjTIc4RrZ7e5BRh6Zltc5LTRp4?=
 =?us-ascii?Q?Bd/Kopky69K/e0uvvTAIOGsxT3ARp3FtgQghP27/tqtkrc8kmCnbzRKhdT1p?=
 =?us-ascii?Q?3/ibTLhvGxQudNg3oxzJ0kCqQ6/e+a76dhPzUHhjHU33ch3Ni7ux2RZrB4wl?=
 =?us-ascii?Q?r/4FNIQJQBsJ4jltUDeKzV+xoV3F2JYbehrwi5Ds/5elEp4sxgJujeBtQSkT?=
 =?us-ascii?Q?laiuVBUxxf9c9sDjlZ9pWYb2vBKv/6rgr6zQFUn6eAT4jntUodJKk0FOjo9o?=
 =?us-ascii?Q?ePu1/8FoXPMWnkRBX8NFYK6Qs7AnarCa8K1MY0LzG1hj+34yOwRDhqYWi6lN?=
 =?us-ascii?Q?odMTE8Crhtpq7LO7WbyHnxPqr1atnlOCsW4+fT5Hs50ZBoS+65RpNo/D7rTu?=
 =?us-ascii?Q?BiWcj5Mo2APZFTsCjKZ5Rm4HNm2WdyOPyzuWcih5wO6HiRhCSfLZZ4aQrCz1?=
 =?us-ascii?Q?w81WVO6UgFAEFW1DsC7L9skORuT051cg+WmU5xFV8TKpEvocTVjbHafjltZB?=
 =?us-ascii?Q?C/zK0xo2rh3nRI4oX7sHeuYA8xB3g03pzOTSgWgmy40J3zbYm3haRtKqy4Eu?=
 =?us-ascii?Q?W4SLwPk7tpBHb/JKSSd+QOyOnMkE+KS4R0w+cTejdRmQsx6wy+X+dopFv/Q0?=
 =?us-ascii?Q?iV/TWkXaowgj2wbVth1MVwb7FxQONUZaYQBtXN7wxBPK4UXPvK8Cowd92H9E?=
 =?us-ascii?Q?SYUB41D0nbIG6u3ZumhaL+twnHRKj5QDJiBmiYwSCiAF4lNwC35fuER5CACM?=
 =?us-ascii?Q?5WgEh3/Fv4n8jMmXvRPoQYYDfwCe0mv4MrKKzchMLUtufH0lJHMvzNY6D9Ho?=
 =?us-ascii?Q?c0vsEgtSOMIWrpRjxm5oRGjA0a8jxPedK/F4CyvfYrxnMKsmT7jxYHJM33Z1?=
 =?us-ascii?Q?tYwQLE2U5z3/Ly6VlNVrmVXAvIQpDQyx08XpP5mXg//552mwxLwjLNPWAS54?=
 =?us-ascii?Q?Poa4Vwn9jACuda5m/VkNMDKDaDX54GJGkpeNduBKlSvpop/O3cBm2Kr1+EGV?=
 =?us-ascii?Q?wezSg9VYy/qy7dcyrYaKQgnuJ3ldBOoaBlgU32duo6EgJZ40lO/B5RuN/qiW?=
 =?us-ascii?Q?54yd/Z4dmqjkfiCTAtxvU15/GXVc7HDaKOboST6ZErO0zD6HTHh16mpJMbg6?=
 =?us-ascii?Q?LQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4124.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f86a7a9-5eef-48cb-eb64-08dbf67ffc6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 17:22:55.9503
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3H3dItfloQBJg+zFZWrcHreM84s6MVvhJmySXZnxXvXgm4AluJxqXMcnAmzA40PrCH+CuIdwRtWuYkPAzrq/pyF8Wnlk4RpVfauuPIJoEmU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6804
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 09:23:30 -0800 (PST)

Hi Sean,

> -----Original Message-----
> From: Sean Nyekjaer <sean@geanix.com>
> Sent: Wednesday, December 6, 2023 12:47 PM
> To: Woojung Huh - C21699 <Woojung.Huh@microchip.com>;
> UNGLinuxDriver <UNGLinuxDriver@microchip.com>; Andrew Lunn
> <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; Vladimir Oltea=
n
> <olteanv@gmail.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Arun Ramadoss - I17769
> <Arun.Ramadoss@microchip.com>; Christian Eggers <ceggers@arri.de>
> Cc: Sean Nyekjaer <sean@geanix.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v2 net] net: dsa: microchip: provide a list of valid prot=
ocols for
> xmit handler
>=20
> [Some people who received this message don't often get email from
> sean@geanix.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Provide a list of valid protocols for which the driver will provide it's =
deferred
> xmit handler.
>=20
> When using DSA_TAG_PROTO_KSZ8795 protocol, it does not provide a
> "connect" method, therefor ksz_connect() is not allocating ksz_tagger_dat=
a.
>=20
> This avoids the following null pointer dereference:
>  ksz_connect_tag_protocol from dsa_register_switch+0x9ac/0xee0
> dsa_register_switch from ksz_switch_register+0x65c/0x828
> ksz_switch_register from ksz_spi_probe+0x11c/0x168  ksz_spi_probe from
> spi_probe+0x84/0xa8  spi_probe from really_probe+0xc8/0x2d8
>=20
> Fixes: ab32f56a4100 ("net: dsa: microchip: ptp: add packet transmission
> timestamping")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> https://lore.kernel.org/netdev/20231205124636.1345761-1-
> sean@geanix.com/#R
> Changes since v1:
>  - Provided a list of valid protocols
>=20
>  drivers/net/dsa/microchip/ksz_common.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 42db7679c360..286e20f340e5 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -2624,10 +2624,18 @@ static int ksz_connect_tag_protocol(struct
> dsa_switch *ds,  {
>         struct ksz_tagger_data *tagger_data;
>=20
> -       tagger_data =3D ksz_tagger_data(ds);
> -       tagger_data->xmit_work_fn =3D ksz_port_deferred_xmit;
> -
> -       return 0;
> +       switch (proto) {
> +       case DSA_TAG_PROTO_KSZ8795:
> +               return 0;
> +       case DSA_TAG_PROTO_KSZ9893:
> +       case DSA_TAG_PROTO_KSZ9477:
> +       case DSA_TAG_PROTO_LAN937X:
> +               tagger_data =3D ksz_tagger_data(ds);
> +               tagger_data->xmit_work_fn =3D ksz_port_deferred_xmit;


NULL check is missing here.

> +               return 0;
> +       default:
> +               return -EPROTONOSUPPORT;
> +       }
>  }
>=20
>  static int ksz_port_vlan_filtering(struct dsa_switch *ds, int port,
> --
> 2.42.0