Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1134889rdb; Wed, 6 Dec 2023 09:26:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGdTAx6RKIUKtrjrFI3j0jW1GpKOlywyMBWqZoAinWskrIJd6urWqcrkT2gYiDoMWYcc5J X-Received: by 2002:a17:902:d511:b0:1d0:6ffd:9e13 with SMTP id b17-20020a170902d51100b001d06ffd9e13mr1336979plg.101.1701883599312; Wed, 06 Dec 2023 09:26:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701883599; cv=none; d=google.com; s=arc-20160816; b=tVi8WeRZ9mdyx2KJvDbNUlGeOrFd2xKw90tqL3GT4+Vibrsswq4TyEzTnc93RRKI2Q G0BzSMWipa0C3bJBRPR7jooEpetYX3Imr8pJ6W9EdW19Ui71Inkdcwc0QMkxciC+Vwtc swZ5WEedZbdrhsBGPMz1N+W5vhcOBdpNHqug9jrbV6QjqG6TWczxv6d2ixTMyNbJyRZ1 CTRz/Zr3yfW/KlUb8FhaMuQdCFRojY4Sh/AMPhU/okbTUJBA1eoDXKCmCACT/dLjrUm+ 2hycfbjWASPB3oUyduM0I60RxjuMLQ7oXk3uSRR4qHzWiQ/rkGiyld5ChxgZy+dazCdu 2BwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XZlK2oiq0c1d4tnzLcflwgGE+fdbw4Y3Ah3eo8MZaoI=; fh=D5ZnKqAmgbseRTIXmSnoTUZOCZTJwJTkuFfw/iOTNao=; b=brgdaI9oOBJgnorR40EZlDGMQMK4t9JDMxFwHypSF83qTNApdlj/pE8TVSZt75lrRs QnklcA35Ar5r7jwHULEK7tszxokQ+xxvV0C6BOZyafmHZT7+rWW+UD3Gf56UyogSB73q 8azzNWcl/o3IFZW9wubzxb3WM06UQhutm9xCYtD8HBiPUr1obrIy52QA7gj+pT6fYFPg TQM98DM/C0MmWU5OD21+5GGHu7dkc1IBlvtwj9fnihCneShlX0Zzf3fDgz1+skYLsQ/z OEWem5gesHYxo8m93IwiwmELFVE2Ax7lCC5IoXXHOflHeR2zLry282MPecNI0ZatjrpW tb+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="hS5rueB/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id a7-20020a170902b58700b001d049eca370si89258pls.589.2023.12.06.09.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b="hS5rueB/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id CA135801C94F; Wed, 6 Dec 2023 09:26:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378681AbjLFR0H (ORCPT + 99 others); Wed, 6 Dec 2023 12:26:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378628AbjLFRZz (ORCPT ); Wed, 6 Dec 2023 12:25:55 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C47A84; Wed, 6 Dec 2023 09:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XZlK2oiq0c1d4tnzLcflwgGE+fdbw4Y3Ah3eo8MZaoI=; b=hS5rueB/cfpMaqar0PuBXkxaB5 TyGKMNibNGyEKSb6gmdSgiChCoupduYvUZxSL4HQqfKqE2brILWX9YEfjPYPw1CrIaVdoRGWVYSgU kl7Sg3MRigEv2El1Y3/IjOIJHZwC31SdvNY4sOIATAF3+Ig1CPpMXpWeUPfIKUTXD3Ac=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rAvej-002EZv-Da; Wed, 06 Dec 2023 18:25:53 +0100 Date: Wed, 6 Dec 2023 18:25:53 +0100 From: Andrew Lunn To: Christian Marangi Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v2 11/12] net: phy: at803x: move at8035 specific DT parse to dedicated probe Message-ID: <35221bc0-4f7d-436d-bfca-a56330682de0@lunn.ch> References: <20231201001423.20989-1-ansuelsmth@gmail.com> <20231201001423.20989-12-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201001423.20989-12-ansuelsmth@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 06 Dec 2023 09:26:37 -0800 (PST) On Fri, Dec 01, 2023 at 01:14:21AM +0100, Christian Marangi wrote: > Move at8035 specific DT parse for clock out frequency to dedicated probe > to make at803x probe function more generic. > > This is to tidy code and no behaviour change are intended. > > Detection logic is changed, we check if the clk 25m mask is set and if > it's not zero, we assume the qca,clk-out-frequency property is set. > > The property is checked in the generic at803x_parse_dt called by > at803x_probe. > > Signed-off-by: Christian Marangi Reviewed-by: Andrew Lunn Andrew