Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1141056rdb; Wed, 6 Dec 2023 09:36:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IERaPa0K0kkk0bMUH5K/uq0mQvQupucsFxtJChOT7rCL0Gu/jgF+UCSZTwkWYogcezfL/qt X-Received: by 2002:a05:6e02:2182:b0:35d:59a2:1277 with SMTP id j2-20020a056e02218200b0035d59a21277mr1800553ila.35.1701884168287; Wed, 06 Dec 2023 09:36:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701884168; cv=none; d=google.com; s=arc-20160816; b=coXuxpcM8ZDEep9W07f2Chpjvqc9qugkMuCz32rZwYZqYoaH1Chz539DH+3HuaZ3Gr 2EbciNIeAmn9pus0PB+aVPae6xpb1x9I8lJHznHsv2qIM+YVnu0InJCN/8PzZvjRTw0e U+8Atx2mUSREFzhnK6EByXQ0c+8V8BeZ1sPjN27jdoWYx6LeRegmmQmqGZWSQxgfNC+i iFjasRBR9vD4i4y8LJOh2EA645/UzyUpw/ocsbnGs9sgDQJLC60XE+o0GwYkHjA936KK zE0yQkwfL1i3L2WOIUgzIaLJcsUHv3FNZEzzmC/UVe+iUTFgWJCTzTRBxIdWCFn3a57+ 2Fpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EC1WbkFRMsdQ89+qHvQLwas+YHcOCsKWIhN5BFKA96U=; fh=6/iL2MFEDdvLV+gyFzs3e6RGBaE402F6TL6csxE201w=; b=TIikXD43QpxEtx87aYA0MLEECAK53XdXBU5kD4w5H7zz55ikYMPEMfHzWREpC7U4ZG qeUm8SDf74Nihfa7aspEO+eeso6/qk4ViCVl3Ys88RsKJbk+jRlzDmHvV13B3mzx0aVL L96HgjobWR8M7fERbvUUbMur7Aa8NqWL1FVC350GAfW9ZJomr7D4oyIM7If7pXBVVdUE EiPbQ/WFvzsxXqN2McAnSaQrCsXBBOoQIDJ6h0ys9e1L8TU5n8PHv5s5DgW3LPcaaQyN zAMbcsE1hrf7K8v3Ia4527glBEAMraxJmsOV25hS3fECOucbSWi9omFDxRTywIQh9Bin E3GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RhaYWZnX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id m187-20020a6326c4000000b005be03f0da68si233206pgm.13.2023.12.06.09.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:36:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RhaYWZnX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 49878802933A; Wed, 6 Dec 2023 09:36:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379706AbjLFRfr (ORCPT + 99 others); Wed, 6 Dec 2023 12:35:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379731AbjLFRfl (ORCPT ); Wed, 6 Dec 2023 12:35:41 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9849D40; Wed, 6 Dec 2023 09:35:47 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a1b68ae40f0so106754766b.0; Wed, 06 Dec 2023 09:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701884146; x=1702488946; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EC1WbkFRMsdQ89+qHvQLwas+YHcOCsKWIhN5BFKA96U=; b=RhaYWZnX8sOR8h22kBnXdtWbOft+EFENGLG9qbbjhHg4ymUVvw/bUIv2Ug1qfxRGzy z0JQI8+eB60L0howrLEmAxP2wxD2zkwMr66F+7MXjH34PiWOE6ogZS8NRtwUvonGinQn BRSGLZf39BZTKijJZ5kTJw6YvqmF+42G9TAos37rLX7batNkDzAf86gqmYRJdFPylfjH 8f9dJYWAddwzEH39Lx+siJlUsIANuiGFbRg63YvWl4iJ2BJvDkKteFpk68ciXxY7FSF9 0q7Ha6ePVza0SLu68suDqJzKOtuzuWJfOap47dwanezBFLUvwaGSl0qTGX+fNyQ3TKbr xcNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701884146; x=1702488946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EC1WbkFRMsdQ89+qHvQLwas+YHcOCsKWIhN5BFKA96U=; b=HdUXIguMEoxAPgrMduYqy4mWdGvbKgqiK/vrfM5jtHK9tPABCl02NL34l9FXnmAwdy gfXkF6j74n3+VXt9UYVS0Wal0J9dbjCqYHkayBYfCWvx+m/hIPZlr2iyEQCi35puScwl 1kFP1i7rfhxOTqXBSKw9kV3wG6D5HKsRZx+YMiOKszg/6IPDFKnidrMxpNP0TNEOajFH 75tg/aah7AYCdOIayn68N2v9JFmE4tt6f4jVvRsgtBO0H1+tNF84Hln4ni2M96g2Wqf6 lCS1y1vgOtXwDOlD9tGcF5jtj1bB3oX1yXdQr3FGEwYedcF+ipz6sONRFKQDPuTZuBbm R2Cg== X-Gm-Message-State: AOJu0Yz4iJIafYLVQYOXYKS9Z0iipQTe+lAmeI/GHDw48OTFO75gQoN3 vgervg8G4YtrrDx5jFwctuA= X-Received: by 2002:a17:906:2512:b0:a18:e27a:6f05 with SMTP id i18-20020a170906251200b00a18e27a6f05mr891523ejb.22.1701884146253; Wed, 06 Dec 2023 09:35:46 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id md10-20020a170906ae8a00b00a19084099a4sm213464ejb.16.2023.12.06.09.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:35:46 -0800 (PST) Date: Wed, 6 Dec 2023 19:35:43 +0200 From: Vladimir Oltean To: Madhuri.Sripada@microchip.com Cc: sean@geanix.com, Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Arun.Ramadoss@microchip.com, ceggers@arri.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid protocols for xmit handler Message-ID: <20231206173543.ag7xb4vhcjknyiyv@skbuf> References: <20231206071655.1626479-1-sean@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 09:36:01 -0800 (PST) On Wed, Dec 06, 2023 at 05:22:55PM +0000, Madhuri.Sripada@microchip.com wrote: > NULL check is missing here. Don't just leave it there, also explain why.