Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\))
Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler
From:   Sean Nyekjaer <sean@geanix.com>
In-Reply-To: <20231206173543.ag7xb4vhcjknyiyv@skbuf>
Date:   Wed, 6 Dec 2023 18:45:12 +0100
Cc:     Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        Arun.Ramadoss@microchip.com, ceggers@arri.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <2244A511-6F6F-4711-9BE0-30786B021AE5@geanix.com>
References: <20231206071655.1626479-1-sean@geanix.com>
 <DM6PR11MB4124D98726836442169C2C55E184A@DM6PR11MB4124.namprd11.prod.outlook.com>
 <20231206173543.ag7xb4vhcjknyiyv@skbuf>
To:     Vladimir Oltean <olteanv@gmail.com>, Madhuri.Sripada@microchip.com
Precedence: bulk

Hi Vladimir and Madhuri,

> On 6 Dec 2023, at 18.35, Vladimir Oltean <olteanv@gmail.com> wrote:
>=20
> On Wed, Dec 06, 2023 at 05:22:55PM +0000, =
Madhuri.Sripada@microchip.com wrote:
>> NULL check is missing here.

Did here what every other driver does, that uses the =
connect_tag_protocol() method.
(As per Vladimir=E2=80=99s instructions)
Not one of them, does a NULL check.

>=20
> Don't just leave it there, also explain why.

Message to me?

/Sean=