Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 6 Dec 2023 17:45:58 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Petre Rodan <petre.rodan@subdimension.ro>,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Lars-Peter Clausen <lars@metafoo.de>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Andreas Klinger <ak@it-klinger.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC
 series
Message-ID: <20231206174558.27f72d37@jic23-huawei>
In-Reply-To: <ZW4_OoyKSZ3EBL2x@smile.fi.intel.com>
References: <20231204194401.20891-1-petre.rodan@subdimension.ro>
        <20231204194401.20891-2-petre.rodan@subdimension.ro>
        <ZW4_OoyKSZ3EBL2x@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


> > +		ret = match_string(hsc_triplet_variants, HSC_VARIANTS_MAX,
> > +						triplet);
> > +		if (ret < 0)
> > +			return dev_err_probe(dev, -EINVAL,
> > +				"honeywell,pressure-triplet is invalid\n");  
> 
> Still you can use mentioned device property API.
> 

This is one of the rare cases where basing on iio/togreg is
sensible because you do want a feature that only exists there today.
Just state that you have done so in the cover letter.

Jonathan


> ...
> 
> > +		return dev_err_probe(dev, -EINVAL,
> > +			"pressure limits are invalid\n");  
> 
> Indentation?
>