Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1153059rdb; Wed, 6 Dec 2023 09:58:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4ivdsVBNOVMLgfcDEzZZ0mWA4Mxx+lfN03vUnZ81cq6JBEkItshSxmsJv8lhAo4Ax2KNZ X-Received: by 2002:a17:903:11ce:b0:1d1:c917:2e4f with SMTP id q14-20020a17090311ce00b001d1c9172e4fmr1106170plh.107.1701885505921; Wed, 06 Dec 2023 09:58:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701885505; cv=none; d=google.com; s=arc-20160816; b=tN46+J8ftyybmJXmO95rxtuEgaUyEUejrKDpb8PhITtMQjbyB5KvYppOCMVLb0SA1z qNfn/Ex0xdFiVP8Mij91K0IrGWFcImbYkQ/d5GIZTB7vcJqON2bW2+7bVPUDnz8ORlNA 5iLYYuTt+CoD7S7rG7wTk1FBHuJMuWToC0sjyYVN2xGTMkJ3bDy/ama2lX8faKG+jwVR x3FsSrU03J8V/Es8+qLqMMGJ0k2QeSOxWaceLEgnS6CJuO70cGCpAdX7GnR4JjjXdVpl Z7v00/mKz1Qah9mtfD2kj+ZzQHSkuk4rB61ez/ee5L906XRfPqBeJUEA4S4afUnNsNqJ ObNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Snap78XnwhxghrXH/x5DQQflOIE581aXjQMNJjr942g=; fh=f3uT7cPo304gvEyO1WUV+xGHNBhdxHyV2GfhLm2/Kek=; b=FCAVGqV2KC+YTC5AW/n70rRfUl+qKHCByCFbNSLV/ioFT0d08fcVwOUKcsHNf26FcJ 0qN2PialzD6JGab4+KxrkvfHG87aae2xs7Sw/P2AZaPxYElJdpmnYzlUNnynDs2zNQPP ZrNQpJ4g0jem27TdNK8ltHc7t5vRR06UQvZdD1pRTC2OCCSGfDhQ+Ch/hJYwCtlfpwWh u5JJmfwlHpDa10FgVH6Yrfsm+Utv2rbvNV4Kl89GloFk0hd72q9TXaAgfu50fJYH3ZPm 4UR+CrDNxYTdYeUBdwm6K30EU/grJnBYiTGJC0DqnFUXOQCdoRjqyOGm7KhXo0TKs//W rhYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="jhEd/dyd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id e4-20020a170902744400b001cc5ada2b94si145309plt.366.2023.12.06.09.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 09:58:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="jhEd/dyd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 554D68029230; Wed, 6 Dec 2023 09:58:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378951AbjLFR6H (ORCPT + 99 others); Wed, 6 Dec 2023 12:58:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbjLFR6G (ORCPT ); Wed, 6 Dec 2023 12:58:06 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CA2FD44; Wed, 6 Dec 2023 09:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Snap78XnwhxghrXH/x5DQQflOIE581aXjQMNJjr942g=; b=jhEd/dydrVcA4CqjenXKvBzOhR 81C86OaTSZvOMqak9GSj26Gk4YbmuiZYqP7Inoay495Qv5aZdhoCk8XtjbZygZ3zFO1MW8qKrFi2H jyJUerjxpHvoYivz2Tw0Fom0GZl5ibZD6cI47f6RLNKkoLSSNt8ndPXabCTs9v50CaHUmh6n8EwdV h3a11wO9KMQTDIeK5z9Ompws1FrJbStRk/+i8NoSwEjnMVM2d8/eYZK+A65e+FB9FyAW6cFULMbV3 D4ZCe0VCUv3C54OOIhpqqs0icRWLiCRtInXdBESqtPRpMCqUFSNmSUQ2owjCoBA1ulhjzpRpsIDuc qR59KN6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAw9b-00AzA5-00; Wed, 06 Dec 2023 17:57:47 +0000 Date: Wed, 6 Dec 2023 09:57:46 -0800 From: Christoph Hellwig To: Theodore Ts'o Cc: Christoph Hellwig , Yu Kuai , axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, adilger.kernel@dilger.ca, agruenba@redhat.com, jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org, akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis Message-ID: References: <20231205123728.1866699-1-yukuai1@huaweicloud.com> <20231205123728.1866699-2-yukuai1@huaweicloud.com> <20231206175038.GJ509422@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231206175038.GJ509422@mit.edu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 06 Dec 2023 09:58:23 -0800 (PST) On Wed, Dec 06, 2023 at 12:50:38PM -0500, Theodore Ts'o wrote: > This was added because pulling a mounted a USB thumb drive (or a HDD > drops off the SATA bus) while the file system is mounted and actively > in use, would result in a kernel OOPS. If that's no longer true, > that's great, but it would be good to test to make sure this is the > case.... And, surprise, surprise - that didn't just affect ext4. So I ended up fixing this properly in the block layer. > If we really want to remove it, I'd suggest doing this as a separate > commit, so that after we see syzbot reports, or users complaining > about kernel crashes, we can revert the removal if necessary. Yes, this should of course be separate, well documented commit.