Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 6 Dec 2023 14:56:57 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yi Liu <yi.l.liu@intel.com>
Cc:     joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
        eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
        mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
        xin.zeng@intel.com, yan.y.zhao@intel.com
Subject: Re: [PATCH v7 3/3] iommu/vt-d: Add iotlb flush for nested domain
Message-ID: <20231206185657.GC2692119@nvidia.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-4-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231117131816.24359-4-yi.l.liu@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OzZakPdjdbJRFEK1PxwrN2pGyLuRNKhDdKUnAd6isVoXAOteuRo90kZ6pt6W?=
 =?us-ascii?Q?xJigNud9RDX8TtrPPRN08XF1AdEVQleZ1SUlznulMxLTEUhBuc7bJKI+TSsY?=
 =?us-ascii?Q?hToDxmEAUay63jtg0VsTFZ/jVn26c/KWQTnYayci/MPuejd5UgGSEFqYtniO?=
 =?us-ascii?Q?mkx37BXSw221GIB1eD+5IHD34yhbR/lNC3cHWQEBDxnuf0IArlSQK5G9J6wE?=
 =?us-ascii?Q?A3z8cQ4U8mQFnu5IQ4iLz+/FU+NUNIRpF0HoI0RmSx+RtPlWliRYBQDoUIda?=
 =?us-ascii?Q?lSyBJLPQe7ItZjrerD+jc+nbQTWK1cl8/XggnEAl47XGy5AdEzHgf7EG5y+t?=
 =?us-ascii?Q?muIuTjYFr19tKMNXijCn2yWiUD/G3c9KhcLndVSNjx9Z8pEKu1mqfMQWRPaY?=
 =?us-ascii?Q?K7fDvrTHzFqMNLt08qFSvlLNlByhTWni1kJtSAxEz/+EWC4WIqw/WLJEnyKR?=
 =?us-ascii?Q?gto7qXvky5xO389OCXZ1KiR6/iS5c58qalA0kPpNv98x03w2LAQPflOYXjBO?=
 =?us-ascii?Q?GgKi4si1wGn92rTpStGBWlr1BP/RxHLaW4EDLPeU3HQ2xuiGuD3vFvO40HNj?=
 =?us-ascii?Q?MdpiM6471rn4q2vUePMtY43wluHuG9gt3mOKue5IpsbFspbyrX3cbNfniLxO?=
 =?us-ascii?Q?KQMRrDrNuJFmD+/FjJBgpAcxHF+3yqEzRIFEchWSWWYIaDFAsc/r+ucasKVx?=
 =?us-ascii?Q?Sevlf/UgC4UZQ/sKfyuEDzDkeiCZGR1v2yIM06BNCFR6LBiGRjZZgYAW946I?=
 =?us-ascii?Q?3lVj4U5oRpFmyJX04NA7zPMKhJjIE4gLrIkrLmzf8CGDxJgtcV8zaeylaI7R?=
 =?us-ascii?Q?QhlAuKUsP58WUK8+RIuB1a3VD4nscciFDdnU1HEfxvZiZsslGwHcnNokU2GG?=
 =?us-ascii?Q?5KtBgIzUVbzOcrQ5lBOABeGZK5iiwgeHZ38IvE8KQwrdGpF0d8s6UIDpwEdS?=
 =?us-ascii?Q?NfedUCviZ7cvavxkqF7daUOHLFvE0dH3UBcWWDSVYv0y66s3Z4ez4t+NCDDo?=
 =?us-ascii?Q?PHmb4PRYZ/j1UzmTH8L7nqQPFSYXqgJP8LQjUHwyoXHDTLQZFapBJ+SpY+CI?=
 =?us-ascii?Q?meI4wtbwz1fQ8c6UdLwdGDwjYHyNWQJfHOwNpqUoidMjk7+3hPsiQTuNY4oC?=
 =?us-ascii?Q?fUqwPK9tk97spEW7ZUEFcDaRzD4kL1qQKhXPJ7VBuplXpLZUdV63Ufz3Afue?=
 =?us-ascii?Q?FyO2sH6KNtEXLllQ+/dGKWV4CSXA82u7ls+Y4rJ/Nn5xICoFnAn5Vn6VwNID?=
 =?us-ascii?Q?XMAqQ+X+bc1c578OIQDiQnqCaPb7TViXtWXYqpsP74/8Ltt4IZ5qYaoYcS3f?=
 =?us-ascii?Q?AGgI599wTTEIBuloIWwohFNm4fvEZ7AC8XR/y8ARtcrcj3UQrVahQYKdBCUp?=
 =?us-ascii?Q?gwL9SldejFfX2n6vJ0Y+R2qSGjaYfzMBDfg8EQqTCx1CC6ILIbYz8jmBSDDb?=
 =?us-ascii?Q?5pUHU9vjr0+Seu1qA9SeXlaitZdpi2oBU+2AlBKTBXmGOQQKd0MleEhpOicu?=
 =?us-ascii?Q?i/syOHqXPUDqSTRHaLbRJ9WeX4tNKdvyeIDhxJFrPXkbc2UOdPcsTEFmoyHG?=
 =?us-ascii?Q?Kc+R7AiV1fBmoc1G9cfG8QEkqx9nEF40c2yJe1cy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21327926-6b38-4993-d729-08dbf68d1fca
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 18:56:58.9676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JmDbYFupTItlLaCKLQgc3cLl5etBV3nAl16clfUno8jduPkWsj3pEuFVpf3dIQkj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9211
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 06 Dec 2023 10:57:12 -0800 (PST)

On Fri, Nov 17, 2023 at 05:18:16AM -0800, Yi Liu wrote:
> +static int intel_nested_cache_invalidate_user(struct iommu_domain *domain,
> +					      struct iommu_user_data_array *array,
> +					      u32 *cerror_idx)
> +{
> +	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> +	struct iommu_hwpt_vtd_s1_invalidate inv_info;
> +	u32 index;
> +	int ret;
> +
> +	/* REVISIT:
> +	 * VT-d has defined ITE, ICE, IQE for invalidation failure per hardware,
> +	 * but no error code yet, so just set the error code to be 0.
> +	 */
> +	*cerror_idx = 0;
> +
> +	for (index = 0; index < array->entry_num; index++) {
> +		ret = iommu_copy_struct_from_user_array(&inv_info, array,
> +							IOMMU_HWPT_DATA_VTD_S1,
> +							index, __reserved);
> +		if (ret) {
> +			pr_err_ratelimited("Failed to fetch invalidation request\n");
> +			break;

No error prints on ioctls!

> +		if (inv_info.addr == 0 && inv_info.npages == -1)
> +			intel_flush_iotlb_all(domain);

-1 is clearer written as U64_MAX - same remark for the comment
documenting it.

Jason