Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Wed, 6 Dec 2023 13:56:07 -0500
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: move THIS_MODULE from <linux/export.h> to
 <linux/init.h>
Message-ID: <ZXDDx4/g4Le38oEh@windriver.com>
References: <20231126071914.932241-1-masahiroy@kernel.org>
 <CAK7LNATEJ80O8r-B+ByBykNVhDR2SW9_cBDArhz1W75KNW=z_A@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNATEJ80O8r-B+ByBykNVhDR2SW9_cBDArhz1W75KNW=z_A@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rjP8TyE/oIksrR7Tc2GJuOzNklT5gkuXL/T9i1BfyetnLKijV8CmKwWcavls?=
 =?us-ascii?Q?8GDofTS9bTt7IytXLv1pS5DoZtWnRV5YwbIgMME/4NhN1s7qtccxSUSaG762?=
 =?us-ascii?Q?RplsSapS3VTGHQ1kCN0UsDbfordrXQpsZOSremlsz3Ejpg1iqF1k5wLAmePO?=
 =?us-ascii?Q?r6Dk7sJpO07rR0Urig+KIIdd9jNniBFz9UszZ9R6Yh8EXfYekBqX739DNFuU?=
 =?us-ascii?Q?DT0p2jd8Olq3wS/+YSKHaUIjky2XjuIuMZ+1eQzJ4cheaCQCo8ec8SiaeCWp?=
 =?us-ascii?Q?m2G9EEh5gexDY2e/6DL1WN8Fvk3eJXhICUrLl8QFfD5RraZ3W8mQipQwU2LL?=
 =?us-ascii?Q?z5B25g17JOb1r3PrGfow0QBBZLYsIF7Bfi5CBv+D5aonYJdz5asMLWvbn0E7?=
 =?us-ascii?Q?C+wbz9toz5Pjs9/g32NvRuZZuBCP0ix85gZyYezg2ZoManADL3dlaNcFpfnT?=
 =?us-ascii?Q?UF8BQheoLVO+oVqTYC7wuBTK5LDckWzU37epG7Dphx867ToHMkAddvP4Sysc?=
 =?us-ascii?Q?FYd7zi+omgx0ulcrart23DUblj7sXbg3WQ/PwE9IZ94SNl86GGcZ8MMFApJA?=
 =?us-ascii?Q?3sf4SKFyNVERLT3MQ+1ff/lw9ACcffDdCe7MAMNZDtORgqv9LZKjNIkW//Jd?=
 =?us-ascii?Q?JoIxHosx8G34EzyDTjc8bFDmdiEykDZ0PDTtSIwIdsi0XOU44XVe7zOsokFZ?=
 =?us-ascii?Q?qrPmvTpZe8D9f4/k+oYa7l1gPcpmxh9yyDjhetFkYnzq1C3WFHt2c/R/X+a1?=
 =?us-ascii?Q?1rym6M1UJdSpbUDZWbBJ++sHbUNZ3OwIt35x0Jd1CYJxMWaS2cIFcufZifBK?=
 =?us-ascii?Q?zForY8L4X7mcKHGCRUOnG7eqVmUq3c/d2mxzS3Xe2mN5cozyAUOmKvGyJ3Bj?=
 =?us-ascii?Q?jZiQNOCT6EN4gfv2K65t+tLMT7VZ5C9dEzPQaoPurEShiZBfoHd5WZ3AXoyF?=
 =?us-ascii?Q?9BojisrNMN44+Q1F//Uot0U95DQH/9uepie/fBWTEaKNJSRvYOgi8jL9EPsk?=
 =?us-ascii?Q?l4+EUGvloryHvPx5kqQjaZqWOUabjr0Zk78mdJ/UNxUTNg0LAarhyOmUdx3h?=
 =?us-ascii?Q?STEARiPMoM7hJ6KB6r5A0QBWNhBbChLGshZ2JyKxyB7w67wfNLhKtdz/wpeG?=
 =?us-ascii?Q?P0Au0W0XwpCeoeSS34wlSDcheQw/PuAvtmNITrb2HXAgHuY6Abaj4+HoClVT?=
 =?us-ascii?Q?pBB3TGr9kUzjkTYLwbQqnYw5UyEmvl8W0Dd4K6y0gKUEQwUJ3OCQYylhnbvO?=
 =?us-ascii?Q?q3AzgwaWaroEm2wUdhEXx2ln4DO0fKFlMFBndBns/UnJ9jhnZ3v8V3HuLr/r?=
 =?us-ascii?Q?6vtlnRhoTCI/gXoBZO+8v/zJnzByTOQB6vULry6p8KAPkRMc/NhZIH5rWJYP?=
 =?us-ascii?Q?aBAHVxLQo79WRhimO+O93IjSC5ZXnRgrYCNzmL5PjJ1xyjgpx65vlwVGWQAE?=
 =?us-ascii?Q?wgUeP8VZPfjusk3EumBzkB5t1vfTA5IVotR6OkdQDyEXUxFZ9hccMSTiMoLl?=
 =?us-ascii?Q?Q64Y/pzFetWnJSLqm8jm9+jKKFC7VdaD9clvd9qkUUAb4eN+yfZGxk1GSnsA?=
 =?us-ascii?Q?Sbeh9wecD18xJ4zG4qE4uih8uR0blck2+iHr6oT6eiENU8ITe4DmOxdq+fsq?=
 =?us-ascii?Q?Rw=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ad2f20b-3acf-4459-23ff-08dbf68d03c0
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7378.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 18:56:11.8472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /lt9IS7CNZUpuwNj3qUXghE4Mgyg98vYWaqfCvMv5hfdvLNSLf3sqRRC1eIxHAYQ7oz1CZfXlDrnSqHG6nwqYi8PhqsaZWqfYxRLsi7T5NQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8082
X-Proofpoint-ORIG-GUID: SYVw_WiOM6efgN4LXbmZUCyRL-KO73m5
X-Proofpoint-GUID: SYVw_WiOM6efgN4LXbmZUCyRL-KO73m5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 lowpriorityscore=0 impostorscore=0 priorityscore=1501 clxscore=1011
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2312060141
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 06 Dec 2023 10:58:08 -0800 (PST)

[Re: [PATCH] init: move THIS_MODULE from <linux/export.h> to <linux/init.h>] On 03/12/2023 (Sun 19:06) Masahiro Yamada wrote:

> On Sun, Nov 26, 2023 at 4:19???PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Commit f50169324df4 ("module.h: split out the EXPORT_SYMBOL into
> > export.h") appropriately separated EXPORT_SYMBOL into <linux/export.h>
> > because modules and EXPORT_SYMBOL are orthogonal; modules are symbol
> > consumers, while EXPORT_SYMBOL are used by symbol providers, which
> > may not be necessarily a module.
> >
> > However, that commit also relocated THIS_MODULE. As explained in the
> > commit description, the intention was to define THIS_MODULE in a
> > lightweight header, but I do not believe <linux/export.h> was the
> > suitable location because EXPORT_SYMBOL and THIS_MODULE are unrelated.
> >
> > Move it to another lightweight header, <linux/init.h>. The reason for
> > choosing <linux/init.h> is to make <linux/moduleparam.h> self-contained
> > without relying on <linux/linkage.h> incorrectly including
> > <linux/export.h>.
> >
> > With this adjustment, the role of <linux/export.h> becomes clearer as
> > it only defines EXPORT_SYMBOL.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> 
> 
> Applied to kbuild.
> 
> I did not get any report from the 0day bot so far,
> but I hope it will get a little more compile tests
> before getting into linux-next.

Haven't touched that kind of header shuffle for over 10 years?

But yeah, it is near impossible to not trip over some implicit header
inclusion somewhere in some driver or a less common arch and hence break
the build at least once when doing this kind of stuff.

Paul.
--

> 
> 
> 
> >
> >  include/linux/export.h | 18 ------------------
> >  include/linux/init.h   |  7 +++++++
> >  2 files changed, 7 insertions(+), 18 deletions(-)
> >
> > diff --git a/include/linux/export.h b/include/linux/export.h
> > index 9911508a9604..0bbd02fd351d 100644
> > --- a/include/linux/export.h
> > +++ b/include/linux/export.h
> > @@ -6,15 +6,6 @@
> >  #include <linux/linkage.h>
> >  #include <linux/stringify.h>
> >
> > -/*
> > - * Export symbols from the kernel to modules.  Forked from module.h
> > - * to reduce the amount of pointless cruft we feed to gcc when only
> > - * exporting a simple symbol or two.
> > - *
> > - * Try not to add #includes here.  It slows compilation and makes kernel
> > - * hackers place grumpy comments in header files.
> > - */
> > -
> >  /*
> >   * This comment block is used by fixdep. Please do not remove.
> >   *
> > @@ -23,15 +14,6 @@
> >   * side effect of the *.o build rule.
> >   */
> >
> > -#ifndef __ASSEMBLY__
> > -#ifdef MODULE
> > -extern struct module __this_module;
> > -#define THIS_MODULE (&__this_module)
> > -#else
> > -#define THIS_MODULE ((struct module *)0)
> > -#endif
> > -#endif /* __ASSEMBLY__ */
> > -
> >  #ifdef CONFIG_64BIT
> >  #define __EXPORT_SYMBOL_REF(sym)                       \
> >         .balign 8                               ASM_NL  \
> > diff --git a/include/linux/init.h b/include/linux/init.h
> > index 01b52c9c7526..3fa3f6241350 100644
> > --- a/include/linux/init.h
> > +++ b/include/linux/init.h
> > @@ -179,6 +179,13 @@ extern void (*late_time_init)(void);
> >
> >  extern bool initcall_debug;
> >
> > +#ifdef MODULE
> > +extern struct module __this_module;
> > +#define THIS_MODULE (&__this_module)
> > +#else
> > +#define THIS_MODULE ((struct module *)0)
> > +#endif
> > +
> >  #endif
> >
> >  #ifndef MODULE
> > --
> > 2.40.1
> >
> 
> 
> -- 
> Best Regards
> Masahiro Yamada