Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <e4823a44-33a9-4dbf-a39d-66ae256b903a@kernel.org>
Date:   Wed, 6 Dec 2023 12:15:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] neighbour: Don't let neigh_forced_gc() disable
 preemption for long
Content-Language: en-US
To:     Doug Anderson <dianders@chromium.org>
Cc:     Stephen Hemminger <stephen@networkplumber.org>,
        Judy Hsiao <judyhsiao@chromium.org>,
        Eric Dumazet <edumazet@google.com>,
        Simon Horman <horms@kernel.org>,
        Brian Haley <haleyb.dev@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Joel Granados <joel.granados@gmail.com>,
        Julian Anastasov <ja@ssi.bg>,
        Leon Romanovsky <leon@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
References: <20231206033913.1290566-1-judyhsiao@chromium.org>
 <20231206093917.04fd57b5@hermes.local>
 <efd58582-31b6-47f0-ba14-bf369fddd1c0@kernel.org>
 <CAD=FV=UgPZoXsGTgLV_4X9x2hGTMouO3Tpe9_WkwhU7Bsvav2Q@mail.gmail.com>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <CAD=FV=UgPZoXsGTgLV_4X9x2hGTMouO3Tpe9_WkwhU7Bsvav2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/6/23 11:49 AM, Doug Anderson wrote:
> Hi,
> 
> On Wed, Dec 6, 2023 at 9:51 AM David Ahern <dsahern@kernel.org> wrote:
>>
>> On 12/6/23 10:39 AM, Stephen Hemminger wrote:
>>> On Wed,  6 Dec 2023 03:38:33 +0000
>>> Judy Hsiao <judyhsiao@chromium.org> wrote:
>>>
>>>> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
>>>> index df81c1f0a570..552719c3bbc3 100644
>>>> --- a/net/core/neighbour.c
>>>> +++ b/net/core/neighbour.c
>>>> @@ -253,9 +253,11 @@ static int neigh_forced_gc(struct neigh_table *tbl)
>>>>  {
>>>>      int max_clean = atomic_read(&tbl->gc_entries) -
>>>>                      READ_ONCE(tbl->gc_thresh2);
>>>> +    u64 tmax = ktime_get_ns() + NSEC_PER_MSEC;
>>>>      unsigned long tref = jiffies - 5 * HZ;
>>>>      struct neighbour *n, *tmp;
>>>>      int shrunk = 0;
>>>> +    int loop = 0;
>>>>
>>>>      NEIGH_CACHE_STAT_INC(tbl, forced_gc_runs);
>>>>
>>>> @@ -278,11 +280,16 @@ static int neigh_forced_gc(struct neigh_table *tbl)
>>>>                              shrunk++;
>>>>                      if (shrunk >= max_clean)
>>>>                              break;
>>>> +                    if (++loop == 16) {
>>>
>>> Overall looks good.
>>> Minor comments:
>>>       - loop count should probably be unsigned
>>>         - the magic constant 16 should be a sysctl tuneable
>>
>> A tunable is needed here; the loop counter is just to keep the overhead
>> of the ktime_get_ns call in check.
> 
> From context, I'm going to assume you meant a tunable is _NOT_ needed here. ;-)
> 
> -Doug

yes, multitasking fail :-(