Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <0c1bb5e8-1ad2-4bda-b038-456d9791f9b7@infradead.org>
Date:   Wed, 6 Dec 2023 11:46:22 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Nathan Chancellor <nathan@kernel.org>
References: <20231206172037.12072-1-rdunlap@infradead.org>
 <d0323841-a3a7-45b7-b702-0a08f9250c55@roeck-us.net>
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <d0323841-a3a7-45b7-b702-0a08f9250c55@roeck-us.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/6/23 10:49, Guenter Roeck wrote:
> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
>> to fix a kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>>   Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>   Selected by [y]:
>>   - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>>
> 
> All but impossible for me to determine if this patch or
> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
> is more appropriate.
> 
> Guenter

I guess that Bryan is the person to ask about that.

I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning,
so as long as it builds cleanly, it seems OK.

> 
>> Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> Cc: linux-usb@vger.kernel.org
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/usb/typec/tcpm/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
>> --- a/drivers/usb/typec/tcpm/Kconfig
>> +++ b/drivers/usb/typec/tcpm/Kconfig
>> @@ -80,6 +80,7 @@ config TYPEC_QCOM_PMIC
>>  	tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver"
>>  	depends on ARCH_QCOM || COMPILE_TEST
>>  	depends on DRM || DRM=n
>> +	depends on OF
>>  	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE
>>  	help
>>  	  A Type-C port and Power Delivery driver which aggregates two

-- 
~Randy