Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Wed, 6 Dec 2023 22:10:54 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sean Nyekjaer <sean@geanix.com>
Cc:     Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Christian Eggers <ceggers@arri.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler
Message-ID: <20231206201054.7ketpxxox5y2wnby@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206071655.1626479-1-sean@geanix.com>
 <20231206071655.1626479-1-sean@geanix.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nyBG1/mR07cj/+34XC7adqq/aLt6T/UM7zBojcdG7s8HBOyji8fjB6iKyzKT?=
 =?us-ascii?Q?o8xctXGOgqG6LIr1pPFEO+m28u+2XtKGpdGc0mNo+qNuAzrG0FozbDTPHTm2?=
 =?us-ascii?Q?c54WLUpr5v2iR8nsMHfcTMgyK/h9+Nfkx17MJkaibKe6GWB3zaIYWv1Ka3yd?=
 =?us-ascii?Q?C4Et1k9BowjbJXPNFth1xsMj+OPgub9xUXbV3z2HwoU1RddsSISayoJ5kmle?=
 =?us-ascii?Q?QStMnU+Pca2AZskajvc83/ONLgI2Iwi/fn+YcXJNG3x1jbF8Ylx3p+nBJQy1?=
 =?us-ascii?Q?W9OwwOs5BJZDZ/fedhOYEnsKWfOERKzalR6vDmKMZfDrJK08DrFxVYvHYnOz?=
 =?us-ascii?Q?knHzCZd4hQ4Rylwih9SGF9g/y2CwGSKe6s2fUh/OIo4KDbDSlaP9VGRaD2F5?=
 =?us-ascii?Q?PAqtPnOQgNAHBh5me1F2MzT2HqOdHbWrofr2V61nNXaG3fdU/MQYRF65kkCD?=
 =?us-ascii?Q?0DObbTPMZpyGzNULwQJvhOS63cd0IM3MN3E0VOOiHCVgmOiF0xF/4ZflJP69?=
 =?us-ascii?Q?zd7J+8fbbqPIS/pGaUWgfT5/DBZGdU665WXst6pxTJjH66LmzEUf7KQf4ApA?=
 =?us-ascii?Q?4j8B/unswOlFXPftaMI/L8hF6Aaq8zlDCRyGUQBhCeAOnlnVi4WT6Zmcedqv?=
 =?us-ascii?Q?vL1Q9ab2KizQNPnYprbXbwhjyCBxNsVRW3t8dPEh8oAa8WMJis8O+RWGV+Hs?=
 =?us-ascii?Q?uEFOYuqL3D8jVnG3b0IgLfNf1Axvrt52n4D3hR5EVyOYwKE7XNnWZgiCcHxr?=
 =?us-ascii?Q?SWy0Y9WM8Sp6aoWuv5d7uXZn4hiS+1OqdmQByuUI5uwkrQGzu28ZZTwARPGa?=
 =?us-ascii?Q?fAsMaoUK+8F4liBDxQUp9FZsytXsc1x7JTJusPDo5uw2RNPJbZghwCdQT/La?=
 =?us-ascii?Q?aFLiK/VK35gRY1I+IlZBdfBFLIF5HkIEm5zd0GSQDGwKcLOflc4E6/oIllgA?=
 =?us-ascii?Q?M1898TKuazDlK0hghhKrszU8TK3KAoUKvSKH1lns4XGeKwGVr/IsA6ZKBV7L?=
 =?us-ascii?Q?1PnvEZxzoW4yIiFp8zc8QGm7e+DHWSeAjmaV5j4neWyHv3fUuCqfL6vTIT5e?=
 =?us-ascii?Q?4w/bPAEEZJj1AoREXkVcWrJKIrr5SWD60MMndsuQ8AQZtFVeqUBbMRAFK+MH?=
 =?us-ascii?Q?A28xSOsi3kV7wp8MIDZ+7HgeVg8t2Wgwln1yRkR+1fgGKqCBzS5071lGkFx3?=
 =?us-ascii?Q?XFsDF6AF5UotGHwK0yHooGzeORLNdBdLf3DNmoinhHhgXepaR1+ZEWZsA16y?=
 =?us-ascii?Q?GQFaTPjSOgx4iA7MCJfHds+KFUr76pNc1kOBXsrYONRk+M4qujTlTjxqo17L?=
 =?us-ascii?Q?pVr9dvxhDiDr/L85hxNYKDGESiZ0dAMA0RNhaQ9CpzTnlVuBscAjrzWQZUay?=
 =?us-ascii?Q?67zNrhjoBDfVEnAklrPR6MzxRJy+3vS3tSeFyWoGzGZtXhuizYRlCUw0Ty2S?=
 =?us-ascii?Q?Xd6sYFuQbIezvbxGZ4pZN55O+E8Wm0mil4nYr53htPU/q0skKdfYj306OOQ+?=
 =?us-ascii?Q?SgoEfathAEqORwPEhxaWpBgC8hnvN9r2CDb5vOf1qLzCM2S0oDNgXNS7gFS5?=
 =?us-ascii?Q?JWVa/xoi1nKQD3Mvh5UNUx0ih9bMoIdFFolDja5XPpdwfthkuIGEK5dQimyT?=
 =?us-ascii?Q?xA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0733f7fc-c15e-44cb-fcd6-08dbf69775b1
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 20:10:58.3108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0wWnUfJms4KiNryx5il0xL3dDv+dBAD8wScWw3Ta3bdSRZ5WApAfXHVwZlApmNIhDvDkuAGyt66W94Fx8EIzXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9792
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 06 Dec 2023 12:11:18 -0800 (PST)

On Wed, Dec 06, 2023 at 08:16:54AM +0100, Sean Nyekjaer wrote:
> Provide a list of valid protocols for which the driver will provide
> it's deferred xmit handler.
> 
> When using DSA_TAG_PROTO_KSZ8795 protocol, it does not provide a
> "connect" method, therefor ksz_connect() is not allocating ksz_tagger_data.
> 
> This avoids the following null pointer dereference:
>  ksz_connect_tag_protocol from dsa_register_switch+0x9ac/0xee0
>  dsa_register_switch from ksz_switch_register+0x65c/0x828
>  ksz_switch_register from ksz_spi_probe+0x11c/0x168
>  ksz_spi_probe from spi_probe+0x84/0xa8
>  spi_probe from really_probe+0xc8/0x2d8
> 
> Fixes: ab32f56a4100 ("net: dsa: microchip: ptp: add packet transmission timestamping")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>