Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <d071fdad-79cb-4b8b-ab18-132b6c77e2ed@gmail.com>
Date:   Wed, 6 Dec 2023 13:53:06 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 net] net: dsa: microchip: provide a list of valid
 protocols for xmit handler
Content-Language: en-US
To:     Sean Nyekjaer <sean@geanix.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Christian Eggers <ceggers@arri.de>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231206071655.1626479-1-sean@geanix.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20231206071655.1626479-1-sean@geanix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/5/23 23:16, Sean Nyekjaer wrote:
> Provide a list of valid protocols for which the driver will provide
> it's deferred xmit handler.
> 
> When using DSA_TAG_PROTO_KSZ8795 protocol, it does not provide a
> "connect" method, therefor ksz_connect() is not allocating ksz_tagger_data.
> 
> This avoids the following null pointer dereference:
>   ksz_connect_tag_protocol from dsa_register_switch+0x9ac/0xee0
>   dsa_register_switch from ksz_switch_register+0x65c/0x828
>   ksz_switch_register from ksz_spi_probe+0x11c/0x168
>   ksz_spi_probe from spi_probe+0x84/0xa8
>   spi_probe from really_probe+0xc8/0x2d8
> 
> Fixes: ab32f56a4100 ("net: dsa: microchip: ptp: add packet transmission timestamping")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian